Skip to content

Commit bb976f7

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
Update node_module dependecies
Add one more deps "@typescript-eslint/utils" to top level to be used in our own custom rules (also needed override if I didn't). Bug: none Change-Id: I130415d1ec5f096ca51200df3eb688dadd963d0f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6343232 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
1 parent c0835fa commit bb976f7

File tree

2,527 files changed

+50325
-34412
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,527 files changed

+50325
-34412
lines changed

extensions/cxx_debugging/src/CustomFormatters.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export interface Value {
5353
asInt64: () => bigint;
5454
asFloat32: () => number;
5555
asFloat64: () => number;
56-
asDataView: (offset?: number, size?: number) => DataView;
56+
asDataView: (offset?: number, size?: number) => DataView<ArrayBuffer>;
5757
$: (member: string|number) => Value;
5858
getMembers(): string[];
5959
}
@@ -97,7 +97,7 @@ export class MemorySlice {
9797
return this.length + this.begin;
9898
}
9999

100-
view(begin: number, length: number): DataView {
100+
view(begin: number, length: number): DataView<ArrayBuffer> {
101101
return new DataView(this.buffer, begin - this.begin, length);
102102
}
103103
}
@@ -174,7 +174,7 @@ export class WasmMemoryView {
174174
return {page, offset, count};
175175
}
176176

177-
private getPages(page: number, count: number): DataView {
177+
private getPages(page: number, count: number): DataView<ArrayBuffer> {
178178
if (page & (WasmMemoryView.PAGE_SIZE - 1)) {
179179
throw new Error('Not a valid page');
180180
}
@@ -240,7 +240,7 @@ export class WasmMemoryView {
240240
const view = this.getPages(page, count);
241241
return view.getBigUint64(offset, littleEndian);
242242
}
243-
asDataView(byteOffset: number, byteLength: number): DataView {
243+
asDataView(byteOffset: number, byteLength: number): DataView<ArrayBuffer> {
244244
const {offset, page, count} = this.page(byteOffset, byteLength);
245245
const view = this.getPages(page, count);
246246
return new DataView(view.buffer, view.byteOffset + offset, byteLength);
@@ -251,7 +251,7 @@ export class CXXValue implements Value, LazyObject {
251251
readonly location: number;
252252
private readonly type: TypeInfo;
253253
private readonly data?: number[];
254-
private readonly memoryOrDataView: DataView|WasmMemoryView;
254+
private readonly memoryOrDataView: DataView<ArrayBuffer>|WasmMemoryView;
255255
private readonly wasm: WasmInterface;
256256
private readonly typeMap: Map<unknown, TypeInfo>;
257257
private readonly memoryView: WasmMemoryView;
@@ -419,7 +419,7 @@ export class CXXValue implements Value, LazyObject {
419419
asFloat64(): number {
420420
return this.memoryOrDataView.getFloat64(this.location, true);
421421
}
422-
asDataView(offset?: number, size?: number): DataView {
422+
asDataView(offset?: number, size?: number): DataView<ArrayBuffer> {
423423
offset = this.location + (offset ?? 0);
424424
size = size ?? this.size;
425425
if (this.memoryOrDataView instanceof DataView) {

extensions/cxx_debugging/src/Formatters.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,11 @@ function formatLibCXXString<T extends CharArrayConstructor>(
9696

9797
const copyLen = Math.min(stringSize * charSize, Constants.MAX_STRING_LEN);
9898
const bytes = wasm.readMemory(data, copyLen);
99-
// @ts-expect-error https://github.com/microsoft/TypeScript/pull/60934
10099
const text = new charType(bytes.buffer, bytes.byteOffset, stringSize) as InstanceType<T>;
101100
return {size: stringSize, string: decode(text)};
102101
}
103102

104103
const bytes = shortString.$('__data_').asDataView(0, size * charSize);
105-
// @ts-expect-error https://github.com/microsoft/TypeScript/pull/60934
106104
const text = new charType(bytes.buffer, bytes.byteOffset, size) as InstanceType<T>;
107105
return {size, string: decode(text)};
108106
}
@@ -167,7 +165,6 @@ function formatRawString<T extends CharArrayConstructor>(
167165
// Copy PAGE_SIZE bytes
168166
const buffer = deref.asDataView(bufferSize, Constants.PAGE_SIZE);
169167
// Convert to charType
170-
// @ts-expect-error https://github.com/microsoft/TypeScript/pull/60934
171168
const substr = new charType(buffer.buffer, buffer.byteOffset, buffer.byteLength / charSize);
172169
const strlen = substr.indexOf(0);
173170
if (strlen >= 0) {

extensions/cxx_debugging/tests/Formatters_test.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ describe('Formatters', () => {
4444
// short string
4545

4646
const shortString = 'abcdef\0';
47-
const shortStringValue = new TestValue(new DataView(new TextEncoder().encode(shortString).buffer), 'char');
47+
const shortStringValue =
48+
new TestValue(new DataView(new TextEncoder().encode(shortString).buffer as ArrayBuffer), 'char');
4849
assert.deepEqual(
4950
Formatters.formatCString(wasm, TestValue.pointerTo(shortStringValue, Formatters.Constants.SAFE_HEAP_START)),
5051
'abcdef');
@@ -60,7 +61,8 @@ describe('Formatters', () => {
6061

6162
// long string
6263
const longString = `${new Array(Formatters.Constants.PAGE_SIZE / 4).fill('abcdefg').join('')}\0`;
63-
const longStringValue = new TestValue(new DataView(new TextEncoder().encode(longString).buffer), 'char');
64+
const longStringValue =
65+
new TestValue(new DataView(new TextEncoder().encode(longString).buffer as ArrayBuffer), 'char');
6466
assert.deepEqual(
6567
Formatters.formatCString(wasm, TestValue.pointerTo(longStringValue, Formatters.Constants.SAFE_HEAP_START)),
6668
longString.substr(0, longString.length - 1));
@@ -96,7 +98,8 @@ describe('Formatters', () => {
9698
});
9799

98100
// short char8_t
99-
__s.members.__data_ = new TestValue(new DataView(new TextEncoder().encode(shortString).buffer), 'char');
101+
__s.members.__data_ =
102+
new TestValue(new DataView(new TextEncoder().encode(shortString).buffer as ArrayBuffer), 'char');
100103
__s_union.members.__size_ = shortFlag;
101104

102105
assert.deepEqual(Formatters.formatLibCXX8String(wasm, str), {size: shortString.length, string: shortString});

extensions/cxx_debugging/tests/TestUtils.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export class TestWasmInterface implements WasmInterface {
110110
}
111111

112112
export class TestValue implements Value {
113-
private dataView: DataView;
113+
private dataView: DataView<ArrayBuffer>;
114114
members: {[key: string]: TestValue, [key: number]: TestValue};
115115
location: number;
116116
size: number;
@@ -213,7 +213,7 @@ export class TestValue implements Value {
213213
asFloat64(): number {
214214
return this.dataView.getFloat64(0, true);
215215
}
216-
asDataView(offset?: number, size?: number): DataView {
216+
asDataView(offset?: number, size?: number): DataView<ArrayBuffer> {
217217
offset = this.location + (offset ?? 0);
218218
size = Math.min(size ?? this.size, this.size - Math.max(0, offset));
219219
return new DataView(this.dataView.buffer, offset, size);
@@ -233,7 +233,9 @@ export class TestValue implements Value {
233233
return value;
234234
}
235235

236-
constructor(content: DataView, typeName: string, members?: {[key: string]: TestValue, [key: number]: TestValue}) {
236+
constructor(
237+
content: DataView<ArrayBuffer>, typeName: string,
238+
members?: {[key: string]: TestValue, [key: number]: TestValue}) {
237239
this.location = 0;
238240
this.size = content.byteLength;
239241
this.typeNames = [typeName];

front_end/core/sdk/RemoteObject.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,8 +576,11 @@ export class RemoteObjectImpl extends RemoteObject {
576576
silent: true,
577577
returnByValue: true,
578578
});
579+
if (response.getError() || response.exceptionDetails) {
580+
return null as T;
581+
}
579582

580-
return response.getError() || response.exceptionDetails ? null : response.result.value;
583+
return response.result.value;
581584
}
582585

583586
override release(): void {

front_end/panels/ai_assistance/components/chatView.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,8 @@
270270
width: 100%;
271271
padding: var(--sys-size-7) var(--sys-size-5);
272272
font-size: 12px;
273-
word-break: break-word;
273+
word-break: normal;
274+
overflow-wrap: anywhere;
274275
border-bottom: var(--sys-size-1) solid var(--sys-color-divider);
275276

276277
&:last-of-type {

front_end/panels/animation/animationTimeline.css

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,13 @@
4040
}
4141

4242
path.animation-keyframe {
43+
/* stylelint-disable-next-line declaration-property-value-no-unknown */
4344
fill-opacity: 20%;
4445
}
4546

4647
.animation-node-selected path.animation-keyframe,
4748
svg.animation-ui g:first-child:hover path.animation-keyframe {
49+
/* stylelint-disable-next-line declaration-property-value-no-unknown */
4850
fill-opacity: 40%;
4951
}
5052

@@ -110,7 +112,7 @@ circle.animation-keyframe-point:active {
110112
}
111113

112114
.animation-timeline-header::after {
113-
content: "";
115+
content: '';
114116
height: calc(100% - 48px - 28px);
115117
position: absolute;
116118
width: var(--timeline-controls-width);
@@ -144,8 +146,7 @@ circle.animation-keyframe-point:active {
144146
cursor: pointer;
145147
}
146148

147-
.animation-timeline-buffer
148-
{
149+
.animation-timeline-buffer {
149150
height: 48px;
150151
flex: 0 0 auto;
151152
border-bottom: 1px solid var(--sys-color-divider);
@@ -183,7 +184,13 @@ circle.animation-keyframe-point:active {
183184

184185
.animation-scrubber-line {
185186
width: 11px;
186-
background: linear-gradient(to right, transparent 5px, var(--sys-color-error) 5px, var(--sys-color-error) 6px, transparent 6px);
187+
background: linear-gradient(
188+
to right,
189+
transparent 5px,
190+
var(--sys-color-error) 5px,
191+
var(--sys-color-error) 6px,
192+
transparent 6px
193+
);
187194
position: absolute;
188195
top: -28px;
189196
height: 28px;
@@ -362,7 +369,10 @@ text.animation-timeline-grid-label {
362369
display: none;
363370
}
364371

365-
.animation-timeline-buffer:not(:empty) ~ .animation-timeline-rows:empty ~.animation-timeline-buffer-hint:not(:empty) ~ .animation-timeline-rows-hint,
372+
.animation-timeline-buffer:not(:empty)
373+
~ .animation-timeline-rows:empty
374+
~ .animation-timeline-buffer-hint:not(:empty)
375+
~ .animation-timeline-rows-hint,
366376
.animation-timeline-buffer:empty ~ .animation-timeline-buffer-hint {
367377
font-size: 14px;
368378
display: flex;
@@ -451,7 +461,7 @@ text.animation-timeline-grid-label {
451461

452462
.animation-paused::before,
453463
.animation-paused::after {
454-
content: "";
464+
content: '';
455465
background: var(--sys-color-cdt-base-container);
456466
width: 7px;
457467
height: 20px;
@@ -469,7 +479,9 @@ text.animation-timeline-grid-label {
469479
}
470480

471481
.animation-buffer-preview.selected > svg > line {
472-
stroke: var(--sys-color-on-tonal-container) !important; /* stylelint-disable-line declaration-no-important */
482+
stroke: var(
483+
--sys-color-on-tonal-container
484+
) !important; /* stylelint-disable-line declaration-no-important */
473485
}
474486

475487
@keyframes newGroupAnim {

front_end/panels/application/resourcesPanel.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767

6868
.storage-view.query {
6969
padding: 2px 0;
70-
overflow: hidden overlay;
70+
overflow: hidden auto;
7171
}
7272

7373
.storage-view .filter-bar {

front_end/panels/elements/stylesSidebarPane.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,9 @@
233233
}
234234
}
235235

236-
.styles-pane:not(.is-editing-style) .styles-section.matched-styles:not(.read-only):hover .sidebar-pane-section-toolbar.new-rule-toolbar {
236+
.styles-pane:not(.is-editing-style)
237+
.styles-section.matched-styles:not(.read-only):hover
238+
.sidebar-pane-section-toolbar.new-rule-toolbar {
237239
visibility: visible;
238240
}
239241

@@ -248,7 +250,7 @@
248250
@media (forced-colors: active) {
249251
.sidebar-pane-section-toolbar {
250252
forced-color-adjust: none;
251-
border-color: 1px solid ButtonText;
253+
border: 1px solid ButtonText;
252254
background-color: ButtonFace;
253255
}
254256

front_end/panels/media/playerListView.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ li.storage-group-list-item::before {
5757
height: 26px;
5858
width: 125px;
5959
min-width: 125px;
60-
text-overflow: elipsis;
60+
text-overflow: ellipsis;
6161
padding: 0 10px;
6262
border-right: 1px solid var(--sys-color-divider);
6363
overflow: hidden;

0 commit comments

Comments
 (0)