Do not replace function parameters

Bug: 400353541
Change-Id: Ia77304e4cde91b216b9e4f90bfc2fba645c576ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6409254
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>

Author: danilsomsikov

scripts/eslint_rules/lib/no-imperative-dom-api/dom-fragment.js

@@ -54,8 +54,11 @@ class DomFragment {
       } else {
         result.references = key.references.filter(r => !key.identifiers.includes(r.identifier))
                                 .map(r => ({node: /** @type {EsLintNode} */ (r.identifier)}));
-        result.initializer = /** @type {EsLintNode} */ (key.identifiers[0]);
-        result.replacementLocation = result.initializer.parent;
+        const initializer = /** @type {EsLintNode} */ (key.identifiers[0]);
+        if (initializer?.parent?.type === 'VariableDeclarator') {
+          result.initializer = initializer;
+        }
+        result.replacementLocation = result.initializer?.parent;
         result.expression = key.name;
       }
     }

scripts/eslint_rules/tests/no-imperative-dom-api.test.js

@@ -406,10 +406,12 @@ class SomeWidget extends UI.Widget.Widget {
       filename: 'front_end/ui/components/component/file.ts',
       code: `
 class SomeWidget extends UI.Widget.Widget {
-  constructor(label: HTMLElement) {
+  constructor(label: HTMLElement, details: HTMLElement) {
     super();
     this.contentElement.appendChild(label);
     label.addEventListener('click', () => this.doSomething.bind(this));
+    this.contentElement.appendChild(details);
+    details.createChild('span');
   }
 }`,
       output: `
@@ -418,14 +420,16 @@ export const DEFAULT_VIEW = (input, _output, target) => {
   render(html\`
     <div>
       \${label}
+      \${details}
     </div>\`,
     target, {host: input});
 };
 
 class SomeWidget extends UI.Widget.Widget {
-  constructor(label: HTMLElement) {
+  constructor(label: HTMLElement, details: HTMLElement) {
     super();
     label.addEventListener('click', () => this.doSomething.bind(this));
+    details.createChild('span');
   }
 }`,
       errors: [{messageId: 'preferTemplateLiterals'}],