[eslint] Allow !! instead of Boolean

This provides better type inference when using TypeScript,
specifically the .filter methods
Also allowed by Google style guide.
https://google.github.io/styleguide/tsguide.html#type-coercion

Change-Id: I79745812f57670a0057145609b7949b2a12d9fbe
Bug:397260638
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403239
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>

Author: Lightning00Blade

eslint.config.mjs

@@ -205,7 +205,7 @@ export default [
       radix: 'error',
       'valid-typeof': 'error',
       'no-return-assign': ['error', 'always'],
-      'no-implicit-coercion': 'error',
+      'no-implicit-coercion': ['error', { allow: ['!!'] }],
 
       'no-array-constructor': 'error',
 

front_end/core/sdk/NetworkRequest.ts

@@ -1197,7 +1197,7 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
       ...this.responseCookies,
       ...this.blockedRequestCookies().map(blockedRequestCookie => blockedRequestCookie.cookie),
       ...this.blockedResponseCookies().map(blockedResponseCookie => blockedResponseCookie.cookie),
-    ].filter(v => Boolean(v)) as Cookie[];
+    ].filter(v => !!v);
   }
 
   get serverTimings(): ServerTiming[]|null {

front_end/models/ai_assistance/AiHistoryStorage.ts

@@ -199,7 +199,7 @@ export class AiHistoryStorage {
                                         }
                                         return undefined;
                                       })
-                                      .filter(item => Boolean(item));
+                                      .filter(item => !!item);
       this.#historySetting.set(
           history.filter(entry => entry.id !== id),
       );

front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.ts

@@ -146,7 +146,7 @@ Request initiator chain:\n${this.formatRequestInitiatorChain()}`;
       },
     ];
 
-    return labels.filter(label => Boolean(label.value)).map(label => `${label.label}: ${label.value}`).join('\n');
+    return labels.filter(label => !!label.value).map(label => `${label.label}: ${label.value}`).join('\n');
   }
 
   #formatRequestInitiated(

front_end/models/bindings/DebuggerWorkspaceBinding.ts

@@ -628,7 +628,7 @@ class StackTraceTopFrameLocation extends LiveLocationWithPool {
     const location = new StackTraceTopFrameLocation(updateDelegate, locationPool);
     const locationsPromises = rawLocations.map(
         rawLocation => binding.createLiveLocation(rawLocation, location.scheduleUpdate.bind(location), locationPool));
-    location.#locations = ((await Promise.all(locationsPromises)).filter(l => Boolean(l)) as Location[]);
+    location.#locations = ((await Promise.all(locationsPromises)).filter(l => !!l));
     await location.updateLocation();
     return location;
   }

front_end/models/bindings/NetworkProject.ts

@@ -178,6 +178,6 @@ export class NetworkProject {
       return [];
     }
     const frames = Array.from(attribution.keys()).map(frameId => resourceTreeModel.frameForId(frameId));
-    return frames.filter(frame => Boolean(frame)) as SDK.ResourceTreeModel.ResourceTreeFrame[];
+    return frames.filter(frame => !!frame);
   }
 }

front_end/models/live-metrics/LiveMetrics.ts

@@ -234,7 +234,7 @@ export class LiveMetrics extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
       this.#lcpValue?.nodeRef,
       ...this.#interactions.values().map(i => i.nodeRef),
       ...this.#layoutShifts.flatMap(shift => shift.affectedNodeRefs),
-    ].filter((nodeRef): nodeRef is NodeRef => Boolean(nodeRef));
+    ].filter(nodeRef => !!nodeRef);
 
     const idsToRefresh = new Set(toRefresh.map(nodeRef => nodeRef.node.backendNodeId()));
     const nodes = await domModel.pushNodesByBackendIdsToFrontend(idsToRefresh);
@@ -351,8 +351,7 @@ export class LiveMetrics extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
           return this.#resolveNodeRef(nodeIndex, executionContextId);
         });
 
-        const affectedNodes =
-            (await Promise.all(nodePromises)).filter((nodeRef): nodeRef is NodeRef => Boolean(nodeRef));
+        const affectedNodes = (await Promise.all(nodePromises)).filter(nodeRef => !!nodeRef);
 
         const layoutShift: LayoutShift = {
           score: webVitalsEvent.score,

front_end/models/persistence/Automapping.ts

@@ -344,7 +344,7 @@ export class Automapping {
       this.sourceCodeToMetadataMap.set(sourceCode, await sourceCode.requestMetadata());
     }));
 
-    const activeFiles = similarFiles.filter(file => Boolean(this.activeFoldersIndex.closestParentFolder(file.url())));
+    const activeFiles = similarFiles.filter(file => !!this.activeFoldersIndex.closestParentFolder(file.url()));
     const networkMetadata = this.sourceCodeToMetadataMap.get(networkSourceCode);
     if (!networkMetadata || (!networkMetadata.modificationTime && typeof networkMetadata.contentSize !== 'number')) {
       // If networkSourceCode does not have metadata, try to match against active folders.

front_end/models/persistence/IsolatedFileSystemManager.ts

@@ -150,7 +150,7 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
     }
 
     function onFileSystemsAdded(fileSystems: Array<IsolatedFileSystem|null>): void {
-      resolve(fileSystems.filter(fs => Boolean(fs)) as IsolatedFileSystem[]);
+      resolve(fileSystems.filter(fs => !!fs));
     }
   }
 

front_end/panels/console/ConsoleViewMessage.test.ts

@@ -255,7 +255,7 @@ describeWithMockConnection('ConsoleViewMessage', () => {
     }
 
     async function createConsoleMessageWithIgnoreListing(
-        ignoreListFn: (url: string) => Boolean, withBuiltinFrames?: boolean): Promise<HTMLElement> {
+        ignoreListFn: (url: string) => boolean, withBuiltinFrames?: boolean): Promise<HTMLElement> {
       const target = createTarget();
       const runtimeModel = target.model(SDK.RuntimeModel.RuntimeModel);
       const stackTrace = createStackTrace([