Record interactions with promoted reveal view commands in command menu

Bug: 434870886
Change-Id: Ic4532acded00ff290cfb6cf07ba996b173adea46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6811273
Commit-Queue: Benedikt Meurer <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Auto-Submit: Kateryna Prokopenko <[email protected]>

Author: Kateryna Prokopenko

front_end/entrypoints/main/MainImpl.ts

@@ -906,10 +906,16 @@ export class MainMenuItem implements UI.Toolbar.Provider {
 
     const aiPreregisteredView = UI.ViewManager.getRegisteredViewExtensionForID('freestyler');
     if (aiPreregisteredView) {
-      const additionalElement = UI.UIUtils.maybeCreateNewBadge('ai-asisstance');
+      let additionalElement = undefined;
+      const promotionId = aiPreregisteredView.featurePromotionId();
+      if (promotionId) {
+        additionalElement = UI.UIUtils.maybeCreateNewBadge(promotionId);
+      }
       contextMenu.defaultSection().appendItem(aiPreregisteredView.title(), () => {
         void UI.ViewManager.ViewManager.instance().showView('freestyler', true, false);
-        UI.UIUtils.PromotionManager.instance().recordFeatureInteraction('ai-asisstance');
+        if (promotionId) {
+          UI.UIUtils.PromotionManager.instance().recordFeatureInteraction(promotionId);
+        }
       }, {additionalElement, jslogContext: 'freestyler'});
     }
 

front_end/ui/legacy/components/quick_open/CommandMenu.ts

@@ -82,6 +82,7 @@ export class CommandMenu {
       handler = () => {
         Host.userMetrics.actionTaken(actionCode);
         executeHandler();
+        // not here
       };
     }
     return new Command(
@@ -173,6 +174,9 @@ export class CommandMenu {
       if (id === 'issues-pane') {
         Host.userMetrics.issuesPanelOpenedFrom(Host.UserMetrics.IssueOpener.COMMAND_MENU);
       }
+      if (featurePromotionId) {
+        UI.UIUtils.PromotionManager.instance().recordFeatureInteraction(featurePromotionId);
+      }
       return UI.ViewManager.ViewManager.instance().showView(id, /* userGesture */ true);
     };
 
@@ -345,7 +349,7 @@ export class CommandMenuProvider extends Provider {
     FilteredListWidget.highlightRanges(titleElement, query, true);
 
     if (command.featurePromotionId) {
-      const badge = UI.UIUtils.maybeCreateNewBadge('ai-asisstance');
+      const badge = UI.UIUtils.maybeCreateNewBadge(command.featurePromotionId);
       if (badge) {
         titleElement.parentElement?.insertBefore(badge, subtitleElement);
       }