[RPP] Set title on individual options in throttling SelectMenus

Fixed: 383465162
Change-Id: I378e69825fbbdafecd320acc8e035029f3860067
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6089366
Commit-Queue: Adam Raine <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
Reviewed-by: Adam Raine <[email protected]>

Author: Connor Clark

front_end/panels/timeline/components/CPUThrottlingSelector.ts

@@ -114,7 +114,7 @@ export class CPUThrottlingSelector extends HTMLElement {
             .showConnector=${false}
             .jslogContext=${'cpu-throttling'}
             .buttonTitle=${i18nString(UIStrings.cpu, {PH1: selectionTitle})}
-            title=${i18nString(UIStrings.cpuThrottling, {PH1: selectionTitle})}
+            .title=${i18nString(UIStrings.cpuThrottling, {PH1: selectionTitle})}
           >
           ${MobileThrottling.ThrottlingPresets.ThrottlingPresets.cpuThrottlingPresets.map(rate => {
             let title = rate === 1 ? i18nString(UIStrings.noThrottling) : i18nString(UIStrings.dSlowdown, {PH1: rate});
@@ -127,6 +127,7 @@ export class CPUThrottlingSelector extends HTMLElement {
               <devtools-menu-item
                 .value=${rate}
                 .selected=${this.#currentRate === rate}
+                .title=${title}
                 jslog=${VisualLogging.item(jslogContext).track({click: true})}
               >
                 ${title}

front_end/panels/timeline/components/NetworkThrottlingSelector.ts

@@ -191,11 +191,11 @@ export class NetworkThrottlingSelector extends HTMLElement {
         .showConnector=${false}
         .jslogContext=${'network-conditions'}
         .buttonTitle=${i18nString(UIStrings.network, {PH1: selectionTitle})}
-        title=${i18nString(UIStrings.networkThrottling, {PH1: selectionTitle})}
+        .title=${i18nString(UIStrings.networkThrottling, {PH1: selectionTitle})}
       >
         ${this.#groups.map(group => {
           return html`
-            <devtools-menu-group .name=${group.name}>
+            <devtools-menu-group .name=${group.name} .title=${group.name}>
               ${group.items.map(conditions => {
                 let title = this.#getConditionsTitle(conditions);
                 if (conditions === this.#recommendedConditions) {
@@ -208,6 +208,7 @@ export class NetworkThrottlingSelector extends HTMLElement {
                   <devtools-menu-item
                     .value=${key}
                     .selected=${selectedConditionsKey === key}
+                    .title=${title}
                     jslog=${VisualLogging.item(jslogContext).track({click: true})}
                   >
                     ${title}
@@ -217,6 +218,7 @@ export class NetworkThrottlingSelector extends HTMLElement {
               ${group.showCustomAddOption ? html`
                 <devtools-menu-item
                   .value=${1 /* This won't be displayed unless it has some value. */}
+                  .title=${i18nString(UIStrings.add)}
                   jslog=${VisualLogging.action('add').track({click: true})}
                   @click=${this.#onAddClick}
                 >