ESLint: lint *.d.ts files

Bug: none
Change-Id: Ie91dbdc6ed1533c2c58cdb2eafa6d5f23632d243
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6311457
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>

Author: jackfranklin

config/typescript/tsconfig.eslint.json

@@ -13,7 +13,7 @@
   "include": [
     "../../front_end/**/*.ts",
     "../../inspector_overlay/**/*.ts",
-    "../../scripts/protocol_typescript/*.ts",
+    "../../scripts/**/*.ts",
     "../../test/**/*.ts",
     "../../extensions/**/*.ts",
   ]

eslint.config.mjs

@@ -13,13 +13,13 @@ import jsdocPlugin from 'eslint-plugin-jsdoc';
 import mochaPlugin from 'eslint-plugin-mocha';
 import rulesdirPlugin from 'eslint-plugin-rulesdir';
 import globals from 'globals';
-import { join } from 'path';
+import {join} from 'path';
 
 rulesdirPlugin.RULES_DIR = join(
-  import.meta.dirname,
-  'scripts',
-  'eslint_rules',
-  'lib',
+    import.meta.dirname,
+    'scripts',
+    'eslint_rules',
+    'lib',
 );
 
 /**
@@ -74,7 +74,6 @@ export default [
       'test/**/fixtures/',
       'test/e2e/**/*.js',
       'test/shared/**/*.js',
-      '**/*.d.ts',
     ],
   },
   {
@@ -317,11 +316,11 @@ export default [
       parserOptions: {
         allowAutomaticSingleRunInference: true,
         project: join(
-          import.meta.dirname,
-          'config',
-          'typescript',
-          'tsconfig.eslint.json',
-        ),
+            import.meta.dirname,
+            'config',
+            'typescript',
+            'tsconfig.eslint.json',
+            ),
       },
     },
 
@@ -549,12 +548,12 @@ export default [
         {
           // Enforce that any import of models/trace/trace.js names the import Trace.
           modulePath: join(
-            import.meta.dirname,
-            'front_end',
-            'models',
-            'trace',
-            'trace.js',
-          ),
+              import.meta.dirname,
+              'front_end',
+              'models',
+              'trace',
+              'trace.js',
+              ),
           importName: 'Trace',
         },
       ],
@@ -820,4 +819,13 @@ export default [
       'rulesdir/canvas-context-tracking': 'error',
     },
   },
+  {
+    name: 'TypeScript type-definitions',
+    files: ['**/*.d.ts'],
+    rules: {
+      // Not a useful rule for .d.ts files where we are
+      // representing an existing module.
+      'import/no-default-export': 'off'
+    }
+  }
 ];

extensions/cxx_debugging/src/SymbolsBackend.d.ts

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+/* eslint-disable @typescript-eslint/naming-convention */
+
 export interface EmbindObject {
   new(): this;
   delete(): void;
@@ -152,12 +154,12 @@ export interface Module extends EmscriptenModule {
   FieldInfoArray: Vector<FieldInfo>;
   EnumeratorArray: Vector<Enumerator>;
   ErrorCode:
-      {INTERNAL_ERROR: ErrorCode; PROTOCOL_ERROR: ErrorCode; MODULE_NOT_FOUND_ERROR: ErrorCode; EVAL_ERROR: ErrorCode;};
+      {INTERNAL_ERROR: ErrorCode, PROTOCOL_ERROR: ErrorCode, MODULE_NOT_FOUND_ERROR: ErrorCode, EVAL_ERROR: ErrorCode};
   Error: Error;
   RawLocationRange: RawLocationRange;
   RawLocation: RawLocation;
   SourceLocation: SourceLocation;
-  VariableScope: {LOCAL: VariableScope; PARAMETER: VariableScope; GLOBAL: VariableScope;};
+  VariableScope: {LOCAL: VariableScope, PARAMETER: VariableScope, GLOBAL: VariableScope};
   Variable: Variable;
   FieldInfo: FieldInfo;
   Enumerator: Enumerator;
@@ -173,5 +175,5 @@ export interface Module extends EmscriptenModule {
   EvaluateExpressionResponse: EvaluateExpressionResponse;
 }
 
-declare var createSymbolsBackend: EmscriptenModuleFactory<Module>;
+declare let createSymbolsBackend: EmscriptenModuleFactory<Module>;
 export default createSymbolsBackend;

extensions/cxx_debugging/tests/LLDBEvalTests.d.ts

@@ -1,7 +1,7 @@
 // Copyright 2023 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-import {type Vector} from '../src/SymbolsBackend.js';
+import type {Vector} from '../src/SymbolsBackend.js';
 
 export interface Debugger {
   runToLine(line: string): Promise<void>;
@@ -15,9 +15,10 @@ export interface EvalResult {
 }
 
 interface Module extends EmscriptenModule {
+  // eslint-disable-next-line @typescript-eslint/naming-convention
   StringArray: Vector<string>;
   runTests(dbg: Debugger, args: Vector<string>): Promise<number>;
 }
 
-declare var loadModule: EmscriptenModuleFactory<Module>;
+declare let loadModule: EmscriptenModuleFactory<Module>;
 export default loadModule;

extensions/cxx_debugging/tests/SymbolsBackendTests.d.ts

@@ -3,9 +3,10 @@
 // found in the LICENSE file.
 
 export interface SymbolsBackendTestsModule extends EmscriptenModule {
+  // eslint-disable-next-line @typescript-eslint/naming-convention
   FS: typeof FS;
   callMain(args?: string[]): void;
 }
 
-declare var createModule: EmscriptenModuleFactory<SymbolsBackendTestsModule>;
+declare let createModule: EmscriptenModuleFactory<SymbolsBackendTestsModule>;
 export default createModule;

front_end/legacy/legacy-defs.d.ts

@@ -90,10 +90,10 @@ interface Node {
   isSelfOrDescendant(node: Node|null): boolean;
   parentElementOrShadowHost(): Element|null;
   parentNodeOrShadowHost(): Node|null;
-  setTextContentTruncatedIfNeeded(text: any, placeholder?: string): boolean;
+  setTextContentTruncatedIfNeeded(text: unknown, placeholder?: string): boolean;
   traverseNextNode(stayWithin?: Node): Node|null;
   traversePreviousNode(stayWithin?: Node): Node|null;
-  deepTextContent(): string
+  deepTextContent(): string;
   window(): Window;
   childTextNodes(): Node[];
 }

scripts/ai_assistance/types.d.ts

@@ -1,4 +1,8 @@
-import {AidaRequest} from '../../front_end/core/host/AidaClient.ts'
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import type {AidaRequest} from '../../front_end/core/host/AidaClient.ts';
 
 /**
  * Some types used in auto-run.js. They only exist here because it's
@@ -10,7 +14,7 @@ import {AidaRequest} from '../../front_end/core/host/AidaClient.ts'
  */
 export interface RunResult {
   allExampleResults: IndividualPromptRequestResponse[];
-  metadata: ExampleMetadata[]
+  metadata: ExampleMetadata[];
 }
 
 /**
@@ -49,7 +53,7 @@ export interface YargsInput {
 // Clang cannot handle the Record<> syntax over multiple lines, it seems.
 /* clang-format off */
 export type Logs = Record<string, {
-  index: number;
-  text: string;
+  index: number,
+  text: string,
 }> ;
 /* clang-format on */

scripts/javascript_natives/test.d.ts

@@ -1,3 +1,7 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
 interface Array<T> {
   at(index: number): T|undefined;
   diffSig(oneSig: number): T|undefined;

scripts/protocol_typescript/protocol_schema.d.ts

@@ -82,10 +82,10 @@ export module Protocol {
 
   type DomainType = {
     /** Name of property */
-    id: string;
+    id: string,
     /** Description of the type */
-    description?: string;
-  }&(StringType|ObjectType|ArrayType|PrimitiveType)
+    description?: string,
+  }&(StringType|ObjectType|ArrayType|PrimitiveType);
 
   type ProtocolType = StringType|ObjectType|ArrayType|PrimitiveType|RefType|AnyType;
   type PropertyType = PropertyBaseType&ProtocolType;

test/e2e_non_hosted/types.d.ts

@@ -1,10 +1,12 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
 import type {Platform} from '../conductor/platform.js';
 
 import type {BrowserSettings, BrowserWrapper} from './shared/browser-helper.js';
 import type {DevToolsFronendPage, DevtoolsSettings} from './shared/frontend-helper.js';
 import type {InspectedPage} from './shared/target-helper.js';
 
-
 declare global {
   namespace Mocha {
     export interface TestFunction {