Skip to content

Commit c2d3683

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
Let EsLint handle excluded files in PRESUBMIT
We were excluding files from linting in PRESUBMIT, the issue is that code path got omitted if we had more than 50 files changed. We should let EsLint config dictate what files are linted and what are not. That ensures that we always have the same behaviour. Bug: none Change-Id: I5baa97f887980683cfec8c2be27dd5adfcd00ab2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7117821 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]> Auto-Submit: Nikolay Vitkov <[email protected]>
1 parent a83225f commit c2d3683

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

PRESUBMIT.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
r'^scripts[\\/]build[\\/]build_inspector_overlay\.py$', # Lines too long
4141
r'^scripts[\\/]build[\\/]code_generator_frontend\.py$',
4242
r'^scripts[\\/]deps[\\/]manage_node_deps\.py$', # Lines too long
43-
r'front_end[\\/]generated[\\/]ARIAProperties\.ts$' # Auto-generated files
4443
# Auto-generated files
4544
r'front_end[\\/]generated[\\/]InspectorBackendCommands\.ts$'
4645
]
@@ -147,13 +146,6 @@ def _GetFilesToLint(input_api, lint_config_files, default_linted_directories,
147146
default_linted_directories, ['D'],
148147
accepted_endings)
149148

150-
# Exclude front_end/third_party and front_end/generated files.
151-
files_to_lint = [
152-
file for file in files_to_lint
153-
if "front_end/third_party" not in file
154-
and "front_end/generated" not in file
155-
]
156-
157149
should_bail_out = len(files_to_lint) == 0 and not run_full_check
158150
return should_bail_out, files_to_lint
159151

0 commit comments

Comments
 (0)