Skip to content

Commit c3e8886

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
authored andcommitted
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8721453514274660161 [email protected] Bug: none Change-Id: I83a72f53dc4dd181890435ff907fbaa54203211d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6316009 Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Simon Zünd <[email protected]>
1 parent 01b69d8 commit c3e8886

File tree

15 files changed

+215
-69
lines changed

15 files changed

+215
-69
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '940abfc668be2591483f7132145593c6a047f3cf',
2525

2626
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : '935ce46c51ff9b569f2528306475d1773d6a142e',
27+
'chromium_browser_protocol_revision' : '3bfd91fefada895716a256a646d5dbe83e763057',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

front_end/core/sdk/ResourceTreeModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
7676
}
7777
this.agent = target.pageAgent();
7878
this.storageAgent = target.storageAgent();
79-
void this.agent.invoke_enable();
79+
void this.agent.invoke_enable({});
8080
this.#securityOriginManager = (target.model(SecurityOriginManager) as SecurityOriginManager);
8181
this.#storageKeyManager = (target.model(StorageKeyManager) as StorageKeyManager);
8282
this.#pendingBackForwardCacheNotUsedEvents = new Set<Protocol.Page.BackForwardCacheNotUsedEvent>();

front_end/generated/Deprecation.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@ export const UIStrings = {
8686
* @description This is a deprecated warning to developers that a field in a structure has been renamed.
8787
*/
8888
InterestGroupDailyUpdateUrl: "The `dailyUpdateUrl` field of `InterestGroups` passed to `joinAdInterestGroup()` has been renamed to `updateUrl`, to more accurately reflect its behavior.",
89+
/**
90+
* @description Warning displayed to developers that instead of calling the `Intl.v8BreakIterator` constructor, which is not a standard JavaScript API, use ECMA402 standard API Intl.Segmenter shipped in end of 2020 instead.
91+
*/
92+
IntlV8BreakIterator: "`Intl.v8BreakIterator` is deprecated. Please use `Intl.Segmenter` instead.",
8993
/**
9094
* @description This warning occurs when a stylesheet loaded from a local file directive does not end in the file type `.css`.
9195
*/
@@ -113,7 +117,7 @@ export const UIStrings = {
113117
/**
114118
* @description Warning displayed to developers when CreateImageBitmap is used with the newly deprecated option imageOrientation: 'none'.
115119
*/
116-
ObsoleteCreateImageBitmapImageOrientationNone: "Option `imageOrientation: 'none'` in createImageBitmap is deprecated. Please use createImageBitmap with option {imageOrientation: 'from-image'} instead.",
120+
ObsoleteCreateImageBitmapImageOrientationNone: "Option `imageOrientation: 'none'` in createImageBitmap is deprecated. Please use createImageBitmap with option '{imageOrientation: 'from-image'}' instead.",
117121
/**
118122
* @description This warning occurs when the WebRTC protocol attempts to negotiate a connection using an obsolete cipher and risks connection security.
119123
*/
@@ -230,10 +234,6 @@ export const UIStrings = {
230234
* @description Warning displayed to developers. It is shown when the `XMLHttpRequest` API is used in a way that it slows down the page load of the next page. The `main thread` refers to an operating systems thread used to run most of the processing of HTML documents, so please use a consistent wording.
231235
*/
232236
XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload: "Synchronous `XMLHttpRequest` on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.",
233-
/**
234-
* @description Warning displayed to developers that instead of using `supportsSession()`, which returns a promise that resolves if the XR session can be supported and rejects if not, they should use `isSessionSupported()` which will return a promise which resolves to a boolean indicating if the XR session can be supported or not, but may reject to throw an exception.
235-
*/
236-
XRSupportsSession: "`supportsSession()` is deprecated. Please use `isSessionSupported()` and check the resolved boolean value instead.",
237237
} as const;
238238

239239
export interface DeprecationDescriptor {
@@ -359,8 +359,5 @@ export const DEPRECATIONS_METADATA: Partial<Record<string, DeprecationDescriptor
359359
},
360360
"XHRJSONEncodingDetection": {
361361
"milestone": 93
362-
},
363-
"XRSupportsSession": {
364-
"milestone": 80
365362
}
366363
};

front_end/generated/InspectorBackendCommands.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

front_end/generated/SupportedCSSProperties.js

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,7 @@ export const generatedProperties = [
494494
"font-variation-settings",
495495
"font-weight",
496496
"forced-color-adjust",
497+
"gap-rule-paint-order",
497498
"grid-auto-columns",
498499
"grid-auto-flow",
499500
"grid-auto-rows",
@@ -639,6 +640,8 @@ export const generatedProperties = [
639640
"row-gap",
640641
"row-rule-break",
641642
"row-rule-outset",
643+
"row-rule-style",
644+
"row-rule-width",
642645
"ruby-align",
643646
"ruby-position",
644647
"rx",
@@ -654,6 +657,7 @@ export const generatedProperties = [
654657
"scroll-margin-left",
655658
"scroll-margin-right",
656659
"scroll-margin-top",
660+
"scroll-marker-contain",
657661
"scroll-marker-group",
658662
"scroll-padding-block-end",
659663
"scroll-padding-block-start",
@@ -2410,6 +2414,14 @@ export const generatedProperties = [
24102414
],
24112415
"name": "gap"
24122416
},
2417+
{
2418+
"inherited": false,
2419+
"keywords": [
2420+
"row-over-column",
2421+
"column-over-row"
2422+
],
2423+
"name": "gap-rule-paint-order"
2424+
},
24132425
{
24142426
"longhands": [
24152427
"grid-template-rows",
@@ -3531,6 +3543,29 @@ export const generatedProperties = [
35313543
"inherited": false,
35323544
"name": "row-rule-outset"
35333545
},
3546+
{
3547+
"keywords": [
3548+
"none",
3549+
"hidden",
3550+
"inset",
3551+
"groove",
3552+
"outset",
3553+
"ridge",
3554+
"dotted",
3555+
"dashed",
3556+
"solid",
3557+
"double"
3558+
],
3559+
"name": "row-rule-style"
3560+
},
3561+
{
3562+
"keywords": [
3563+
"thin",
3564+
"medium",
3565+
"thick"
3566+
],
3567+
"name": "row-rule-width"
3568+
},
35343569
{
35353570
"inherited": true,
35363571
"keywords": [
@@ -3625,6 +3660,13 @@ export const generatedProperties = [
36253660
{
36263661
"name": "scroll-margin-top"
36273662
},
3663+
{
3664+
"keywords": [
3665+
"none",
3666+
"auto"
3667+
],
3668+
"name": "scroll-marker-contain"
3669+
},
36283670
{
36293671
"keywords": [
36303672
"none",
@@ -5499,6 +5541,12 @@ export const generatedPropertyValues = {
54995541
"preserve-parent-color"
55005542
]
55015543
},
5544+
"gap-rule-paint-order": {
5545+
"values": [
5546+
"row-over-column",
5547+
"column-over-row"
5548+
]
5549+
},
55025550
"grid-auto-columns": {
55035551
"values": [
55045552
"auto",
@@ -6082,6 +6130,27 @@ export const generatedPropertyValues = {
60826130
"intersection"
60836131
]
60846132
},
6133+
"row-rule-style": {
6134+
"values": [
6135+
"none",
6136+
"hidden",
6137+
"inset",
6138+
"groove",
6139+
"outset",
6140+
"ridge",
6141+
"dotted",
6142+
"dashed",
6143+
"solid",
6144+
"double"
6145+
]
6146+
},
6147+
"row-rule-width": {
6148+
"values": [
6149+
"thin",
6150+
"medium",
6151+
"thick"
6152+
]
6153+
},
60856154
"ruby-align": {
60866155
"values": [
60876156
"space-around",
@@ -6118,6 +6187,12 @@ export const generatedPropertyValues = {
61186187
"nearest"
61196188
]
61206189
},
6190+
"scroll-marker-contain": {
6191+
"values": [
6192+
"none",
6193+
"auto"
6194+
]
6195+
},
61216196
"scroll-marker-group": {
61226197
"values": [
61236198
"none",

front_end/generated/protocol-mapping.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3321,7 +3321,7 @@ export namespace ProtocolMapping {
33213321
* Enables page domain notifications.
33223322
*/
33233323
'Page.enable': {
3324-
paramsType: [];
3324+
paramsType: [Protocol.Page.EnableRequest?];
33253325
returnType: void;
33263326
};
33273327
/**

front_end/generated/protocol-proxy-api.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2618,7 +2618,7 @@ declare namespace ProtocolProxyApi {
26182618
/**
26192619
* Enables page domain notifications.
26202620
*/
2621-
invoke_enable(): Promise<Protocol.ProtocolResponseWithError>;
2621+
invoke_enable(params: Protocol.Page.EnableRequest): Promise<Protocol.ProtocolResponseWithError>;
26222622

26232623
/**
26242624
* Gets the processed manifest for this current document.

front_end/generated/protocol.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11758,7 +11758,7 @@ export namespace Page {
1175811758

1175911759
/**
1176011760
* All Permissions Policy features. This enum should match the one defined
11761-
* in third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5.
11761+
* in services/network/public/cpp/permissions_policy/permissions_policy_features.json5.
1176211762
*/
1176311763
export const enum PermissionsPolicyFeature {
1176411764
Accelerometer = 'accelerometer',
@@ -12724,6 +12724,7 @@ export namespace Page {
1272412724
EmbedderExtensionSentMessageToCachedFrame = 'EmbedderExtensionSentMessageToCachedFrame',
1272512725
RequestedByWebViewClient = 'RequestedByWebViewClient',
1272612726
PostMessageByWebViewClient = 'PostMessageByWebViewClient',
12727+
CacheControlNoStoreDeviceBoundSessionTerminated = 'CacheControlNoStoreDeviceBoundSessionTerminated',
1272712728
}
1272812729

1272912730
/**
@@ -12917,6 +12918,14 @@ export namespace Page {
1291712918
url: string;
1291812919
}
1291912920

12921+
export interface EnableRequest {
12922+
/**
12923+
* If true, the `Page.fileChooserOpened` event will be emitted regardless of the state set by
12924+
* `Page.setInterceptFileChooserDialog` command (default: false).
12925+
*/
12926+
enableFileChooserOpenedEvent?: boolean;
12927+
}
12928+
1292012929
export interface GetAppManifestRequest {
1292112930
manifestId?: string;
1292212931
}

front_end/models/javascript_metadata/NativeFunctions.js

Lines changed: 25 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1255,6 +1255,11 @@ export const NativeFunctions = [
12551255
signatures: [["?output"],["destinationNode","?output","?input"],["destinationParam","?output"],["destination","?output","?input"]],
12561256
receivers: ["AudioNode"]
12571257
},
1258+
{
1259+
name: "disconnect",
1260+
signatures: [["options"]],
1261+
receivers: ["IdentityCredential"]
1262+
},
12581263
{
12591264
name: "disconnect",
12601265
signatures: [["?disposition"]],
@@ -1944,11 +1949,6 @@ export const NativeFunctions = [
19441949
signatures: [["?tx","?ty","?tz"]],
19451950
receivers: ["DOMMatrixReadOnly"]
19461951
},
1947-
{
1948-
name: "translate",
1949-
signatures: [["input"]],
1950-
receivers: ["LanguageTranslator"]
1951-
},
19521952
{
19531953
name: "drawFocusIfNeeded",
19541954
signatures: [["element"],["path","element"]]
@@ -5657,7 +5657,13 @@ export const NativeFunctions = [
56575657
},
56585658
{
56595659
name: "finally",
5660-
signatures: [["?onfinally"]]
5660+
signatures: [["?onfinally"]],
5661+
receivers: ["Promise"]
5662+
},
5663+
{
5664+
name: "finally",
5665+
signatures: [["callback"]],
5666+
receivers: ["Observable"]
56615667
},
56625668
{
56635669
name: "fromEntries",
@@ -7071,7 +7077,7 @@ export const NativeFunctions = [
70717077
},
70727078
{
70737079
name: "setValueAndClosePopup",
7074-
signatures: [["numberValue","stringValue","?is_keyboard_event"]]
7080+
signatures: [["numberValue","stringValue","is_keyboard_event"]]
70757081
},
70767082
{
70777083
name: "setValue",
@@ -7295,7 +7301,13 @@ export const NativeFunctions = [
72957301
},
72967302
{
72977303
name: "availability",
7298-
signatures: [["?options"]]
7304+
signatures: [["?options"]],
7305+
receivers: ["AIRewriterFactory","AISummarizerFactory","AIWriterFactory"]
7306+
},
7307+
{
7308+
name: "availability",
7309+
signatures: [["options"]],
7310+
receivers: ["AITranslatorFactory"]
72997311
},
73007312
{
73017313
name: "createOptionsAvailable",
@@ -7458,6 +7470,10 @@ export const NativeFunctions = [
74587470
name: "fillTextCluster",
74597471
signatures: [["textCluster","x","y","?options"]]
74607472
},
7473+
{
7474+
name: "strokeTextCluster",
7475+
signatures: [["textCluster","x","y","?options"]]
7476+
},
74617477
{
74627478
name: "transferToGPUTexture",
74637479
signatures: [["options"]]
@@ -8186,14 +8202,6 @@ export const NativeFunctions = [
81868202
name: "TimestampTrigger",
81878203
signatures: [["timestamp"]]
81888204
},
8189-
{
8190-
name: "canTranslate",
8191-
signatures: [["options"]]
8192-
},
8193-
{
8194-
name: "createTranslator",
8195-
signatures: [["options"]]
8196-
},
81978205
{
81988206
name: "AbortPaymentEvent",
81998207
signatures: [["type","eventInitDict"]]
@@ -8580,7 +8588,7 @@ export const NativeFunctions = [
85808588
},
85818589
{
85828590
name: "install",
8583-
signatures: [["?manifest_id","?install_url"]]
8591+
signatures: [["?install_url","?manifest_id"]]
85848592
},
85858593
{
85868594
name: "AnalyserNode",
@@ -9182,18 +9190,6 @@ export const NativeFunctions = [
91829190
name: "WindowControlsOverlayGeometryChangeEvent",
91839191
signatures: [["type","eventInitDict"]]
91849192
},
9185-
{
9186-
name: "XRGPUBinding",
9187-
signatures: [["session","device"]]
9188-
},
9189-
{
9190-
name: "createProjectionLayer",
9191-
signatures: [["init"]]
9192-
},
9193-
{
9194-
name: "getViewSubImage",
9195-
signatures: [["layer","view"]]
9196-
},
91979193
{
91989194
name: "getPose",
91999195
signatures: [["relative_to"]]
@@ -9226,10 +9222,6 @@ export const NativeFunctions = [
92269222
name: "XRSessionEvent",
92279223
signatures: [["type","eventInitDict"]]
92289224
},
9229-
{
9230-
name: "supportsSession",
9231-
signatures: [["mode"]]
9232-
},
92339225
{
92349226
name: "isSessionSupported",
92359227
signatures: [["mode"]]

front_end/panels/application/components/BackForwardCacheStrings.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -703,4 +703,6 @@ export const NotRestoredReasonDescription = {
703703
WebViewMessageListenerInjected: {name: i18n.i18n.lockedLazyString('WebViewMessageListenerInjected')},
704704
WebViewSafeBrowsingAllowlistChanged: {name: i18n.i18n.lockedLazyString('WebViewSafeBrowsingAllowlistChanged')},
705705
WebViewDocumentStartJavascriptChanged: {name: i18n.i18n.lockedLazyString('WebViewDocumentStartJavascriptChanged')},
706+
CacheControlNoStoreDeviceBoundSessionTerminated:
707+
{name: i18n.i18n.lockedLazyString('CacheControlNoStoreDeviceBoundSessionTerminated')},
706708
};

0 commit comments

Comments
 (0)