Skip to content

Commit c406636

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
[eslint] Extract runner into a util file
Also fixes the running of the test locally Bug: none Change-Id: Icbed012aeee6bddf5eebcffda9703693191ab4bc Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6235032 Commit-Queue: Nikolay Vitkov <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Auto-Submit: Nikolay Vitkov <[email protected]>
1 parent 9a644f2 commit c406636

File tree

53 files changed

+123
-442
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+123
-442
lines changed

scripts/eslint_rules/tests/canvas-context-tracking.test.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,8 @@
33
// found in the LICENSE file.
44

55
const rule = require('../lib/canvas-context-tracking.js');
6-
const ruleTester = new (require('eslint').RuleTester)({
7-
languageOptions: {
8-
ecmaVersion: 'latest',
9-
sourceType: 'module',
10-
},
11-
});
6+
7+
const {ruleTester} = require('./utils/utils.js');
128

139
ruleTester.run('canvas-context-tracking-test', rule, {
1410
valid: [

scripts/eslint_rules/tests/check-css-import.test.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,8 @@
44
'use strict';
55

66
const rule = require('../lib/check-css-import.js');
7-
const ruleTester = new (require('eslint').RuleTester)({
8-
languageOptions: {
9-
ecmaVersion: 'latest',
10-
sourceType: 'module',
11-
},
12-
});
7+
8+
const {ruleTester} = require('./utils/utils.js');
139

1410
ruleTester.run('check-css-import', rule, {
1511
valid: [

scripts/eslint_rules/tests/check-enumerated-histograms.test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,9 @@
33
// found in the LICENSE file.
44
'use strict';
55

6-
const tsParser = require('@typescript-eslint/parser');
7-
86
const rule = require('../lib/check-enumerated-histograms.js');
9-
const ruleTester = new (require('eslint').RuleTester)({
10-
languageOptions: {
11-
ecmaVersion: 'latest',
12-
sourceType: 'module',
13-
parser: tsParser,
14-
},
15-
});
7+
8+
const {ruleTester} = require('./utils/utils.js');
169

1710
ruleTester.run('check-enumerated-histograms', rule, {
1811
valid: [

scripts/eslint_rules/tests/check-license-header.test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,9 @@
33
// found in the LICENSE file.
44
'use strict';
55

6-
const tsParser = require('@typescript-eslint/parser');
7-
86
const rule = require('../lib/check-license-header.js');
9-
const ruleTester = new (require('eslint').RuleTester)({
10-
languageOptions: {
11-
ecmaVersion: 'latest',
12-
sourceType: 'module',
13-
parser: tsParser,
14-
},
15-
});
7+
8+
const {ruleTester} = require('./utils/utils.js');
169

1710
const CURRENT_YEAR = new Date().getFullYear();
1811

scripts/eslint_rules/tests/check-test-definitions.test.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,8 @@
44
'use strict';
55

66
const rule = require('../lib/check-test-definitions.js');
7-
const ruleTester = new (require('eslint').RuleTester)({
8-
languageOptions: {
9-
ecmaVersion: 'latest',
10-
sourceType: 'module',
11-
},
12-
});
7+
8+
const {ruleTester} = require('./utils/utils.js');
139

1410
ruleTester.run('check-test-definitions', rule, {
1511
valid: [

scripts/eslint_rules/tests/check-was-shown-methods.test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,9 @@
33
// found in the LICENSE file.
44
'use strict';
55

6-
const tsParser = require('@typescript-eslint/parser');
7-
86
const rule = require('../lib/check-was-shown-methods.js');
9-
const ruleTester = new (require('eslint').RuleTester)({
10-
languageOptions: {
11-
ecmaVersion: 'latest',
12-
sourceType: 'module',
13-
parser: tsParser,
14-
},
15-
});
7+
8+
const {ruleTester} = require('./utils/utils.js');
169

1710
const EXPECTED_ERROR_MESSAGE = 'Please make sure the first call in wasShown is to super.wasShown().';
1811

scripts/eslint_rules/tests/enforce-bound-render-for-schedule-render.test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,9 @@
33
// found in the LICENSE file.
44
'use strict';
55

6-
const tsParser = require('@typescript-eslint/parser');
7-
86
const rule = require('../lib/enforce-bound-render-for-schedule-render.js');
9-
const ruleTester = new (require('eslint').RuleTester)({
10-
languageOptions: {
11-
ecmaVersion: 'latest',
12-
sourceType: 'module',
13-
parser: tsParser,
14-
},
15-
});
7+
8+
const {ruleTester} = require('./utils/utils.js');
169

1710
ruleTester.run('enforce-bound-render-for-schedule-render', rule, {
1811
valid: [

scripts/eslint_rules/tests/enforce-custom-event-names.test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,9 @@
33
// found in the LICENSE file.
44
'use strict';
55

6-
const tsParser = require('@typescript-eslint/parser');
7-
86
const rule = require('../lib/enforce-custom-event-names.js');
9-
const ruleTester = new (require('eslint').RuleTester)({
10-
languageOptions: {
11-
ecmaVersion: 'latest',
12-
sourceType: 'module',
13-
parser: tsParser,
14-
},
15-
});
7+
8+
const {ruleTester} = require('./utils/utils.js');
169

1710
ruleTester.run('enforce-custom-event-names', rule, {
1811
valid: [

scripts/eslint_rules/tests/enforce-default-import-name.test.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,11 @@
33
// found in the LICENSE file.
44
'use strict';
55

6-
const tsParser = require('@typescript-eslint/parser');
76
const path = require('path');
87

98
const rule = require('../lib/enforce-default-import-name.js');
10-
const ruleTester = new (require('eslint').RuleTester)({
11-
languageOptions: {
12-
ecmaVersion: 'latest',
13-
sourceType: 'module',
14-
parser: tsParser,
15-
},
16-
});
9+
10+
const {ruleTester} = require('./utils/utils.js');
1711

1812
const TEST_OPTIONS = [
1913
{

scripts/eslint_rules/tests/enforce-optional-properties-last.test.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,9 @@
33
// found in the LICENSE file.
44
'use strict';
55

6-
const tsParser = require('@typescript-eslint/parser');
7-
86
const rule = require('../lib/enforce-optional-properties-last.js');
9-
const ruleTester = new (require('eslint').RuleTester)({
10-
languageOptions: {
11-
ecmaVersion: 'latest',
12-
sourceType: 'module',
13-
parser: tsParser,
14-
},
15-
});
167

8+
const {ruleTester} = require('./utils/utils.js');
179
ruleTester.run('optional-properties-last', rule, {
1810
valid: [
1911
{

0 commit comments

Comments
 (0)