Insights: add interaction + screenshot test

Bug: 373355645
Change-Id: I7bdaf63cc6d33341ad2781b5ec9a8792466350aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5928967
Auto-Submit: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Alina Varkki <[email protected]>

Author: jackfranklin

front_end/panels/timeline/TimelinePanel.ts

@@ -279,9 +279,9 @@ const UIStrings = {
    */
   showSidebar: 'Show sidebar',
   /**
-   * @description Tooltip for the the sole sidebar toggle in the Performance panel. Command to close the sidebar.
+   * @description Tooltip for the the sidebar toggle in the Performance panel. Command to close the sidebar.
    */
-  hideSidebar: 'Hide sole sidebar',
+  hideSidebar: 'Hide sidebar',
   /**
    * @description Screen reader announcement when the sidebar is shown in the Performance panel.
    */
@@ -1831,6 +1831,10 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
    * We also check that the experiments are enabled, else we reveal an entirely empty sidebar.
    */
   #showSidebarIfRequired(): void {
+    if (Root.Runtime.Runtime.queryParam('disable-auto-performance-sidebar-reveal') !== null) {
+      // Used in interaction tests & screenshot tests.
+      return;
+    }
     const needToRestore = this.#restoreSidebarVisibilityOnTraceLoad;
     const userHasSeenSidebar = this.#sideBar.userHasOpenedSidebarOnce();
     const experimentsEnabled = this.#panelSidebarEnabled();

front_end/panels/timeline/components/Sidebar.ts

@@ -65,7 +65,7 @@ export class SidebarWidget extends UI.Widget.VBox {
    * SplitWidget tracks its state in its own setting.
    */
   #userHasOpenedSidebarOnce =
-      Common.Settings.Settings.instance().createSetting<boolean>('timeline-user-has-opened-siderbar-once', false);
+      Common.Settings.Settings.instance().createSetting<boolean>('timeline-user-has-opened-sidebar-once', false);
 
   userHasOpenedSidebarOnce(): boolean {
     return this.#userHasOpenedSidebarOnce.get();

front_end/ui/components/docs/performance_panel/basic.ts

@@ -101,7 +101,10 @@ const cpuprofileName = params.get('cpuprofile');
 const traceUrl = params.get('loadTimelineFromURL');
 const nodeMode = params.get('isNode');
 const isNodeMode = nodeMode === 'true' ? true : false;
-Root.Runtime.experiments.setEnabled('timeline-invalidation-tracking', params.has('invalidations'));
+
+// These are both enabled by default in Chrome M131 and will be removed in M132.
+Root.Runtime.experiments.setEnabled(Root.Runtime.ExperimentName.TIMELINE_INSIGHTS, true);
+Root.Runtime.experiments.setEnabled(Root.Runtime.ExperimentName.TIMELINE_ANNOTATIONS, true);
 
 const timeline = Timeline.TimelinePanel.TimelinePanel.instance({forceNew: true, isNode: isNodeMode});
 const container = document.getElementById('container');

front_end/ui/visual_logging/KnownContextValues.ts

@@ -3002,6 +3002,7 @@ export const knownContextValues = new Set([
   'timeline-status',
   'timeline-tree-current-thread',
   'timeline-tree-group-by',
+  'timeline-user-has-opened-sidebar-once',
   'timeline-user-has-opened-siderbar-once',
   'timeline-v8-runtime-call-stats',
   'timeline.animations',