Skip to content

Commit c7ea2e2

Browse files
OrKoNDevtools-frontend LUCI CQ
authored andcommitted
Migrate test/e2e/issues/low-text-contrast-issues_test.ts
Fixed: 416405506 Change-Id: I796c5939b48fcd9ba984848c77bc965a74477c39 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6840854 Commit-Queue: Philip Pfaffe <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Auto-Submit: Alex Rudenko <[email protected]>
1 parent a1f115e commit c7ea2e2

File tree

3 files changed

+14
-12
lines changed

3 files changed

+14
-12
lines changed

test/e2e/issues/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import("../../../scripts/build/typescript/typescript.gni")
66

77
node_ts_library("issues") {
88
sources = [
9-
"low-text-contrast-issues_test.ts",
109
"quota-issues_test.ts",
1110
"user-reidentification-issues_test.ts",
1211
]

test/e2e_non_hosted/issues/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ ts_e2e_library("issues") {
2323
"issue-links_test.ts",
2424
"issue-view-caching_test.ts",
2525
"issue-view-reparent_test.ts",
26+
"low-text-contrast-issues_test.ts",
2627
"partitioning-blob-url-issues_test.ts",
2728
"privacy-sandbox-extensions-api_test.ts",
2829
"quirks-mode-issues_test.ts",

test/e2e/issues/low-text-contrast-issues_test.ts renamed to test/e2e_non_hosted/issues/low-text-contrast-issues_test.ts

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,29 @@
44

55
import {assert} from 'chai';
66

7-
import {enableExperiment, goToResource} from '../../shared/helper.js';
87
import {
98
assertIssueTitle,
109
expandIssue,
1110
getIssueByTitle,
1211
getResourcesElement,
1312
navigateToIssuesTab,
1413
waitForTableFromResourceSectionContents,
15-
} from '../helpers/issues-helpers.js';
14+
} from '../../e2e/helpers/issues-helpers.js';
1615

1716
describe('Low contrast issues', () => {
18-
it('should report low contrast issues', async () => {
19-
await enableExperiment('contrast-issues');
20-
await goToResource('elements/low-contrast.html');
21-
await navigateToIssuesTab();
22-
await expandIssue();
17+
setup({
18+
enabledDevToolsExperiments: ['contrast-issues'],
19+
});
20+
21+
it('should report low contrast issues', async ({devToolsPage, inspectedPage}) => {
22+
await inspectedPage.goToResource('elements/low-contrast.html');
23+
await navigateToIssuesTab(devToolsPage);
24+
await expandIssue(devToolsPage);
2325
const issueTitle = 'Users may have difficulties reading text content due to insufficient color contrast';
24-
await assertIssueTitle(issueTitle);
25-
const issueElement = await getIssueByTitle(issueTitle);
26+
await assertIssueTitle(issueTitle, devToolsPage);
27+
const issueElement = await getIssueByTitle(issueTitle, devToolsPage);
2628
assert.isOk(issueElement);
27-
const section = await getResourcesElement('3 elements', issueElement);
29+
const section = await getResourcesElement('3 elements', issueElement, undefined, devToolsPage);
2830
const expectedTableRows = [
2931
[
3032
'Element',
@@ -59,6 +61,6 @@ describe('Low contrast issues', () => {
5961
'400',
6062
],
6163
];
62-
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
64+
await waitForTableFromResourceSectionContents(section.content, expectedTableRows, devToolsPage);
6365
});
6466
});

0 commit comments

Comments
 (0)