[lint] Fix Stylelint not running

Node syncSpawn can be promisified, and never runs the following
scripts, but it somehow closes the process afterwards.
Marking no presubmit as it fails on windows if you change lint rules

No-Presubmit: true
Bug: none
Change-Id: I08fdc3174fe542a5f824239b085d3433e5a24573
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999261
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>

Author: Lightning00Blade

front_end/models/persistence/editFileSystemView.css

@@ -18,7 +18,8 @@
   }
 }
 
-.exclude-subfolders-text, .file-system-list-empty {
+.exclude-subfolders-text,
+.file-system-list-empty {
   padding: 0 var(--sys-size-6);
   height: var(--sys-size-13);
 }

front_end/models/persistence/workspaceSettingsTab.css

@@ -4,7 +4,8 @@
  * found in the LICENSE file.
  */
 
-.mappings-info, .folder-exclude-pattern {
+.mappings-info,
+.folder-exclude-pattern {
   height: var(--settings-single-item-height);
 }
 

front_end/panels/freestyler/components/userActionRow.css

@@ -100,21 +100,23 @@
 
   .scroll-button-container.left {
     left: 0;
-    background: linear-gradient(
-      90deg,
-      var(--sys-color-cdt-base-container) 0%,
-      var(--sys-color-cdt-base-container) 50%,
-      transparent
-    );
+    background:
+      linear-gradient(
+        90deg,
+        var(--sys-color-cdt-base-container) 0%,
+        var(--sys-color-cdt-base-container) 50%,
+        transparent
+      );
   }
 
   .scroll-button-container.right {
     right: 0;
-    background: linear-gradient(
-      90deg,
-      transparent,
-      var(--sys-color-cdt-base-container) 50%
-    );
+    background:
+      linear-gradient(
+        90deg,
+        transparent,
+        var(--sys-color-cdt-base-container) 50%
+      );
     justify-content: flex-end;
   }
 }

front_end/panels/mobile_throttling/throttlingSettingsTab.css

@@ -4,7 +4,6 @@
  * found in the LICENSE file.
  */
 
-
 .add-conditions-button {
   border: none;
 }

front_end/panels/security/sidebar.css

@@ -43,8 +43,7 @@
 .security-main-view-reload-message,
 .tree-outline li.security-sidebar-origins,
 .tree-outline li.security-group-list-item,
-.tree-outline span  {
-
+.tree-outline span {
   font: var(--sys-typescale-body4-medium);
 
   &:hover:not(:has(span[is="dt-checkbox"])) .selection {

front_end/panels/sensors/locationsSettingsTab.css

@@ -4,7 +4,6 @@
  * found in the LICENSE file.
  */
 
-
 .add-locations-button {
   border: none;
 }

front_end/panels/settings/frameworkIgnoreListSettingsTab.css

@@ -28,7 +28,9 @@
   flex: 0 1 auto;
 }
 
-.enable-ignore-listing, .ignore-list-item, .general-exclusion-group {
+.enable-ignore-listing,
+.ignore-list-item,
+.general-exclusion-group {
   padding-left: var(--sys-size-4);
 }
 

front_end/panels/settings/keybindsSettingsTab.css

@@ -10,7 +10,7 @@
 }
 
 .keybinds-key {
-  display:flex;
+  display: flex;
   align-items: center;
   justify-content: center;
   height: var(--sys-size-11);
@@ -19,14 +19,14 @@
   white-space: nowrap;
   border-radius: var(--sys-shape-corner-small);
   background: var(--sys-color-tonal-container);
-  padding: 0px var(--sys-size-4);
+  padding: 0 var(--sys-size-4);
 }
 
 .keybinds-list-item {
   margin: 0 var(--sys-size-6);
   padding: var(--sys-size-4) 0;
   display: grid;
-  grid-template-rows: 1fr ;
+  grid-template-rows: 1fr;
   grid-template-columns: 1fr 30px 2fr 30px 30px;
 }
 

front_end/panels/timeline/components/sidebarInsightsTab.css

@@ -49,8 +49,8 @@
     details:first-child & {
       border-top: 1px solid var(--sys-color-divider);
     }
-    }
   }
+}
 
 .zoom-button {
   margin-left: auto;

scripts/test/run_lint_check.js

@@ -11,10 +11,8 @@ const {extname, join} = require('path');
 const globby = require('globby');
 const yargs = require('yargs/yargs');
 const {hideBin} = require('yargs/helpers');
-const childProcess = require('child_process');
-const {promisify} = require('util');
+const {spawn} = require('child_process');
 const {readFileSync} = require('fs');
-const spawnAsync = promisify(childProcess.spawnSync);
 
 const {
   devtoolsRootPath,
@@ -102,11 +100,17 @@ async function runStylelint(files) {
  */
 async function runLitAnalyzer(files) {
   const readLitAnalyzerConfigFromCompilerOptions = () => {
-    const {compilerOptions} = JSON.parse(readFileSync(tsconfigJsonPath(), 'utf-8'));
+    const {compilerOptions} = JSON.parse(
+        readFileSync(tsconfigJsonPath(), 'utf-8'),
+    );
     const {plugins} = compilerOptions;
-    const tsLitPluginOptions = plugins.find(plugin => plugin.name === 'ts-lit-plugin');
+    const tsLitPluginOptions = plugins.find(
+        plugin => plugin.name === 'ts-lit-plugin',
+    );
     if (tsLitPluginOptions === null) {
-      throw new Error(`Failed to find ts-lit-plugin options in ${tsconfigJsonPath()}`);
+      throw new Error(
+          `Failed to find ts-lit-plugin options in ${tsconfigJsonPath()}`,
+      );
     }
     return tsLitPluginOptions;
   };
@@ -118,12 +122,36 @@ async function runLitAnalyzer(files) {
       ...Object.entries(rules).flatMap(([k, v]) => [`--rules.${k}`, v]),
       ...subsetFiles,
     ];
-    const result = await spawnAsync(nodePath(), args, {
-      encoding: 'utf-8',
-      cwd: devtoolsRootPath(),
-      stdio: 'inherit',
+
+    const result = {
+      output: '',
+      error: '',
+      status: false,
+    };
+
+    return await new Promise(resolve => {
+      const litAnalyzerProcess = spawn(nodePath(), args, {
+        encoding: 'utf-8',
+        cwd: devtoolsRootPath(),
+      });
+
+      litAnalyzerProcess.stdout.on('data', data => {
+        result.output += `\n${data.toString()}`;
+      });
+      litAnalyzerProcess.stderr.on('data', data => {
+        result.error += `\n${data.toString()}`;
+      });
+
+      litAnalyzerProcess.on('error', message => {
+        result.error += `\n${message}`;
+        resolve(result);
+      });
+
+      litAnalyzerProcess.on('exit', code => {
+        result.status = code === 0;
+        resolve(result);
+      });
     });
-    return result.status === 0;
   };
 
   const getSplitFiles = filesToSplit => {
@@ -145,13 +173,21 @@ async function runLitAnalyzer(files) {
     return splitFiles;
   };
 
-  const result = await Promise.all(
+  const results = await Promise.all(
       getSplitFiles(files).map(filesBatch => {
         return getLitAnalyzerResult(filesBatch);
       }),
   );
+  for (const result of results) {
+    if (result.output) {
+      console.log(result.output);
+    }
+    if (result.error) {
+      console.log(result.error);
+    }
+  }
 
-  return result.every(r => r);
+  return results.every(r => r.status);
 }
 
 async function run() {