RPP: do not pass insight details each time

Bug: 399610873
Change-Id: I4a2135c3726af3e7d356637af223de22389d2c6a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387438
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>

Author: jackfranklin

front_end/models/ai_assistance/agents/PerformanceInsightsAgent.test.ts

@@ -20,14 +20,23 @@ import {
 } from '../ai_assistance.js';
 
 const FAKE_LCP_MODEL = {
-  insightKey: 'LCPPhases',
+  insightKey: Trace.Insights.Types.InsightKeys.LCP_PHASES,
   strings: {},
   title: 'LCP by phase' as Common.UIString.LocalizedString,
   description: 'some description' as Common.UIString.LocalizedString,
   category: Trace.Insights.Types.InsightCategory.ALL,
   state: 'fail',
   frameId: '123',
 } as const;
+const FAKE_INP_MODEL = {
+  insightKey: Trace.Insights.Types.InsightKeys.INTERACTION_TO_NEXT_PAINT,
+  strings: {},
+  title: 'INP by phase' as Common.UIString.LocalizedString,
+  description: 'some description' as Common.UIString.LocalizedString,
+  category: Trace.Insights.Types.InsightCategory.ALL,
+  state: 'fail',
+  frameId: '123',
+} as const;
 const FAKE_PARSED_TRACE = {} as unknown as Trace.Handlers.Types.ParsedTrace;
 
 describeWithEnvironment('PerformanceInsightsAgent', () => {
@@ -144,6 +153,38 @@ What is this?`;
 
       assert.strictEqual(finalQuery, expected);
     });
+
+    it('does not add the context for follow-up queries with the same context', async () => {
+      const agent = new PerformanceInsightsAgent({
+        aidaClient: {} as Host.AidaClient.AidaClient,
+      });
+
+      const mockInsight = new TimelineUtils.InsightAIContext.ActiveInsight(FAKE_LCP_MODEL, FAKE_PARSED_TRACE);
+      const context = new InsightContext(mockInsight);
+
+      await agent.enhanceQuery('What is this?', context);
+      const finalQuery = await agent.enhanceQuery('Help me understand?', context);
+      const expected = `# User request:
+Help me understand?`;
+
+      assert.strictEqual(finalQuery, expected);
+    });
+
+    it('does add context to queries if the insight context changes', async () => {
+      const agent = new PerformanceInsightsAgent({
+        aidaClient: {} as Host.AidaClient.AidaClient,
+      });
+      const mockInsight1 = new TimelineUtils.InsightAIContext.ActiveInsight(FAKE_LCP_MODEL, FAKE_PARSED_TRACE);
+      const mockInsight2 = new TimelineUtils.InsightAIContext.ActiveInsight(FAKE_INP_MODEL, FAKE_PARSED_TRACE);
+      const context1 = new InsightContext(mockInsight1);
+      const context2 = new InsightContext(mockInsight2);
+      const firstQuery = await agent.enhanceQuery('Q1', context1);
+      const secondQuery = await agent.enhanceQuery('Q2', context1);
+      const thirdQuery = await agent.enhanceQuery('Q3', context2);
+      assert.include(firstQuery, '## Insight title: LCP by phase');
+      assert.notInclude(secondQuery, '## Insight title');
+      assert.include(thirdQuery, '## Insight title: INP by phase');
+    });
   });
 
   describe('function calls', () => {

front_end/models/ai_assistance/agents/PerformanceInsightsAgent.ts

@@ -69,10 +69,10 @@ You will also be provided with external resources. Use the contents of these res
 
 ## Critical requirements
 
-- *CRITICAL* never make the same function call twice.
+- *CRITICAL* never call \`getMainThreadActivity\` more than once in a conversation.
+- *CRITICAL* never call \`getNetworkActivitySummary\` more than once in a conversation.
 - *CRITICAL* make sure you are thorough and call the functions you have access to to give yourself the most information possible to make accurate recommendations.
 - *CRITICAL* your text output should NEVER mention the functions that you called. These are an implementation detail and not important for the user to be aware of.
-- *CRITICAL* if you are asked about the "Interaction to next paint" insight, make sure you call the \`getMainThreadActivity\` function before making suggestions to the user.
 `;
 /* clang-format on */
 
@@ -112,6 +112,8 @@ export class InsightContext extends ConversationContext<TimelineUtils.InsightAIC
 export class PerformanceInsightsAgent extends AiAgent<TimelineUtils.InsightAIContext.ActiveInsight> {
   #insight: ConversationContext<TimelineUtils.InsightAIContext.ActiveInsight>|undefined;
 
+  #lastContextForEnhancedQuery: ConversationContext<TimelineUtils.InsightAIContext.ActiveInsight>|undefined;
+
   override async *
       handleContextDetails(activeContext: ConversationContext<TimelineUtils.InsightAIContext.ActiveInsight>|null):
           AsyncGenerator<ContextResponse, void, void> {
@@ -223,6 +225,7 @@ export class PerformanceInsightsAgent extends AiAgent<TimelineUtils.InsightAICon
 
     this.declareFunction<Record<never, unknown>, {activity: string}>('getMainThreadActivity', {
       description: `Returns the main thread activity for the selected insight.
+
 The tree is represented as a call frame with a root task and a series of children.
 The format of each callframe is:
 
@@ -295,9 +298,17 @@ The fields are:
       return query;
     }
     const formatter = new PerformanceInsightFormatter(selectedInsight.getItem());
-    const extraQuery = `${formatter.formatInsight()}\n\n# User request:\n`;
+
+    // We only need to add Insight info to a prompt when the context changes. For example:
+    // User clicks Insight A. We need to send info on Insight A with the prompt.
+    // User asks follow up question. We do not need to resend Insight A with the prompt.
+    // User clicks Insight B. We now need to send info on Insight B with the prompt.
+    // User clicks Insight A. We should resend the Insight info with the prompt.
+    const includeInsightInfo = selectedInsight !== this.#lastContextForEnhancedQuery;
+    const extraQuery = `${includeInsightInfo ? formatter.formatInsight() + '\n\n' : ''}# User request:\n`;
 
     const finalQuery = `${extraQuery}${query}`;
+    this.#lastContextForEnhancedQuery = selectedInsight;
     return finalQuery;
   }