[AI Assistance] clean up debug utils

Bug: none
Change-Id: I60f1318c85ff9a3c80543c217ce0da20c6464824
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6243821
Reviewed-by: Nikolay Vitkov <[email protected]>
Auto-Submit: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>

Author: OrKoN

config/gni/devtools_grd_files.gni

@@ -1195,6 +1195,7 @@ grd_files_debug_sources = [
   "front_end/panels/ai_assistance/components/userActionRow.css.js",
   "front_end/panels/ai_assistance/data_formatters/FileFormatter.js",
   "front_end/panels/ai_assistance/data_formatters/NetworkRequestFormatter.js",
+  "front_end/panels/ai_assistance/debug.js",
   "front_end/panels/animation/AnimationGroupPreviewUI.js",
   "front_end/panels/animation/AnimationScreenshotPopover.js",
   "front_end/panels/animation/AnimationTimeline.js",

front_end/panels/ai_assistance/AiAssistancePanel.test.ts

@@ -166,11 +166,6 @@ describeWithEnvironment('FreestylerPanel', () => {
   });
 
   describe('on rate click', () => {
-    afterEach(() => {
-      // @ts-expect-error global test variable
-      setAiAssistanceServerSideLoggingEnabled(false);
-    });
-
     it('renders a button linking to settings', () => {
       const stub = sinon.stub(UI.ViewManager.ViewManager.instance(), 'showView');
 
@@ -187,8 +182,6 @@ describeWithEnvironment('FreestylerPanel', () => {
     });
 
     it('should allow logging if configured', () => {
-      // @ts-expect-error global test variable
-      setAiAssistanceServerSideLoggingEnabled(true);
       const stub = getGetHostConfigStub({
         aidaAvailability: {
           disallowLogging: false,

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -1051,35 +1051,12 @@ function isAiAssistancePatchingEnabled(): boolean {
   return Boolean(config.devToolsFreestyler?.patching);
 }
 
-function setAiAssistanceServerSideLoggingEnabled(enabled: boolean): void {
-  if (enabled) {
-    localStorage.setItem('aiAssistance_enableServerSideLogging', 'true');
-  } else {
-    localStorage.setItem('aiAssistance_enableServerSideLogging', 'false');
-  }
-}
-
 function isAiAssistanceServerSideLoggingEnabled(): boolean {
   const config = Common.Settings.Settings.instance().getHostConfig();
-  if (config.aidaAvailability?.disallowLogging) {
-    return false;
-  }
-  return localStorage.getItem('aiAssistance_enableServerSideLogging') !== 'false';
-}
-
-function setAiAssistanceStylingWithFunctionCalling(enabled: boolean): void {
-  if (enabled) {
-    localStorage.setItem('aiAssistance_stylingFunctionCalling', 'true');
-  } else {
-    localStorage.setItem('aiAssistance_stylingFunctionCalling', 'false');
-  }
+  return !config.aidaAvailability?.disallowLogging;
 }
 
 function isAiAssistanceStylingWithFunctionCallingEnabled(): boolean {
-  return localStorage.getItem('aiAssistance_stylingFunctionCalling') === 'true';
+  const config = Common.Settings.Settings.instance().getHostConfig();
+  return Boolean(config.devToolsFreestyler?.functionCalling);
 }
-
-// @ts-ignore
-globalThis.setAiAssistanceServerSideLoggingEnabled = setAiAssistanceServerSideLoggingEnabled;
-// @ts-ignore
-globalThis.setAiAssistanceStylingWithFunctionCalling = setAiAssistanceStylingWithFunctionCalling;

front_end/panels/ai_assistance/BUILD.gn

@@ -33,6 +33,7 @@ devtools_module("ai_assistance") {
     "components/UserActionRow.ts",
     "data_formatters/FileFormatter.ts",
     "data_formatters/NetworkRequestFormatter.ts",
+    "debug.ts",
   ]
 
   deps = [

front_end/panels/ai_assistance/agents/AiAgent.ts

@@ -4,6 +4,7 @@
 
 import * as Host from '../../../core/host/host.js';
 import type * as Lit from '../../../ui/lit/lit.js';
+import {debugLog, isDebugMode} from '../debug.js';
 
 export const enum ResponseType {
   CONTEXT = 'context',
@@ -494,7 +495,7 @@ export abstract class AiAgent<T> {
     }
 
     if (isDebugMode()) {
-      window.dispatchEvent(new CustomEvent('freestylerdone'));
+      window.dispatchEvent(new CustomEvent('aiassistancedone'));
     }
   }
 
@@ -640,7 +641,7 @@ export abstract class AiAgent<T> {
         response,
         aidaResponse,
       });
-      localStorage.setItem('freestylerStructuredLog', JSON.stringify(this.#structuredLog));
+      localStorage.setItem('aiAssistanceStructuredLog', JSON.stringify(this.#structuredLog));
     }
   }
 
@@ -679,26 +680,3 @@ STOP`;
     };
   }
 }
-
-export function isDebugMode(): boolean {
-  return Boolean(localStorage.getItem('debugFreestylerEnabled'));
-}
-
-export function debugLog(...log: unknown[]): void {
-  if (!isDebugMode()) {
-    return;
-  }
-
-  // eslint-disable-next-line no-console
-  console.log(...log);
-}
-
-function setDebugFreestylerEnabled(enabled: boolean): void {
-  if (enabled) {
-    localStorage.setItem('debugFreestylerEnabled', 'true');
-  } else {
-    localStorage.removeItem('debugFreestylerEnabled');
-  }
-}
-// @ts-ignore
-globalThis.setDebugFreestylerEnabled = setDebugFreestylerEnabled;

front_end/panels/ai_assistance/agents/StylingAgent.ts

@@ -12,6 +12,7 @@ import * as UI from '../../../ui/legacy/legacy.js';
 import * as Lit from '../../../ui/lit/lit.js';
 import {linkifyNodeReference} from '../../elements/DOMLinkifier.js';
 import {AI_ASSISTANCE_CSS_CLASS_NAME, ChangeManager} from '../ChangeManager.js';
+import {debugLog} from '../debug.js';
 import {EvaluateAction, formatError, SideEffectError} from '../EvaluateAction.js';
 import {ExtensionScope, FREESTYLER_WORLD_NAME} from '../ExtensionScope.js';
 
@@ -22,7 +23,6 @@ import {
   AiAgent,
   type ContextResponse,
   ConversationContext,
-  debugLog,
   type FunctionCallHandlerResult,
   type ParsedAnswer,
   type ParsedResponse,

front_end/panels/ai_assistance/ai_assistance.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+export * from './debug.js';
 export * from './agents/AiAgent.js';
 export * from './agents/FileAgent.js';
 export * from './agents/NetworkAgent.js';

front_end/panels/ai_assistance/debug.ts

@@ -0,0 +1,30 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview Local debugging utilities.
+ */
+
+export function isDebugMode(): boolean {
+  return Boolean(localStorage.getItem('debugAiAssistancePanelEnabled'));
+}
+
+export function debugLog(...log: unknown[]): void {
+  if (!isDebugMode()) {
+    return;
+  }
+
+  // eslint-disable-next-line no-console
+  console.log(...log);
+}
+
+function setDebugAiAssistanceEnabled(enabled: boolean): void {
+  if (enabled) {
+    localStorage.setItem('debugAiAssistancePanelEnabled', 'true');
+  } else {
+    localStorage.removeItem('debugAiAssistancePanelEnabled');
+  }
+}
+// @ts-ignore
+globalThis.setDebugAiAssistanceEnabled = setDebugAiAssistanceEnabled;

scripts/ai_assistance/auto-run.js

@@ -462,12 +462,12 @@ class Example {
     }
     const executionStartTime = performance.now();
     await this.#devtoolsPage.waitForFunction(() => {
-      return 'setDebugFreestylerEnabled' in window;
+      return 'setDebugAiAssistanceEnabled' in window;
     });
 
     await this.#devtoolsPage.evaluate(() => {
       // @ts-ignore this is run in the DevTools page context where this function does exist.
-      setDebugFreestylerEnabled(true);
+      setDebugAiAssistanceEnabled(true);
     });
 
     /** @type {Array<import('./types').IndividualPromptRequestResponse>} */
@@ -506,7 +506,7 @@ class Example {
 
       const done = this.#devtoolsPage.evaluate(() => {
         return /** @type {Promise<void>} */ (new Promise(resolve => {
-          window.addEventListener('freestylerdone', () => {
+          window.addEventListener('aiassistancedone', () => {
             resolve();
           }, {
             once: true,
@@ -519,10 +519,10 @@ class Example {
       abort.abort();
 
       const logs = await devtoolsPage.evaluate(() => {
-        return localStorage.getItem('freestylerStructuredLog');
+        return localStorage.getItem('aiAssistanceStructuredLog');
       });
       if (!logs) {
-        throw new Error('No freestylerStructuredLog entries were found.');
+        throw new Error('No aiAssistanceStructuredLog entries were found.');
       }
       /** @type {import('./types').IndividualPromptRequestResponse[]} */
       const results = JSON.parse(logs);

test/e2e/ai_assistance/ai_assistance_test.ts

@@ -125,11 +125,11 @@ describe('AI Assistance', function() {
   async function enableDebugModeForFreestyler(): Promise<void> {
     const {frontend} = getBrowserAndPages();
     await frontend.waitForFunction(() => {
-      return 'setDebugFreestylerEnabled' in window;
+      return 'setDebugAiAssistanceEnabled' in window;
     });
     await frontend.evaluate(() => {
       // @ts-ignore
-      setDebugFreestylerEnabled(true);
+      setDebugAiAssistanceEnabled(true);
     });
   }
 
@@ -152,7 +152,7 @@ describe('AI Assistance', function() {
     const {frontend} = getBrowserAndPages();
     const done = frontend.evaluate(() => {
       return new Promise(resolve => {
-        window.addEventListener('freestylerdone', resolve, {
+        window.addEventListener('aiassistancedone', resolve, {
           once: true,
         });
       });
@@ -162,7 +162,7 @@ describe('AI Assistance', function() {
     if (waitForSideEffect) {
       await frontend.waitForSelector('aria/Continue');
       return JSON.parse(await frontend.evaluate((): string => {
-        return localStorage.getItem('freestylerStructuredLog') as string;
+        return localStorage.getItem('aiAssistanceStructuredLog') as string;
       })) as Array<Log>;
     }
 
@@ -177,7 +177,7 @@ describe('AI Assistance', function() {
     await done;
     abort.abort();
     return JSON.parse(await frontend.evaluate((): string => {
-      return localStorage.getItem('freestylerStructuredLog') as string;
+      return localStorage.getItem('aiAssistanceStructuredLog') as string;
     })) as Array<Log>;
   }
 
@@ -486,7 +486,7 @@ STOP`,
     const {frontend} = getBrowserAndPages();
     const done = frontend.evaluate(() => {
       return new Promise(resolve => {
-        window.addEventListener('freestylerdone', resolve, {
+        window.addEventListener('aiassistancedone', resolve, {
           once: true,
         });
       });