Skip to content

Commit d031fd1

Browse files
danilsomsikovDevtools-frontend LUCI CQ
authored andcommitted
Add various shortcuts to the known context values
These are all the values that currently appear in logs, even though to all of these are DevTools shortcuts. The way the tracking is currently set up, `track({keydown: 'KeyA|Key2'})` will log only events with matching key codes but with any modifiers. We probably need to understand strings like 'Ctrl-Alt-KeyA' instead. Bug: 40276793 Change-Id: I93a5bcfe7f22df0c81e4099843d406b26833e0ba Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6084656 Auto-Submit: Danil Somsikov <[email protected]> Commit-Queue: Danil Somsikov <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]>
1 parent c263a0b commit d031fd1

File tree

1 file changed

+161
-0
lines changed

1 file changed

+161
-0
lines changed

front_end/ui/visual_logging/KnownContextValues.ts

Lines changed: 161 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,42 @@ export const knownContextValues = new Set([
360360
'allow-scroll-past-eof',
361361
'allow-scroll-past-eof-false',
362362
'alpha',
363+
'alt-!',
364+
'alt-:',
365+
'alt->',
366+
'alt-?',
367+
'alt-@',
368+
'alt-arrowdown',
369+
'alt-arrowleft',
370+
'alt-arrowright',
371+
'alt-arrowup',
372+
'alt-backspace',
373+
'alt-delete',
374+
'alt-end',
375+
'alt-enter',
376+
'alt-escape',
377+
'alt-home',
378+
'alt-meta-!',
379+
'alt-meta-:',
380+
'alt-meta->',
381+
'alt-meta-?',
382+
'alt-meta-@',
383+
'alt-meta-arrowdown',
384+
'alt-meta-arrowleft',
385+
'alt-meta-arrowright',
386+
'alt-meta-arrowup',
387+
'alt-meta-backspace',
388+
'alt-meta-delete',
389+
'alt-meta-end',
390+
'alt-meta-enter',
391+
'alt-meta-escape',
392+
'alt-meta-home',
393+
'alt-meta-pagedown',
394+
'alt-meta-pageup',
395+
'alt-meta-tab',
396+
'alt-pagedown',
397+
'alt-pageup',
398+
'alt-tab',
363399
'am',
364400
'anchor-link',
365401
'anchor-name',
@@ -933,6 +969,59 @@ export const knownContextValues = new Set([
933969
'cssShadowEditor',
934970
'cssoverview',
935971
'ctap2',
972+
'ctrl-!',
973+
'ctrl-:',
974+
'ctrl->',
975+
'ctrl-?',
976+
'ctrl-@',
977+
'ctrl-alt-!',
978+
'ctrl-alt-:',
979+
'ctrl-alt->',
980+
'ctrl-alt-?',
981+
'ctrl-alt-@',
982+
'ctrl-alt-arrowdown',
983+
'ctrl-alt-arrowleft',
984+
'ctrl-alt-arrowright',
985+
'ctrl-alt-arrowup',
986+
'ctrl-alt-backspace',
987+
'ctrl-alt-delete',
988+
'ctrl-alt-end',
989+
'ctrl-alt-enter',
990+
'ctrl-alt-escape',
991+
'ctrl-alt-home',
992+
'ctrl-alt-meta-:',
993+
'ctrl-alt-meta->',
994+
'ctrl-alt-meta-?',
995+
'ctrl-alt-meta-@',
996+
'ctrl-alt-meta-arrowdown',
997+
'ctrl-alt-meta-arrowleft',
998+
'ctrl-alt-meta-arrowright',
999+
'ctrl-alt-meta-arrowup',
1000+
'ctrl-alt-meta-backspace',
1001+
'ctrl-alt-meta-delete',
1002+
'ctrl-alt-meta-end',
1003+
'ctrl-alt-meta-enter',
1004+
'ctrl-alt-meta-escape',
1005+
'ctrl-alt-meta-home',
1006+
'ctrl-alt-meta-pagedown',
1007+
'ctrl-alt-meta-pageup',
1008+
'ctrl-alt-meta-tab',
1009+
'ctrl-alt-pagedown',
1010+
'ctrl-alt-pageup',
1011+
'ctrl-alt-tab',
1012+
'ctrl-arrowdown',
1013+
'ctrl-arrowleft',
1014+
'ctrl-arrowright',
1015+
'ctrl-arrowup',
1016+
'ctrl-backspace',
1017+
'ctrl-delete',
1018+
'ctrl-end',
1019+
'ctrl-enter',
1020+
'ctrl-escape',
1021+
'ctrl-home',
1022+
'ctrl-pagedown',
1023+
'ctrl-pageup',
1024+
'ctrl-tab',
9361025
'cumulative-layout-shifts',
9371026
'current-dock-state-bottom',
9381027
'current-dock-state-left',
@@ -2165,6 +2254,24 @@ export const knownContextValues = new Set([
21652254
'messageerror',
21662255
'messages',
21672256
'messaging',
2257+
'meta-!',
2258+
'meta-:',
2259+
'meta->',
2260+
'meta-?',
2261+
'meta-@',
2262+
'meta-arrowdown',
2263+
'meta-arrowleft',
2264+
'meta-arrowright',
2265+
'meta-arrowup',
2266+
'meta-backspace',
2267+
'meta-delete',
2268+
'meta-end',
2269+
'meta-enter',
2270+
'meta-escape',
2271+
'meta-home',
2272+
'meta-pagedown',
2273+
'meta-pageup',
2274+
'meta-tab',
21682275
'metadata',
21692276
'metadata-allowed-sites-details',
21702277
'method',
@@ -2906,6 +3013,60 @@ export const knownContextValues = new Set([
29063013
'shared-storage-instance',
29073014
'shared-storage-worklet',
29083015
'shared-storage-worklet-script-first-statement',
3016+
'shift-!',
3017+
'shift-?',
3018+
'shift-arrowdown',
3019+
'shift-arrowleft',
3020+
'shift-arrowright',
3021+
'shift-arrowup',
3022+
'shift-backspace',
3023+
'shift-ctrl-alt-arrowdown',
3024+
'shift-ctrl-alt-arrowleft',
3025+
'shift-ctrl-alt-arrowright',
3026+
'shift-ctrl-alt-arrowup',
3027+
'shift-ctrl-alt-backspace',
3028+
'shift-ctrl-alt-delete',
3029+
'shift-ctrl-alt-end',
3030+
'shift-ctrl-alt-enter',
3031+
'shift-ctrl-alt-escape',
3032+
'shift-ctrl-alt-home',
3033+
'shift-ctrl-alt-meta-arrowdown',
3034+
'shift-ctrl-alt-meta-arrowleft',
3035+
'shift-ctrl-alt-meta-arrowright',
3036+
'shift-ctrl-alt-meta-arrowup',
3037+
'shift-ctrl-alt-meta-backspace',
3038+
'shift-ctrl-alt-meta-delete',
3039+
'shift-ctrl-alt-meta-end',
3040+
'shift-ctrl-alt-meta-enter',
3041+
'shift-ctrl-alt-meta-escape',
3042+
'shift-ctrl-alt-meta-home',
3043+
'shift-ctrl-alt-meta-pagedown',
3044+
'shift-ctrl-alt-meta-pageup',
3045+
'shift-ctrl-alt-meta-tab',
3046+
'shift-ctrl-alt-pagedown',
3047+
'shift-ctrl-alt-pageup',
3048+
'shift-ctrl-alt-tab',
3049+
'shift-ctrl-arrowdown',
3050+
'shift-ctrl-arrowleft',
3051+
'shift-ctrl-arrowright',
3052+
'shift-ctrl-arrowup',
3053+
'shift-ctrl-backspace',
3054+
'shift-ctrl-delete',
3055+
'shift-ctrl-end',
3056+
'shift-ctrl-enter',
3057+
'shift-ctrl-escape',
3058+
'shift-ctrl-home',
3059+
'shift-ctrl-pagedown',
3060+
'shift-ctrl-pageup',
3061+
'shift-ctrl-tab',
3062+
'shift-delete',
3063+
'shift-end',
3064+
'shift-enter',
3065+
'shift-escape',
3066+
'shift-home',
3067+
'shift-pagedown',
3068+
'shift-pageup',
3069+
'shift-tab',
29093070
'shortcut',
29103071
'shortcut-panel-switch',
29113072
'shortcuts',

0 commit comments

Comments
 (0)