Skip to content

Commit d12440f

Browse files
danilsomsikovDevtools-frontend LUCI CQ
authored andcommitted
Enable the no-imperative-dom-api rule but disable it for each offending file
This will allow us to track the violations and gradually use suggested fixes for migration Bug: 400353541 Change-Id: I8444d9d1d5026b104614d36d95247c5ceea2e06b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410353 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Danil Somsikov <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]>
1 parent df012c2 commit d12440f

File tree

229 files changed

+270
-2
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

229 files changed

+270
-2
lines changed

eslint.config.mjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -611,6 +611,7 @@ export default [
611611
allowIIFEs: true,
612612
},
613613
],
614+
'rulesdir/no-imperative-dom-api': 'error',
614615
'rulesdir/no-importing-images-from-src': 'error',
615616
'rulesdir/enforce-bound-render-for-schedule-render': 'error',
616617
'rulesdir/enforce-custom-event-names': 'error',
@@ -698,6 +699,7 @@ export default [
698699
'rulesdir/no-assert-deep-strict-equal': 'error',
699700
'rulesdir/no-assert-equal': 'error',
700701
'rulesdir/no-assert-equal-boolean-null-undefined': 'error',
702+
'rulesdir/no-imperative-dom-api': 'off',
701703
'rulesdir/no-screenshot-test-outside-perf-panel': 'error',
702704
'rulesdir/prefer-assert-instance-of': 'error',
703705
'rulesdir/prefer-assert-is-ok': 'error',
@@ -797,6 +799,7 @@ export default [
797799
// We use Lit to help render examples sometimes and we don't use
798800
// {host: this} as often the `this` is the window.
799801
'rulesdir/lit-host-this': 'off',
802+
'rulesdir/no-imperative-dom-api': 'off',
800803
},
801804
},
802805
{

front_end/core/host/InspectorFrontendHost.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
// TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
3232
/* eslint-disable @typescript-eslint/no-unused-vars */
33+
/* eslint-disable rulesdir/no-imperative-dom-api */
3334

3435
import * as Common from '../common/common.js';
3536
import * as i18n from '../i18n/i18n.js';

front_end/core/i18n/i18nImpl.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright 2020 The Chromium Authors. All rights reserved.
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4+
/* eslint-disable rulesdir/no-imperative-dom-api */
45

56
import * as I18n from '../../third_party/i18n/i18n.js';
67
import type * as Platform from '../platform/platform.js';

front_end/core/sdk/CSSPropertyParserMatchers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright 2023 The Chromium Authors. All rights reserved.
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4+
/* eslint-disable rulesdir/no-imperative-dom-api */
45

56
import * as Common from '../../core/common/common.js';
67
import type * as Platform from '../../core/platform/platform.js';

front_end/entrypoints/inspector_main/InspectorMain.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright 2018 The Chromium Authors. All rights reserved.
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4+
/* eslint-disable rulesdir/no-imperative-dom-api */
45

56
import * as Common from '../../core/common/common.js';
67
import * as Host from '../../core/host/host.js';

front_end/entrypoints/inspector_main/OutermostTargetSelector.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright 2023 The Chromium Authors. All rights reserved.
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4+
/* eslint-disable rulesdir/no-imperative-dom-api */
45

56
import type * as Common from '../../core/common/common.js';
67
import * as i18n from '../../core/i18n/i18n.js';

front_end/entrypoints/inspector_main/RenderingOptions.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2929
*/
3030

31+
/* eslint-disable rulesdir/no-imperative-dom-api */
32+
3133
import * as Common from '../../core/common/common.js';
3234
import * as Host from '../../core/host/host.js';
3335
import * as i18n from '../../core/i18n/i18n.js';

front_end/entrypoints/main/MainImpl.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright 2021 The Chromium Authors. All rights reserved.
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4+
/* eslint-disable rulesdir/no-imperative-dom-api */
45

56
/*
67
* Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.

front_end/entrypoints/node_app/NodeConnectionsPanel.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright 2015 The Chromium Authors. All rights reserved.
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4+
/* eslint-disable rulesdir/no-imperative-dom-api */
45

56
import type * as Common from '../../core/common/common.js';
67
import * as Host from '../../core/host/host.js';

front_end/models/extensions/ExtensionServer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
// TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
3232
/* eslint-disable @typescript-eslint/naming-convention */
33+
/* eslint-disable rulesdir/no-imperative-dom-api */
3334

3435
import type {Chrome} from '../../../extension-api/ExtensionAPI.js';
3536
import * as Common from '../../core/common/common.js';

0 commit comments

Comments
 (0)