Skip to content

Commit d1d713e

Browse files
OrKoNDevtools-frontend LUCI CQ
authored andcommitted
Suppress source map errors
If a test causes an error page, the test will be retried. DevTools tries to request a source map on the error page, thus, failing the entire test run due to source map loading errors even if the test retry was successful. This CL adds the network resource loading errors related to source maps to the global allow list. Bug: none Change-Id: I5678d9e2d73a8b2a0f916a4351a84a12e537b743 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5961817 Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Alex Rudenko <[email protected]>
1 parent 465796b commit d1d713e

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

test/conductor/events.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ const ALLOWED_ASSERTION_FAILURES = [
3636
'Request Storage.getStorageKeyForFrame failed. {"code":-32602,"message":"Frame tree node for given frame not found"}',
3737
'Unable to create texture',
3838
'Not allowed to load local resource: devtools://theme/colors.css',
39+
// neterror.js started serving sourcemaps and we're requesting it unnecessarily.
40+
'Request Network.loadNetworkResource failed. {"code":-32602,"message":"Unsupported URL scheme"}',
41+
'Fetch API cannot load chrome-error://chromewebdata/neterror.rollup.js.map. URL scheme "chrome-error" is not supported.',
3942
];
4043

4144
const logLevels = {

test/e2e/layers/layers_test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import {assert} from 'chai';
66

7-
import {expectError} from '../../conductor/events.js';
87
import {
98
getBrowserAndPages,
109
getResourcesPath,
@@ -41,10 +40,6 @@ describe('The Layers Panel', () => {
4140

4241
// Flaky test.
4342
it.skipOnPlatforms(['linux'], '[crbug.com/327062511] should update the layers view when going offline', async () => {
44-
// neterror.js started serving sourcemaps and we're requesting it unnecessarily.
45-
expectError('Request Network.loadNetworkResource failed. {"code":-32602,"message":"Unsupported URL scheme"}');
46-
expectError(
47-
'Fetch API cannot load chrome-error://chromewebdata/neterror.rollup.js.map. URL scheme "chrome-error" is not supported.');
4843
const {target, frontend} = getBrowserAndPages();
4944
await openPanelViaMoreTools('Layers');
5045

0 commit comments

Comments
 (0)