Skip to content

Commit d25ae31

Browse files
ktranDevtools-frontend LUCI CQ
authored andcommitted
[GM3Restyling] Adjust settings page styles
This fixes a few settings page styles resulting from UX review, in particular: * Throttling and Locations: adjust to smaller card size * Scrollbars: avoid layout shift due to scrollbars * Cards: adjust setting card shadows, and max width Bug: 368238837 Change-Id: I5761c3cbf9b17f67cee047c07d356218ccf2771c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6003764 Reviewed-by: Ergün Erdoğmuş <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]> Auto-Submit: Kim-Anh Tran <[email protected]>
1 parent 1f1d642 commit d25ae31

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

front_end/panels/mobile_throttling/throttlingSettingsTab.css

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
}
1111

1212
.conditions-list {
13+
margin-top: var(--sys-size-3);
1314
flex: auto;
1415
}
1516

@@ -23,7 +24,9 @@
2324
}
2425

2526
.conditions-list-text {
26-
flex: 0 0 80px;
27+
text-overflow: ellipsis;
28+
overflow: hidden;
29+
flex: 0 0 50px;
2730
user-select: none;
2831
color: var(--sys-color-on-surface);
2932
text-align: center;
@@ -48,6 +51,9 @@
4851

4952
.conditions-list-title-text {
5053
flex: auto;
54+
text-overflow: ellipsis;
55+
overflow: hidden;
56+
white-space: nowrap;
5157
}
5258

5359
.conditions-list-separator {
@@ -97,6 +103,7 @@
97103
}
98104

99105
.settings-card-container-wrapper {
106+
scrollbar-gutter: stable;
100107
padding-bottom: var(--sys-size-8);
101108
overflow: auto;
102109
position: absolute;

front_end/panels/sensors/locationsSettingsTab.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
}
1111

1212
.locations-list {
13-
min-width: 340px;
13+
margin-top: var(--sys-size-3);
1414
flex: auto;
1515
}
1616

@@ -72,6 +72,7 @@
7272
}
7373

7474
.settings-card-container-wrapper {
75+
scrollbar-gutter: stable;
7576
padding-bottom: var(--sys-size-8);
7677
overflow: auto;
7778
position: absolute;

front_end/panels/settings/settingsScreen.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ div:has(.settings-select) + div:has(.settings-select) {
7272
}
7373

7474
.settings-card-container-wrapper {
75+
scrollbar-gutter: stable;
7576
padding-bottom: var(--sys-size-8);
7677
overflow: auto;
7778
position: absolute;

front_end/ui/components/cards/card.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
*/
66
:host {
77
display: flex;
8-
max-width: var(--sys-size-37);
8+
max-width: var(--sys-size-35);
99
width: 100%;
1010
}
1111

1212
.card {
1313
break-inside: avoid;
1414
min-width: var(--sys-size-31);
15-
max-width: var(--sys-size-37);
15+
max-width: var(--sys-size-35);
1616
margin: var(--sys-size-3) var(--sys-size-6) var(--sys-size-5) var(--sys-size-5);
1717
flex: 1;
1818
}
@@ -38,7 +38,7 @@ slot[name="heading-suffix"]::slotted(*) {
3838

3939
.content-container {
4040
border-radius: var(--sys-shape-corner-small);
41-
box-shadow: var(--sys-elevation-level3);
41+
box-shadow: var(--sys-elevation-level2);
4242
display: flex;
4343
flex-direction: column;
4444
background: var(--app-color-card-background);

0 commit comments

Comments
 (0)