[cleanup] Types

Bug: none
Change-Id: I1cc9e234ff00346fa429aef31aee3d95f11e4d11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6448689
Commit-Queue: Benedikt Meurer <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

extension-api/ExtensionAPI.d.ts

@@ -4,8 +4,7 @@
 
 export namespace Chrome {
   export namespace DevTools {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    export interface EventSink<ListenerT extends(...args: any) => void> {
+    export interface EventSink<ListenerT extends(...args: any[]) => void> {
       addListener(listener: ListenerT): void;
       removeListener(listener: ListenerT): void;
     }

front_end/core/common/ResourceType.ts

@@ -220,10 +220,7 @@ export class ResourceType {
   }
 
   static fromName(name: string): ResourceType|null {
-    for (const resourceTypeId in resourceTypes) {
-      const resourceType = (resourceTypes as {
-        [x: string]: ResourceType,
-      })[resourceTypeId];
+    for (const resourceType of Object.values(resourceTypes)) {
       if (resourceType.name() === name) {
         return resourceType;
       }
@@ -427,7 +424,7 @@ export const resourceTypes = {
   SourceMapStyleSheet:
       new ResourceType('sm-stylesheet', i18nLazyString(UIStrings.stylesheet), resourceCategories.Stylesheet, true),
   WebBundle: new ResourceType('webbundle', i18nLazyString(UIStrings.webbundle), resourceCategories.Other, false),
-};
+} as const;
 
 const mimeTypeByName = new Map([
   // CoffeeScript

front_end/core/host/InspectorFrontendHost.ts

@@ -568,7 +568,7 @@ class InspectorFrontendAPIImpl {
     }
   }
 
-  private dispatch(name: symbol, signature: string[], _runOnceLoaded: boolean, ...params: string[]): void {
+  private dispatch(name: Events, signature: string[], _runOnceLoaded: boolean, ...params: string[]): void {
     // Single argument methods get dispatched with the param.
     if (signature.length < 2) {
       try {
@@ -579,9 +579,7 @@ class InspectorFrontendAPIImpl {
       }
       return;
     }
-    const data: {
-      [x: string]: string,
-    } = {};
+    const data: Record<string, string> = {};
     for (let i = 0; i < signature.length; ++i) {
       data[signature[i]] = params[i];
     }

front_end/core/host/InspectorFrontendHostAPI.ts

@@ -67,7 +67,7 @@ export const EventDescriptors = [
   [Events.SetInspectedTabId, 'setInspectedTabId', ['tabId']],
   [Events.SetUseSoftMenu, 'setUseSoftMenu', ['useSoftMenu']],
   [Events.ShowPanel, 'showPanel', ['panelName']],
-];
+] as const;
 
 export interface DispatchMessageChunkEvent {
   messageChunk: string;

front_end/entrypoints/formatter_worker/ESTreeWalker.ts

@@ -44,9 +44,7 @@ export class ESTreeWalker {
         // @ts-expect-error We are doing type traversal here, but the strings
         // in _walkOrder are not mapping. Preferably, we would use the
         // properties as defined in the types, but we can't do that yet.
-        // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        const entity = (node[walkOrder[i]] as any);
+        const entity = node[walkOrder[i]];
         if (Array.isArray(entity)) {
           this.#walkArray((entity as Acorn.ESTree.Node[]), node);
         } else {

front_end/ui/legacy/components/color_picker/Spectrum.ts

@@ -1398,7 +1398,7 @@ export class Spectrum extends Common.ObjectWrapper.eventMixin<EventTypes, typeof
       // Wait for TypeScript to support the definition of EyeDropper API:
       // https://github.com/microsoft/TypeScript/issues/48638
       /* eslint-disable  @typescript-eslint/no-explicit-any */
-      const eyeDropper = new (<any>window).EyeDropper();
+      const eyeDropper = new (window as any).EyeDropper();
       this.eyeDropperAbortController = new AbortController();
 
       try {

front_end/ui/legacy/components/data_grid/SortableDataGrid.ts

@@ -60,7 +60,7 @@ export class SortableDataGrid<T> extends ViewportDataGrid<SortableDataGridNode<T
       return null;
     }
 
-    const columns = ([] as ColumnDescriptor[]);
+    const columns: ColumnDescriptor[] = [];
     for (let i = 0; i < columnNames.length; ++i) {
       const id = String(i);
       columns.push(({id, title: columnNames[i], sortable: true} as ColumnDescriptor));
@@ -78,7 +78,7 @@ export class SortableDataGrid<T> extends ViewportDataGrid<SortableDataGridNode<T
       nodes.push(node);
     }
 
-    const dataGrid = new SortableDataGrid(({displayName, columns} as Parameters));
+    const dataGrid = new SortableDataGrid({displayName, columns});
     const length = nodes.length;
     const rootNode = dataGrid.rootNode();
     for (let i = 0; i < length; ++i) {