[eslint] Enable useful rules

@typescript-eslint/no-inferrable-types Simplifies the code and makes
type be more specific.

@typescript-eslint/return-await In theory more performant, but also
provides better debugging experience.

@typescript-eslint/ban-ts-comment Disallow all but ts-expect-error, as
else the error may get fixed not remove and later mask unrelated issues

Bug: 397260638
Change-Id: I09f268eb9157336635c378fa76546a4196e448e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6281149
Reviewed-by: Victor Porof <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

eslint.config.mjs

@@ -502,11 +502,30 @@ export default [
       // certain TypeScript compilation errors after fixes
       '@typescript-eslint/no-unnecessary-type-assertion': 'off',
 
+      '@typescript-eslint/no-inferrable-types': 'error',
+
       '@typescript-eslint/consistent-generic-constructors': [
         'error',
         'constructor',
       ],
 
+      // This is more performant
+      // And should provide better stack trace when debugging
+      // see https://v8.dev/blog/fast-async.
+      '@typescript-eslint/return-await': ['error', 'always'],
+
+      '@typescript-eslint/ban-ts-comment': [
+        'error',
+        {
+          // Change after we add some placeholder for old errors
+          minimumDescriptionLength: 0,
+          'ts-check': false,
+          'ts-expect-error': 'allow-with-description',
+          'ts-ignore': true,
+          'ts-nocheck': true,
+        },
+      ],
+
       'rulesdir/no-underscored-properties': 'error',
       'rulesdir/inline-type-imports': 'error',
 

extensions/cxx_debugging/src/CustomFormatters.ts

@@ -361,7 +361,8 @@ export class CXXValue implements Value, LazyObject {
 
       try {
         const formattedValue = await formatter.format(this.wasm, value);
-        return lazyObjectFromAny(formattedValue, this.objectStore, this.type, this.displayValue, this.memoryAddress)
+        return await lazyObjectFromAny(
+                   formattedValue, this.objectStore, this.type, this.displayValue, this.memoryAddress)
             .asRemoteObject();
       } catch {
         // Fallthrough
@@ -505,7 +506,7 @@ function lazyObjectFromAny(
 }
 
 export class LazyObjectStore {
-  private nextObjectId: number = 0;
+  private nextObjectId = 0;
   private objects = new Map<string, LazyObject>();
 
   store(lazyObject: LazyObject): string {

extensions/cxx_debugging/src/DWARFSymbols.ts

@@ -201,7 +201,7 @@ export class DWARFLanguageExtensionPlugin implements Chrome.DevTools.LanguageExt
           // Ensure directory exists
           if (parentDirectory.length > 1) {
             // TypeScript doesn't know about createPath
-            // @ts-ignore
+            // @ts-expect-error
             backend.FS.createPath('/', parentDirectory.substring(1), true, true);
           }
 
@@ -216,7 +216,7 @@ export class DWARFLanguageExtensionPlugin implements Chrome.DevTools.LanguageExt
               void this.hostInterface.reportResourceLoad(dwoURL, {success: false, errorMessage: (e as Error).message});
               // Rethrow any error fetching the content as errno 44 (EEXIST)
               // TypeScript doesn't know about the ErrnoError constructor
-              // @ts-ignore
+              // @ts-expect-error
               throw new backend.FS.ErrnoError(44);
             }
           };
@@ -557,7 +557,7 @@ export class DWARFLanguageExtensionPlugin implements Chrome.DevTools.LanguageExt
         description: '<optimized out>',
       };
     }
-    return cxxObject.asRemoteObject();
+    return await cxxObject.asRemoteObject();
   }
 
   async getProperties(objectId: Chrome.DevTools.RemoteObjectId): Promise<Chrome.DevTools.PropertyDescriptor[]> {
@@ -582,7 +582,7 @@ export class DWARFLanguageExtensionPlugin implements Chrome.DevTools.LanguageExt
 export async function createPlugin(
     hostInterface: HostInterface, resourceLoader: ResourceLoader,
     moduleConfigurations: ModuleConfigurations = DEFAULT_MODULE_CONFIGURATIONS,
-    logPluginApiCalls: boolean = false): Promise<DWARFLanguageExtensionPlugin> {
+    logPluginApiCalls = false): Promise<DWARFLanguageExtensionPlugin> {
   const plugin = new DWARFLanguageExtensionPlugin(moduleConfigurations, resourceLoader, hostInterface);
   if (logPluginApiCalls) {
     const pluginLoggingProxy = {

extensions/cxx_debugging/src/DevToolsPluginHost.ts

@@ -35,7 +35,7 @@ export class WorkerPlugin implements Chrome.DevTools.LanguageExtensionPlugin, As
 
   static async create(
       moduleConfigurations: ModuleConfigurations = DEFAULT_MODULE_CONFIGURATIONS,
-      logPluginApiCalls: boolean = false): Promise<WorkerPlugin> {
+      logPluginApiCalls = false): Promise<WorkerPlugin> {
     const plugin = new WorkerPlugin();
     await plugin.rpc.sendMessage('hello', moduleConfigurations, logPluginApiCalls);
     return plugin;

extensions/cxx_debugging/tests/RealBackend.ts

@@ -36,7 +36,7 @@ async function waitFor<ReturnT>(
       reject(e);
     }
   };
-  return new Promise<ReturnT>((resolve, reject) => callback(resolve, reject));
+  return await new Promise<ReturnT>((resolve, reject) => callback(resolve, reject));
 }
 
 export interface BreakLocation {
@@ -218,7 +218,7 @@ export class Debugger {
   }
 
   async waitForScript(url: string, timeout = 0): Promise<string> {
-    return waitFor(() => this.scripts.get(url)?.scriptId, timeout);
+    return await waitFor(() => this.scripts.get(url)?.scriptId, timeout);
   }
 
   async waitForPause(timeout = 0): Promise<PauseLocation> {
@@ -227,10 +227,10 @@ export class Debugger {
     }
     const waitPromise = new Promise<PauseLocation>(resolve => this.waitForPauseQueue.push({resolve}));
     if (timeout === 0) {
-      return waitPromise;
+      return await waitPromise;
     }
     const timeoutPromise = new Promise<PauseLocation>((_, r) => setTimeout(() => r(new Error('Timeout')), timeout));
-    return Promise.race([waitPromise, timeoutPromise]);
+    return await Promise.race([waitPromise, timeoutPromise]);
   }
 
   async evaluateFunction<T>(expression: string): Promise<T> {
@@ -285,7 +285,7 @@ export class Debugger {
   async evaluateOnCallFrame<T>(
       expectValue: boolean, convert: (result: Protocol.Runtime.RemoteObject) => T, expression: string,
       {callFrameId}: Protocol.Debugger.CallFrame): Promise<T> {
-    return this.evaluateOnCallFrameId(expectValue, convert, expression, callFrameId);
+    return await this.evaluateOnCallFrameId(expectValue, convert, expression, callFrameId);
   }
 
   async evaluateOnCallFrameId<T>(
@@ -301,7 +301,7 @@ export class Debugger {
   }
 
   async waitForFunction<T>(expression: string, timeout = 0): Promise<T> {
-    return waitFor(() => this.evaluateFunction<T>(expression), timeout);
+    return await waitFor(() => this.evaluateFunction<T>(expression), timeout);
   }
 
   page(script: string): WasmBackendPage {
@@ -465,7 +465,7 @@ class WasmBackendPage {
 
   async go(timeout = 0): Promise<number> {
     await this.debug.waitForFunction('window.isReady && window.isReady()', timeout);
-    return this.debug.evaluateFunction<number>('window.go()');
+    return await this.debug.evaluateFunction<number>('window.go()');
   }
 }
 

extensions/cxx_debugging/tests/TestUtils.ts

@@ -35,7 +35,7 @@ export function makeURL(path: string): string {
 }
 
 export async function createWorkerPlugin(debug?: Debugger): Promise<Chrome.DevTools.LanguageExtensionPlugin> {
-  return WorkerPlugin.create([], true).then(p => {
+  return await WorkerPlugin.create([], true).then(p => {
     if (debug) {
       p.getWasmLinearMemory = debug.getWasmLinearMemory.bind(debug);
       p.getWasmLocal = debug.getWasmLocal.bind(debug);
@@ -116,52 +116,52 @@ export class TestValue implements Value {
   size: number;
   typeNames: string[];
 
-  static fromInt8(value: number, typeName: string = 'int8_t'): TestValue {
+  static fromInt8(value: number, typeName = 'int8_t'): TestValue {
     const content = new DataView(new ArrayBuffer(1));
     content.setInt8(0, value);
     return new TestValue(content, typeName);
   }
-  static fromInt16(value: number, typeName: string = 'int16_t'): TestValue {
+  static fromInt16(value: number, typeName = 'int16_t'): TestValue {
     const content = new DataView(new ArrayBuffer(2));
     content.setInt16(0, value, true);
     return new TestValue(content, typeName);
   }
-  static fromInt32(value: number, typeName: string = 'int32_t'): TestValue {
+  static fromInt32(value: number, typeName = 'int32_t'): TestValue {
     const content = new DataView(new ArrayBuffer(4));
     content.setInt32(0, value, true);
     return new TestValue(content, typeName);
   }
-  static fromInt64(value: bigint, typeName: string = 'int64_t'): TestValue {
+  static fromInt64(value: bigint, typeName = 'int64_t'): TestValue {
     const content = new DataView(new ArrayBuffer(8));
     content.setBigInt64(0, value, true);
     return new TestValue(content, typeName);
   }
-  static fromUint8(value: number, typeName: string = 'uint8_t'): TestValue {
+  static fromUint8(value: number, typeName = 'uint8_t'): TestValue {
     const content = new DataView(new ArrayBuffer(1));
     content.setUint8(0, value);
     return new TestValue(content, typeName);
   }
-  static fromUint16(value: number, typeName: string = 'uint16_t'): TestValue {
+  static fromUint16(value: number, typeName = 'uint16_t'): TestValue {
     const content = new DataView(new ArrayBuffer(2));
     content.setUint16(0, value, true);
     return new TestValue(content, typeName);
   }
-  static fromUint32(value: number, typeName: string = 'uint32_t'): TestValue {
+  static fromUint32(value: number, typeName = 'uint32_t'): TestValue {
     const content = new DataView(new ArrayBuffer(4));
     content.setUint32(0, value, true);
     return new TestValue(content, typeName);
   }
-  static fromUint64(value: bigint, typeName: string = 'uint64_t'): TestValue {
+  static fromUint64(value: bigint, typeName = 'uint64_t'): TestValue {
     const content = new DataView(new ArrayBuffer(8));
     content.setBigUint64(0, value, true);
     return new TestValue(content, typeName);
   }
-  static fromFloat32(value: number, typeName: string = 'float'): TestValue {
+  static fromFloat32(value: number, typeName = 'float'): TestValue {
     const content = new DataView(new ArrayBuffer(4));
     content.setFloat32(0, value, true);
     return new TestValue(content, typeName);
   }
-  static fromFloat64(value: number, typeName: string = 'double'): TestValue {
+  static fromFloat64(value: number, typeName = 'double'): TestValue {
     const content = new DataView(new ArrayBuffer(8));
     content.setFloat64(0, value, true);
     return new TestValue(content, typeName);

front_end/core/common/Color.ts

@@ -65,7 +65,7 @@ function normalizeHue(hue: number): number {
 // and returns the canonicalized `degree`.
 function parseAngle(angleText: string): number|null {
   const angle = angleText.replace(/(deg|g?rad|turn)$/, '');
-  // @ts-ignore: isNaN can accept strings
+  // @ts-expect-error: isNaN can accept strings
   if (isNaN(angle) || angleText.match(/\s+(deg|g?rad|turn)/)) {
     return null;
   }
@@ -337,7 +337,7 @@ function parseAlpha(value: string|undefined): number|null {
  * - 20% in range [0, 1] is 0.5
  */
 function parsePercentOrNumber(value: string, range: [number, number] = [0, 1]): number|null {
-  // @ts-ignore: isNaN can accept strings
+  // @ts-expect-error: isNaN can accept strings
   if (isNaN(value.replace('%', ''))) {
     return null;
   }
@@ -366,7 +366,7 @@ function parseRgbNumeric(value: string): number|null {
 
 export function parseHueNumeric(value: string): number|null {
   const angle = value.replace(/(deg|g?rad|turn)$/, '');
-  // @ts-ignore: isNaN can accept strings
+  // @ts-expect-error: isNaN can accept strings
   if (isNaN(angle) || value.match(/\s+(deg|g?rad|turn)/)) {
     return null;
   }
@@ -385,7 +385,7 @@ export function parseHueNumeric(value: string): number|null {
 }
 
 function parseSatLightNumeric(value: string): number|null {
-  // @ts-ignore: isNaN can accept strings
+  // @ts-expect-error: isNaN can accept strings
   if (value.indexOf('%') !== value.length - 1 || isNaN(value.replace('%', ''))) {
     return null;
   }
@@ -762,7 +762,7 @@ export class Lab implements Color {
 
   #getRGBArray(withAlpha: true): Color4DOr3D;
   #getRGBArray(withAlpha: false): Color3D;
-  #getRGBArray(withAlpha: boolean = true): Color3D|Color4DOr3D {
+  #getRGBArray(withAlpha = true): Color3D|Color4DOr3D {
     const params = ColorConverter.xyzd50ToSrgb(...this.#toXyzd50());
     if (withAlpha) {
       return [...params, this.alpha ?? undefined];
@@ -899,7 +899,7 @@ export class LCH implements Color {
 
   #getRGBArray(withAlpha: true): Color4DOr3D;
   #getRGBArray(withAlpha: false): Color3D;
-  #getRGBArray(withAlpha: boolean = true): Color4DOr3D|Color3D {
+  #getRGBArray(withAlpha = true): Color4DOr3D|Color3D {
     const params = ColorConverter.xyzd50ToSrgb(...this.#toXyzd50());
     if (withAlpha) {
       return [...params, this.alpha ?? undefined];
@@ -1039,7 +1039,7 @@ export class Oklab implements Color {
 
   #getRGBArray(withAlpha: true): Color4DOr3D;
   #getRGBArray(withAlpha: false): Color3D;
-  #getRGBArray(withAlpha: boolean = true): Color4DOr3D|Color3D {
+  #getRGBArray(withAlpha = true): Color4DOr3D|Color3D {
     const params = ColorConverter.xyzd50ToSrgb(...this.#toXyzd50());
     if (withAlpha) {
       return [...params, this.alpha ?? undefined];
@@ -1176,7 +1176,7 @@ export class Oklch implements Color {
 
   #getRGBArray(withAlpha: true): Color4DOr3D;
   #getRGBArray(withAlpha: false): Color3D;
-  #getRGBArray(withAlpha: boolean = true): Color4DOr3D|Color3D {
+  #getRGBArray(withAlpha = true): Color4DOr3D|Color3D {
     const params = ColorConverter.xyzd50ToSrgb(...this.#toXyzd50());
     if (withAlpha) {
       return [...params, this.alpha ?? undefined];
@@ -1336,7 +1336,7 @@ export class ColorFunction implements Color {
 
   #getRGBArray(withAlpha: true): Color4DOr3D;
   #getRGBArray(withAlpha: false): Color3D;
-  #getRGBArray(withAlpha: boolean = true): Color4DOr3D|Color3D {
+  #getRGBArray(withAlpha = true): Color4DOr3D|Color3D {
     // With color(), out-of-gamut inputs are to be used for intermediate computations
     const [p0, p1, p2] = this.#rawParams;
     const params: Color3D =
@@ -1531,7 +1531,7 @@ export class HSL implements Color {
 
   #getRGBArray(withAlpha: true): Color4DOr3D;
   #getRGBArray(withAlpha: false): Color3D;
-  #getRGBArray(withAlpha: boolean = true): Color4DOr3D|Color3D {
+  #getRGBArray(withAlpha = true): Color4DOr3D|Color3D {
     const rgb = hsl2rgb([this.h, this.s, this.l, 0]);
     if (withAlpha) {
       return [rgb[0], rgb[1], rgb[2], this.alpha ?? undefined];
@@ -1682,7 +1682,7 @@ export class HWB implements Color {
 
   #getRGBArray(withAlpha: true): Color4DOr3D;
   #getRGBArray(withAlpha: false): Color3D;
-  #getRGBArray(withAlpha: boolean = true): Color4DOr3D|Color3D {
+  #getRGBArray(withAlpha = true): Color4DOr3D|Color3D {
     const rgb = hwb2rgb([this.h, this.w, this.b, 0]);
     if (withAlpha) {
       return [rgb[0], rgb[1], rgb[2], this.alpha ?? undefined];
@@ -2200,9 +2200,9 @@ export class Legacy implements Color {
   }
 }
 
-export const Regex: RegExp =
+export const Regex =
     /((?:rgba?|hsla?|hwba?|lab|lch|oklab|oklch|color)\([^)]+\)|#[0-9a-fA-F]{8}|#[0-9a-fA-F]{6}|#[0-9a-fA-F]{3,4}|\b[a-zA-Z]+\b(?!-))/g;
-export const ColorMixRegex: RegExp = /color-mix\(.*,\s*(?<firstColor>.+)\s*,\s*(?<secondColor>.+)\s*\)/g;
+export const ColorMixRegex = /color-mix\(.*,\s*(?<firstColor>.+)\s*,\s*(?<secondColor>.+)\s*\)/g;
 
 const COLOR_TO_RGBA_ENTRIES: Array<readonly[string, number[]]> = [
   ['aliceblue', [240, 248, 255]],

front_end/core/common/ColorConverter.ts

@@ -66,7 +66,7 @@ class TransferFunction {
   e: number;
   f: number;
 
-  constructor(g: number, a: number, b: number = 0, c: number = 0, d: number = 0, e: number = 0, f: number = 0) {
+  constructor(g: number, a: number, b = 0, c = 0, d = 0, e = 0, f = 0) {
     this.g = g;
     this.a = a;
     this.b = b;

front_end/core/common/ResolverBase.ts

@@ -28,7 +28,7 @@ export abstract class ResolverBase<Id, T> {
   async waitFor(id: Id): Promise<T> {
     const obj = this.getForId(id);
     if (!obj) {
-      return this.getOrCreatePromise(id);
+      return await this.getOrCreatePromise(id);
     }
     return obj;
   }

front_end/core/common/Revealer.ts

@@ -164,7 +164,7 @@ export function registerRevealer<T>(registration: RevealerRegistration<T>): void
  * @param revealable the object to reveal.
  * @param omitFocus whether to omit focusing on the presentation of `revealable` afterwards.
  */
-export async function reveal(revealable: unknown, omitFocus: boolean = false): Promise<void> {
+export async function reveal(revealable: unknown, omitFocus = false): Promise<void> {
   await RevealerRegistry.instance().reveal(revealable, omitFocus);
 }