Skip to content

Commit d418e11

Browse files
jackfranklinDevtools-frontend LUCI CQ
authored andcommitted
RPP: add visual logging to Insights "Ask AI" button
Fixed: 402654388 Change-Id: I8f0f5412f9a7ebcf8b7c5f304d231f69dcfe936d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6345599 Commit-Queue: Jack Franklin <[email protected]> Reviewed-by: Wolfgang Beyer <[email protected]> Auto-Submit: Jack Franklin <[email protected]> Commit-Queue: Wolfgang Beyer <[email protected]>
1 parent f6c6306 commit d418e11

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

front_end/panels/timeline/components/insights/BaseInsightComponent.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ export abstract class BaseInsightComponent<T extends InsightModel> extends HTMLE
333333
.variant=${Buttons.Button.Variant.OUTLINED}
334334
.iconName=${'smart-assistant'}
335335
data-insights-ask-ai
336+
jslog=${VisualLogging.action(`timeline.insight-ask-ai.${this.internalName}`).track({click: true})}
336337
@click=${this.#askAIButtonClick}
337338
>Ask AI</devtools-button>
338339
</div>

front_end/ui/visual_logging/KnownContextValues.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3539,6 +3539,22 @@ export const knownContextValues = new Set([
35393539
'timeline.ignore-list-new-regex.text',
35403540
'timeline.ignore-list-pattern',
35413541
'timeline.ignore-list-pattern.remove',
3542+
'timeline.insight-ask-ai.cls-culprits',
3543+
'timeline.insight-ask-ai.dismiss-field-mismatch',
3544+
'timeline.insight-ask-ai.document-latency',
3545+
'timeline.insight-ask-ai.dom-size',
3546+
'timeline.insight-ask-ai.field-mismatch',
3547+
'timeline.insight-ask-ai.font-display',
3548+
'timeline.insight-ask-ai.forced-reflow',
3549+
'timeline.insight-ask-ai.image-delivery',
3550+
'timeline.insight-ask-ai.inp',
3551+
'timeline.insight-ask-ai.lcp-by-phase',
3552+
'timeline.insight-ask-ai.lcp-discovery',
3553+
'timeline.insight-ask-ai.long-critical-network-tree',
3554+
'timeline.insight-ask-ai.render-blocking-requests',
3555+
'timeline.insight-ask-ai.slow-css-selector',
3556+
'timeline.insight-ask-ai.third-parties',
3557+
'timeline.insight-ask-ai.viewport',
35423558
'timeline.insights-tab',
35433559
'timeline.insights.cls-culprits',
35443560
'timeline.insights.dismiss-field-mismatch',

0 commit comments

Comments
 (0)