Skip to content

Commit d526dcb

Browse files
Marcel PützDevtools-frontend LUCI CQ
authored andcommitted
Add center position fallback for rich tooltips
Before: http://b/402683575#attachment63715341 Demo: http://b/402683575#attachment63715342 Change-Id: I4187e2aca34130243f2f2e5983013fda253f1ff0 Bug: https://issues.chromium.org/402683575 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6345658 Reviewed-by: Kim-Anh Tran <[email protected]> Commit-Queue: Marcel Pütz <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]>
1 parent 7400d95 commit d526dcb

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

front_end/ui/components/docs/tooltip/basic.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Lit.render(
4141
id="removable"
4242
@click=${() => document.getElementById('removable')?.remove()}
4343
class="anchor"
44+
aria-details="programatic"
4445
style="position: absolute; left: 16px; top: 216px;"
4546
>
4647
Click to remove anchor

front_end/ui/components/tooltips/tooltip.css

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
position-area: bottom;
1616
position-visibility: anchors-visible;
1717
justify-self: anchor-center;
18-
position-try-fallbacks: flip-inline, flip-block, flip-inline flip-block;
18+
position-try-fallbacks: flip-block;
1919

2020
& .container {
2121
width: max-content;
@@ -33,7 +33,7 @@
3333
justify-self: unset;
3434
margin: 0 var(--tooltip-viewport-distance) var(--tooltip-viewport-distance) 0;
3535
position-area: bottom span-right;
36-
position-try-fallbacks: --bottom-left, --top-right, --top-left;
36+
position-try-fallbacks: --bottom-left, --bottom-center, --top-right, --top-left, --top-center;
3737

3838
& .container {
3939
margin-inline: 0;
@@ -59,3 +59,15 @@
5959
position-area: top span-left;
6060
margin: var(--tooltip-viewport-distance) 0 0 var(--tooltip-viewport-distance);
6161
}
62+
63+
@position-try --bottom-center {
64+
justify-self: anchor-center;
65+
position-area: bottom;
66+
margin: 0 var(--tooltip-viewport-distance) var(--tooltip-viewport-distance) var(--tooltip-viewport-distance);
67+
}
68+
69+
@position-try --top-center {
70+
justify-self: anchor-center;
71+
position-area: top;
72+
margin: var(--tooltip-viewport-distance) var(--tooltip-viewport-distance) 0 var(--tooltip-viewport-distance);
73+
}

0 commit comments

Comments
 (0)