Enable DeferRendererTasksAfterInput

With DeferRendererTasksAfterInput shipping in Chrome by default, there
is no guarantee that that all triggered by the CDP input (for example,
Input.dispatchMouseEvent) will be processed before the next task (for
example, Runtime.evaluate) runs. This makes the tests that do not wait
for the expected page state to become more flaky if the input task was
delayed.

Tests like these should be treated as other flaky tests and either fixed
or disabled for investigation.

Bug: 361078921
Change-Id: I4002b9014e0af1576d5d319c67663b2087a86007
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6226408
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>

Author: OrKoN

test/conductor/hooks.ts

@@ -75,7 +75,6 @@ function launchChrome() {
   ];
 
   const disabledFeatures = [
-    'DeferRendererTasksAfterInput',                // crbug.com/361078921
     'PMProcessPriorityPolicy',                     // crbug.com/361252079
     'MojoChannelAssociatedSendUsesRunOrPostTask',  // crbug.com/376228320
     'RasterInducingScroll',                        // crbug.com/381055647

test/e2e/console/console-eval-global_test.ts

@@ -8,7 +8,8 @@ import {click, getBrowserAndPages, pasteText, step} from '../../shared/helper.js
 import {CONSOLE_TAB_SELECTOR, focusConsolePrompt, getCurrentConsoleMessages} from '../helpers/console-helpers.js';
 
 describe('The Console Tab', () => {
-  it('interacts with the global scope correctly', async () => {
+  // Flaky with crbug.com/361078921
+  it.skip('[crbug.com/361078921]: interacts with the global scope correctly', async () => {
     const {frontend} = getBrowserAndPages();
 
     await step('navigate to the Console tab', async () => {

test/e2e/elements/style-pane-properties_test.ts

@@ -264,7 +264,8 @@ describe('The Styles pane', () => {
         'The correct rule is displayed');
   });
 
-  it('can edit multiple constructed stylesheets', async () => {
+  // Flaky with crbug.com/361078921
+  it.skip('[crbug.com/361078921]: can edit multiple constructed stylesheets', async () => {
     await goToResourceAndWaitForStyleSection('elements/multiple-constructed-stylesheets.html');
 
     // Select div that we will remove a CSS property from.
@@ -327,7 +328,8 @@ describe('The Styles pane', () => {
     assert.deepEqual(computedStyles, ['rgb(255, 0, 0)', 'rgb(255, 0, 0)'], 'Styles are not correct after the update');
   });
 
-  it('can display and edit container queries', async () => {
+  // Flaky with crbug.com/361078921
+  it.skip('[crbug.com/361078921]: can display and edit container queries', async () => {
     await goToResourceAndWaitForStyleSection('elements/css-container-queries.html');
 
     // Select the child that has container queries.

test/e2e/helpers/performance-helpers.ts

@@ -86,9 +86,21 @@ export async function openCaptureSettings(sectionClassName: string) {
 export async function searchForComponent(frontend: puppeteer.Page, searchEntry: string) {
   await waitFor('devtools-performance-timeline-summary');
   await summonSearchBox();
+  // TODO: it should actually wait rendering to finish.
+  await frontend.evaluate(async () => {
+    await new Promise(resolve => setTimeout(resolve, 0));
+  });
   await waitFor('.search-bar');
+  // TODO: it should actually wait rendering to finish.
+  await frontend.evaluate(async () => {
+    await new Promise(resolve => setTimeout(resolve, 0));
+  });
   await frontend.keyboard.type(searchEntry);
   await frontend.keyboard.press('Tab');
+  // TODO: it should actually wait rendering to finish.
+  await frontend.evaluate(async () => {
+    await new Promise(resolve => setTimeout(resolve, 0));
+  });
   await expectVeEvents([
     veKeyDown(''),
     veImpressionsUnder('Panel: timeline', [veImpression(

test/e2e/helpers/settings-helpers.ts

@@ -53,6 +53,16 @@ export const openSettingsTab = async (tabTitle: string) => {
   // Click on the Settings tab and wait for the panel to appear.
   await click(settingsMenuSelector);
   await waitFor(panelSelector);
+
+  const {frontend} = getBrowserAndPages();
+  // TODO: it should actually wait rendering to finish.
+  await frontend.evaluate(async () => {
+    await new Promise(resolve => setTimeout(resolve, 0));
+    await new Promise(resolve => setTimeout(resolve, 0));
+    await new Promise(resolve => setTimeout(resolve, 0));
+    await new Promise(resolve => setTimeout(resolve, 0));
+    await new Promise(resolve => setTimeout(resolve, 0));
+  });
 };
 
 export const closeSettings = async () => {

test/e2e/memory/memory_test.ts

@@ -576,7 +576,8 @@ describe('The Memory Panel', function() {
     assert.isTrue(!(await getCategoryRow('{a, b, c, d, p, q, r}', /* wait:*/ false)));
   });
 
-  it('Groups objects by constructor location', async () => {
+  // Flaky with crbug.com/361078921
+  it.skip('[crbug.com/361078921]: Groups objects by constructor location', async () => {
     await goToResource('memory/duplicated-names.html');
     await navigateToMemoryTab();
     await takeHeapSnapshot();

test/e2e/performance/wasm/performance_profiling_test.ts

@@ -132,9 +132,8 @@ describe('The Performance panel', function() {
   });
 
   // Flaky test
-  it.skipOnPlatforms(
-      ['mac'], '[crbug.com/1510890]: is able to inspect the call stack for a wasm function from the bottom up',
-      async () => {
+  it.skip(
+      '[crbug.com/1510890]: is able to inspect the call stack for a wasm function from the bottom up', async () => {
         const {frontend} = getBrowserAndPages();
         const expectedActivities = ['mainWasm', 'js-to-wasm::i', '(anonymous)', 'Run microtasks'];
 
@@ -155,9 +154,8 @@ describe('The Performance panel', function() {
       });
 
   // Flaky test
-  it.skipOnPlatforms(
-      ['mac'], '[crbug.com/1510890]: is able to inspect the call stack for a wasm function from the call tree',
-      async () => {
+  it.skip(
+      '[crbug.com/1510890]: is able to inspect the call stack for a wasm function from the call tree', async () => {
         const {frontend} = getBrowserAndPages();
         const expectedActivities = [
           'Run microtasks',

test/e2e/snippets/snippets_test.ts

@@ -28,19 +28,36 @@ describe('Snippet creation', () => {
     await openCommandMenu();
     await showSnippetsAutocompletion();
 
+    // TODO: it should actually wait rendering to finish.
+    await frontend.evaluate(async () => {
+      await new Promise(resolve => setTimeout(resolve, 0));
+    });
+
     assert.deepEqual(await getAvailableSnippets(), [
       'New snippet\u200B',
     ]);
 
     await typeText('New ');
+    // TODO: it should actually wait rendering to finish.
+    await frontend.evaluate(async () => {
+      await new Promise(resolve => setTimeout(resolve, 0));
+    });
     assert.deepEqual(await getAvailableSnippets(), [
       'New snippet\u200B',
     ]);
 
     await typeText('w');
+    // TODO: it should actually wait rendering to finish.
+    await frontend.evaluate(async () => {
+      await new Promise(resolve => setTimeout(resolve, 0));
+    });
     assert.deepEqual(await getAvailableSnippets(), []);
 
     await frontend.keyboard.press('Backspace');
+    // TODO: it should actually wait rendering to finish.
+    await frontend.evaluate(async () => {
+      await new Promise(resolve => setTimeout(resolve, 0));
+    });
     assert.deepEqual(await getAvailableSnippets(), [
       'New snippet\u200B',
     ]);

test/e2e/sources/breakpoint-csp-violations_test.ts

@@ -4,7 +4,7 @@
 
 import {assert} from 'chai';
 
-import {click, goToResource, waitForAria} from '../../shared/helper.js';
+import {click, getBrowserAndPages, goToResource, waitForAria} from '../../shared/helper.js';
 import {getPausedMessages, openSourcesPanel, PAUSE_ON_UNCAUGHT_EXCEPTION_SELECTOR} from '../helpers/sources-helpers.js';
 
 describe('Breakpoints on CSP Violation', () => {
@@ -22,6 +22,11 @@ describe('Breakpoints on CSP Violation', () => {
     assert.strictEqual(status1.statusSub, 'Trusted Type Policy Violation');
 
     await click('[aria-label="Resume script execution"]');
+    // TODO: it should actually wait rendering to finish.
+    const {frontend} = getBrowserAndPages();
+    await frontend.evaluate(async () => {
+      await new Promise(resolve => setTimeout(resolve, 0));
+    });
     const status2 = await getPausedMessages();
     assert.strictEqual(status2.statusMain, 'Paused on exception');
     assert.strictEqual(

test/e2e/sources/can-open-linear-memory-inspector_test.ts

@@ -131,6 +131,11 @@ describe('Scope View', () => {
 
       // Wait until we pause in the other worker.
       await waitFor(PAUSE_INDICATOR_SELECTOR);
+      // TODO: it should actually wait rendering to finish.
+      const {frontend} = getBrowserAndPages();
+      await frontend.evaluate(async () => {
+        await new Promise(resolve => setTimeout(resolve, 0));
+      });
       const scriptLocation = await retrieveTopCallFrameWithoutResuming();
       assert.deepEqual(scriptLocation, 'memory-worker1.rawresponse:10');
     });