[build] Add 'devtools_foundation_module'

A 'foundation module' is a ts_library targeted to both the browser and
Node.js. As such, it only supports shared EcmaScript APIs.

The CL switches over the sole existing unit test running on node.

Drive-by: Python treats the empty array as falsy. This CL also fixes
ts_library.py to add the DOM libs only if no --es-libs argument was
passed. But not if an empty array was passed explicitly.

[email protected]

Bug: 451502260
Change-Id: I107651c12ba2d60f6c0bd1e949d0a3572f1ccb83
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7079170
Reviewed-by: Alex Rudenko <[email protected]>
Auto-Submit: Simon Zünd <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>

Author: szuend

front_end/models/ai_assistance/data_formatters/BUILD.gn

@@ -2,6 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("../../../../scripts/build/ninja/devtools_module.gni")
 import("../../../../scripts/build/typescript/typescript.gni")
 
 ts_library("unittests") {
@@ -29,7 +30,7 @@ ts_library("unittests") {
   ]
 }
 
-ts_library("foundation_unittests") {
+devtools_foundation_module("foundation_unittests") {
   testonly = true
 
   sources = [ "PerformanceTraceFormatterBounds.test.ts" ]

scripts/build/ninja/devtools_module.gni

@@ -6,7 +6,7 @@ import("../../../scripts/build/typescript/typescript.gni")
 
 template("devtools_base_module") {
   ts_library(target_name) {
-    forward_variables_from(invoker, "*", ["visibility"])
+    forward_variables_from(invoker, "*", [ "visibility" ])
 
     reset_timestamps = true
 
@@ -20,6 +20,17 @@ template("devtools_module") {
   }
 }
 
+# A module that can run in any runtime we support. As such, it must only use
+# features and APIs shared across all supported runtimes.
+template("devtools_foundation_module") {
+  devtools_base_module(target_name) {
+    forward_variables_from(invoker, "*")
+
+    es_target = "es2023"
+    es_libs = []
+  }
+}
+
 template("devtools_ui_module") {
   devtools_base_module(target_name) {
     forward_variables_from(invoker, "*")
@@ -34,6 +45,7 @@ template("devtools_ui_module") {
 
 foreach(module,
         [
+          "devtools_foundation_module",
           "devtools_module",
           "devtools_ui_module",
         ]) {

scripts/build/typescript/ts_library.py

@@ -290,7 +290,8 @@ def get_relative_path_from_output_directory(file_to_resolve):
     tsconfig['compilerOptions']['outDir'] = '.'
     tsconfig['compilerOptions']['tsBuildInfoFile'] = tsbuildinfo_name
     tsconfig['compilerOptions']['target'] = opts.es_target
-    tsconfig['compilerOptions']['lib'] = (opts.es_libs or ['dom', 'dom.iterable']) + [
+    es_libs = ['dom', 'dom.iterable'] if opts.es_libs is None else opts.es_libs
+    tsconfig['compilerOptions']['lib'] = es_libs + [
         'ES2023', 'ES2024.Promise', 'ESNext.Iterator', 'ESNext.Collection',
         'ESNext.Array'
     ]