Skip to content

Commit d7968a8

Browse files
Connor ClarkDevtools-frontend LUCI CQ
authored andcommitted
[RPP] Let Legacy / Duplicated insights work w/o nav
This was an oversight that prevented these insights from working for insight sets w/o a navigation. Bug: none Change-Id: I0c707673f64198398c2eb48f32f75af9cd995362 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6758794 Auto-Submit: Connor Clark <[email protected]> Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Connor Clark <[email protected]> Commit-Queue: Paul Irish <[email protected]>
1 parent c2fc73e commit d7968a8

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

front_end/models/trace/insights/DuplicatedJavaScript.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,6 @@ function finalize(partialModel: PartialInsightModel<DuplicatedJavaScriptInsightM
6363
export function generateInsight(
6464
parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): DuplicatedJavaScriptInsightModel {
6565
const scripts = parsedTrace.Scripts.scripts.filter(script => {
66-
if (!context.navigation) {
67-
return false;
68-
}
69-
7066
if (script.frame !== context.frameId) {
7167
return false;
7268
}

front_end/models/trace/insights/LegacyJavaScript.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,6 @@ function finalize(partialModel: PartialInsightModel<LegacyJavaScriptInsightModel
7575
export function generateInsight(
7676
parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): LegacyJavaScriptInsightModel {
7777
const scripts = parsedTrace.Scripts.scripts.filter(script => {
78-
if (!context.navigation) {
79-
return false;
80-
}
81-
8278
if (script.frame !== context.frameId) {
8379
return false;
8480
}

0 commit comments

Comments
 (0)