Skip to content

Commit da885d9

Browse files
ktranDevtools-frontend LUCI CQ
authored andcommitted
[GM3Restyling] Fixing padding for list items in Ignore Listing page
With this padding fix, the selected line background spans over the entire line. Before: https://i.imgur.com/1roQoE7.png After: https://i.imgur.com/41RR1sN.png Bug: 368238837 Change-Id: I4fe1968177e0cb231fb91c9d0bd1110fd8ec7eed Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5952203 Auto-Submit: Kim-Anh Tran <[email protected]> Commit-Queue: Kateryna Prokopenko <[email protected]> Reviewed-by: Kateryna Prokopenko <[email protected]>
1 parent 9ef881c commit da885d9

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ export class FrameworkIgnoreListSettingsTab extends UI.Widget.VBox implements
160160
settingsContent.appendChild(generalExclusionGroupCard);
161161

162162
const customExclusionGroup = this.createSettingGroup();
163+
customExclusionGroup.classList.add('custom-exclusion-group');
163164
const customExclusionGroupCard = new Cards.Card.Card();
164165
customExclusionGroupCard.classList.add('ignore-list-options');
165166
customExclusionGroupCard.data = {

front_end/panels/settings/frameworkIgnoreListSettingsTab.css

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
}
1616

1717
.add-button {
18-
margin: 10px 2px;
18+
padding: var(--sys-size-5) var(--sys-size-6);
1919
align-self: flex-start;
2020
flex: none;
2121
}
@@ -24,9 +24,14 @@
2424
flex: 0 1 auto;
2525
}
2626

27+
.custom-exclusion-group {
28+
padding-left: 0;
29+
padding-right: 0;
30+
}
31+
2732
.ignore-list-item {
28-
padding: 3px 5px;
29-
height: 30px;
33+
padding: var(--sys-size-3) var(--sys-size-5);
34+
height: var(--sys-size-13);
3035
display: flex;
3136
align-items: center;
3237
position: relative;

0 commit comments

Comments
 (0)