Skip to content

Commit da8bc2c

Browse files
wolfibDevtools-frontend LUCI CQ
authored andcommitted
[Patch agent] Improve select workspace dialog styling
Screenshots: https://imgur.com/a/aEsR9OE Bug: 404162234 Change-Id: I90c00f2b8aa382f26f96dcd387600c4e55d980b1 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6369054 Commit-Queue: Ergün Erdoğmuş <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]> Auto-Submit: Wolfgang Beyer <[email protected]>
1 parent dd60321 commit da8bc2c

File tree

2 files changed

+29
-16
lines changed

2 files changed

+29
-16
lines changed

front_end/panels/ai_assistance/SelectWorkspaceDialog.ts

Lines changed: 25 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,15 @@ const UIStringsNotTranslate = {
3232
*@description Button text for adding a workspace folder.
3333
*/
3434
addFolder: 'Add folder',
35+
/*
36+
*@description Explanation for selecting the correct workspace folder.
37+
*/
38+
selectProjectRoot:
39+
'To save patches directly to your project, select the project root folder containing the source files of the inspected page.',
3540
/*
3641
*@description Explainer stating that selected folder's contents are being sent to Google.
3742
*/
38-
sourceCodeSent:
39-
'To save patches directly to your project, select the project root folder containing the source files of the inspected page. Relevant code snippets will be sent to Google to generate code suggestions.'
43+
sourceCodeSent: 'Relevant code snippets will be sent to Google to generate code suggestions.'
4044
} as const;
4145

4246
const lockedString = i18n.i18n.lockedString;
@@ -89,20 +93,25 @@ export class SelectWorkspaceDialog extends UI.Widget.VBox {
8993
render(
9094
html`
9195
<div class="dialog-header">${lockedString(UIStringsNotTranslate.selectFolder)}</div>
92-
<div class="main-content">${lockedString(UIStringsNotTranslate.sourceCodeSent)}</div>
93-
<ul>
94-
${input.projects.map((project, index) => {
95-
return html`
96-
<li
97-
@click=${() => input.onProjectSelected(index)}
98-
class=${index === input.selectedIndex ? 'selected' : ''}
99-
title=${project.path}
100-
>
101-
<devtools-icon class="folder-icon" .name=${'folder'}></devtools-icon>
102-
${project.name}
103-
</li>`;
104-
})}
105-
</ul>
96+
<div class="main-content">
97+
<div class="select-project-root">${lockedString(UIStringsNotTranslate.selectProjectRoot)}</div>
98+
<div>${lockedString(UIStringsNotTranslate.sourceCodeSent)}</div>
99+
</div>
100+
${input.projects.length > 0 ? html`
101+
<ul>
102+
${input.projects.map((project, index) => {
103+
return html`
104+
<li
105+
@click=${() => input.onProjectSelected(index)}
106+
class=${index === input.selectedIndex ? 'selected' : ''}
107+
title=${project.path}
108+
>
109+
<devtools-icon class="folder-icon" .name=${'folder'}></devtools-icon>
110+
${project.name}
111+
</li>`;
112+
})}
113+
</ul>
114+
` : nothing}
106115
<div class="buttons">
107116
<devtools-button
108117
title=${lockedString(UIStringsNotTranslate.cancel)}

front_end/panels/ai_assistance/selectWorkspaceDialog.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ li.selected {
6363
color: var(--icon-file-authored);
6464
}
6565

66+
.select-project-root {
67+
margin-bottom: var(--sys-size-6);
68+
}
69+
6670
.theme-with-dark-background, :host-context(.theme-with-dark-background) {
6771
li.selected, .selected .folder-icon {
6872
color: var(--app-color-navigation-drawer-label-selected);

0 commit comments

Comments
 (0)