Skip to content

Commit daca806

Browse files
paulirishDevtools-frontend LUCI CQ
authored andcommitted
RPP: Fix category summary overflow bugs
Change-Id: I6bad643cb59b785c6e694d97ce52c89ccb535eb8 Bug: 394613588 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6235948 Commit-Queue: Adriana Ixba <[email protected]> Auto-Submit: Paul Irish <[email protected]> Reviewed-by: Adriana Ixba <[email protected]>
1 parent c1861e8 commit daca806

File tree

2 files changed

+19
-11
lines changed

2 files changed

+19
-11
lines changed

front_end/panels/timeline/components/timelineSummary.css

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,21 @@
55
*/
66

77
:host {
8-
display: contents;
8+
max-height: 100%;
9+
overflow: hidden auto;
10+
scrollbar-width: thin; /* ~11px wide reserved for gutter */
911
}
1012

1113
.timeline-summary {
1214
font-size: var(--sys-typescale-body4-size);
13-
display: flex;
1415
flex-direction: column;
1516
padding: 0 var(--sys-size-6) var(--sys-size-4) var(--sys-size-8) ;
16-
gap: 2px;
17-
min-width: 192px;
18-
1917
}
2018

2119
.summary-range {
2220
font-weight: var(--ref-typeface-weight-medium);
23-
height: 23px;
24-
line-height: 21px;
25-
padding-top: 0.5px;
21+
height: 24.5px;
22+
line-height: 22px;
2623
}
2724

2825
.category-summary {

front_end/panels/timeline/timelinePanel.css

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -559,9 +559,19 @@
559559
}
560560

561561
.timeline-details-range-summary {
562-
overflow: auto;
563562
height: 100%;
564563
margin: var(--sys-size-4) 0;
564+
565+
& > devtools-performance-timeline-summary {
566+
/* The category summary can't be more narrow than this, so we'll force a horizontal scrollbar
567+
Also this style can't be applied on the element's :host without !important, thus its here. */
568+
min-width: 192px;
569+
}
570+
}
571+
572+
/* Dont need to see insight chips in range summary */
573+
.timeline-details-range-summary + devtools-related-insight-chips {
574+
display:none;
565575
}
566576

567577
.timeline-details-chip-title > div {
@@ -660,7 +670,8 @@ devtools-performance-third-party-tree-view {
660670

661671
/* Default data-grid has this element on the edge of the rows,
662672
we don't need them for the 3P table. So for now set display to none. */
663-
.corner {
673+
.corner,
674+
&.data-grid-fits-viewport .corner {
664675
display: none;
665676
}
666677

@@ -673,7 +684,7 @@ devtools-performance-third-party-tree-view {
673684
/* See column width comments in populateColumns() */
674685
max-width: min(100%, 550px);
675686
min-width: 350px; /* Lower than this, there's not enough room for the entity name */
676-
padding: 0 var(--sys-size-8) 0 var(--sys-size-6);
687+
padding: 0 0 0 var(--sys-size-6);
677688
border-left: var(--sys-size-1) solid var(--sys-color-divider);
678689
}
679690

0 commit comments

Comments
 (0)