[RPP] Add a helper function for medium or higher priority network request

Bug: none
Change-Id: I7f30283e380fa2fd293b7f137a0420364e2cc2c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6261058
Commit-Queue: Andres Olivares <[email protected]>
Reviewed-by: Andres Olivares <[email protected]>
Auto-Submit: Nancy Li <[email protected]>

Author: Nancy Li

front_end/models/trace/helpers/Network.ts

@@ -1,7 +1,7 @@
 // Copyright 2024 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-
+import * as Protocol from '../../../generated/protocol.js';
 import type {RenderBlocking, SyntheticNetworkRequest} from '../types/TraceEvents.js';
 
 // Important: we purposefully treat `potentially_blocking` as
@@ -25,3 +25,13 @@ const NON_RENDER_BLOCKING_VALUES = new Set<RenderBlocking>([
 export function isSyntheticNetworkRequestEventRenderBlocking(event: SyntheticNetworkRequest): boolean {
   return !NON_RENDER_BLOCKING_VALUES.has(event.args.data.renderBlocking);
 }
+
+const HIGH_NETWORK_PRIORITIES = new Set<Protocol.Network.ResourcePriority>([
+  Protocol.Network.ResourcePriority.VeryHigh,
+  Protocol.Network.ResourcePriority.High,
+  Protocol.Network.ResourcePriority.Medium,
+]);
+
+export function isSyntheticNetworkRequestHighPriority(event: SyntheticNetworkRequest): boolean {
+  return HIGH_NETWORK_PRIORITIES.has(event.args.data.priority);
+}

front_end/panels/timeline/TimelineEventOverview.ts

@@ -29,7 +29,6 @@
  */
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Protocol from '../../generated/protocol.js';
 import * as Trace from '../../models/trace/trace.js';
 import * as TraceBounds from '../../services/trace_bounds/trace_bounds.js';
 import * as PerfUI from '../../ui/legacy/components/perf_ui/perf_ui.js';
@@ -79,12 +78,6 @@ export abstract class TimelineEventOverview extends PerfUI.TimelineOverviewPane.
   }
 }
 
-const HIGH_NETWORK_PRIORITIES = new Set<Protocol.Network.ResourcePriority>([
-  Protocol.Network.ResourcePriority.VeryHigh,
-  Protocol.Network.ResourcePriority.High,
-  Protocol.Network.ResourcePriority.Medium,
-]);
-
 export class TimelineEventOverviewNetwork extends TimelineEventOverview {
   #parsedTrace: Trace.Handlers.Types.ParsedTrace;
   constructor(parsedTrace: Trace.Handlers.Types.ParsedTrace) {
@@ -125,7 +118,7 @@ export class TimelineEventOverviewNetwork extends TimelineEventOverview {
     const lowPath = new Path2D();
 
     for (const request of this.#parsedTrace.NetworkRequests.byTime) {
-      const path = HIGH_NETWORK_PRIORITIES.has(request.args.data.priority) ? highPath : lowPath;
+      const path = Trace.Helpers.Network.isSyntheticNetworkRequestHighPriority(request) ? highPath : lowPath;
       const {startTime, endTime} = Trace.Helpers.Timing.eventTimingsMilliSeconds(request);
       const rectStart = Math.max(Math.floor((startTime - traceBoundsMilli.min) * scale), 0);
       const rectEnd = Math.min(Math.ceil((endTime - traceBoundsMilli.min) * scale + 1), canvasWidth);