Skip to content

Commit df8bada

Browse files
Saiv-kodesDevtools-frontend LUCI CQ
authored andcommitted
Summary: Consistent coloring in Dark Mode
Changed the getDCLEventColor() and getLoadEventColor() methods to have the colors of the "DOMContentLoaded" text and "Load" text in the Log view of the network tab match the colors of the vertical lines in the waterfall section when using dark mode. Bug: 378335071 Change-Id: Idfe9b2c1e959766493e6e49e7070fc12bc6dc07b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6097042 Reviewed-by: Wolfgang Beyer <[email protected]> Commit-Queue: Wolfgang Beyer <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]> Reviewed-by: Kim-Anh Tran <[email protected]>
1 parent 5efa3fd commit df8bada

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ Rajasekar Murugan <[email protected]>
7272
Ross Wollman <[email protected]>
7373
Royi Hagigi <[email protected]>
7474
Ryan Puhalovich <[email protected]>
75+
Satvic Dhawan <[email protected]>
7576
Sebastian Markbåge <[email protected]>
7677
Serg Kryvonos <[email protected]>
7778
Sergio Avalos <[email protected]>

front_end/panels/network/NetworkLogView.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2589,11 +2589,11 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
25892589
}
25902590

25912591
static getDCLEventColor(): string {
2592-
return '--sys-color-token-attribute-value';
2592+
return '--sys-color-blue';
25932593
}
25942594

25952595
static getLoadEventColor(): string {
2596-
return '--sys-color-token-property-special';
2596+
return '--sys-color-error';
25972597
}
25982598
}
25992599

front_end/panels/network/NetworkLogViewColumns.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -847,10 +847,10 @@ export class NetworkLogViewColumns {
847847
let color = 'transparent';
848848
switch (className) {
849849
case 'network-dcl-divider':
850-
color = '#0867CB';
850+
color = ThemeSupport.ThemeSupport.instance().getComputedValue('--sys-color-blue');
851851
break;
852852
case 'network-load-divider':
853-
color = '#B31412';
853+
color = ThemeSupport.ThemeSupport.instance().getComputedValue('--sys-color-error');
854854
break;
855855
default:
856856
return;

0 commit comments

Comments
 (0)