[eslint] Enforce super.willHide() and super.wasShown() calls.

For overridden `willHide()` and `wasShown()` methods, enforce that
these have corresponding super calls (as part of their body statement
list). `typescript-eslint` itself will ensure that all overridden
methods have an `override` modifier, so we don't need to worry about
that here.

Fixed: 446605678
Change-Id: I9f62ec20a0bbbb5445309b7207be667c35ca31e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7030601
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Reviewed-by: Piotr Paulski <[email protected]>

Author: bmeurer

eslint.config.mjs

@@ -646,7 +646,12 @@ export default defineConfig([
       'rulesdir/check-css-import': 'error',
       'rulesdir/enforce-optional-properties-last': 'error',
       'rulesdir/check-enumerated-histograms': 'error',
-      'rulesdir/check-was-shown-methods': 'error',
+      'rulesdir/require-super-calls-in-overridden-methods': [
+        'error',
+        {
+          methodNames: ['wasShown', 'willHide'],
+        },
+      ],
       'rulesdir/static-custom-event-names': 'error',
       'rulesdir/lit-no-attribute-quotes': 'error',
       'rulesdir/lit-template-result-or-nothing': 'error',

front_end/entrypoints/main/GlobalAiButton.ts

@@ -82,6 +82,7 @@ export class GlobalAiButton extends UI.Widget.Widget {
   }
 
   override willHide(): void {
+    super.willHide();
     this.#removeHoverEventListeners();
 
     if (this.#returnToDefaultStateTimeout) {

front_end/models/extensions/ExtensionView.ts

@@ -76,6 +76,7 @@ export class ExtensionView extends UI.Widget.Widget {
   }
 
   override willHide(): void {
+    super.willHide();
     if (typeof this.#frameIndex === 'number') {
       this.#server.notifyViewHidden(this.#id);
     }
@@ -104,10 +105,12 @@ export class ExtensionNotifierView extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.server.notifyViewShown(this.id);
   }
 
   override willHide(): void {
+    super.willHide();
     this.server.notifyViewHidden(this.id);
   }
 }

front_end/models/persistence/EditFileSystemView.ts

@@ -125,6 +125,7 @@ export class EditFileSystemView extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.#resyncExcludedFolderPaths();
     this.requestUpdate();
   }

front_end/panels/accessibility/AXBreadcrumbsPane.ts

@@ -188,6 +188,7 @@ export class AXBreadcrumbsPane extends AccessibilitySubPane {
   }
 
   override willHide(): void {
+    super.willHide();
     this.setPreselectedBreadcrumb(null);
   }
 

front_end/panels/accessibility/AccessibilitySidebarView.ts

@@ -122,6 +122,7 @@ export class AccessibilitySidebarView extends UI.ThrottledWidget.ThrottledWidget
   }
 
   override willHide(): void {
+    super.willHide();
     SDK.TargetManager.TargetManager.instance().removeModelListener(
         SDK.DOMModel.DOMModel, SDK.DOMModel.Events.AttrModified, this.onNodeChange, this);
     SDK.TargetManager.TargetManager.instance().removeModelListener(

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -727,6 +727,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   }
 
   override willHide(): void {
+    super.willHide();
     this.#aiAssistanceEnabledSetting?.removeChangeListener(this.requestUpdate, this);
     Host.AidaClient.HostConfigTracker.instance().removeEventListener(
         Host.AidaClient.Events.AIDA_AVAILABILITY_CHANGED, this.#handleAidaAvailabilityChange);

front_end/panels/ai_assistance/PatchWidget.ts

@@ -519,6 +519,7 @@ export class PatchWidget extends UI.Widget.Widget {
   }
 
   override willHide(): void {
+    super.willHide();
     this.#applyToDisconnectedAutomaticWorkspace = false;
     if (isAiAssistancePatchingEnabled()) {
       this.#workspace.removeEventListener(Workspace.Workspace.Events.ProjectAdded, this.#onProjectAdded, this);

front_end/panels/ai_assistance/SelectWorkspaceDialog.ts

@@ -183,11 +183,13 @@ export class SelectWorkspaceDialog extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.#workspace.addEventListener(Workspace.Workspace.Events.ProjectAdded, this.#onProjectAdded, this);
     this.#workspace.addEventListener(Workspace.Workspace.Events.ProjectRemoved, this.#onProjectRemoved, this);
   }
 
   override willHide(): void {
+    super.willHide();
     this.#workspace.removeEventListener(Workspace.Workspace.Events.ProjectAdded, this.#onProjectAdded, this);
     this.#workspace.removeEventListener(Workspace.Workspace.Events.ProjectRemoved, this.#onProjectRemoved, this);
   }

front_end/panels/ai_assistance/components/UserActionRow.ts

@@ -363,6 +363,7 @@ export class UserActionRow extends UI.Widget.Widget implements UserActionRowWidg
   };
 
   override willHide(): void {
+    super.willHide();
     this.#suggestionsResizeObserver.disconnect();
   }