[eslint] Speed up jslog context list

Eslint rule function `create` is called on every file.

Before: 6194.884ms | 8.0%
After:  2785.006ms | 4.1%

Percentage is from total lint time.

Bug: none
Change-Id: I0483afc481eeb4a7eb19ec4c86265a4de78379d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6420759
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Liviu Rau <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>

Author: Lightning00Blade

PRESUBMIT.py

@@ -304,15 +304,8 @@ def _CheckDevToolsLint(input_api, output_api):
     ]
 
     lint_related_files = [
-        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
-                               'eslint'),
-        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
-                               'stylelint'),
-        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
-                               '@typescript-eslint'),
         input_api.os_path.join(input_api.PresubmitLocalPath(),
                                'eslint.config.mjs'),
-        input_api.os_path.join(scripts_directory, 'eslint_rules'),
         input_api.os_path.join(input_api.PresubmitLocalPath(),
                                '.stylelintrc.json'),
         input_api.os_path.join(input_api.PresubmitLocalPath(),
@@ -324,8 +317,20 @@ def _CheckDevToolsLint(input_api, output_api):
                                'run_lint_check.mjs'),
     ]
 
-    lint_config_files = _getAffectedFiles(input_api, lint_related_files, [],
-                                          ['.js', '.py'])
+    lint_related_directories = [
+        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
+                               'eslint'),
+        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
+                               'stylelint'),
+        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
+                               '@typescript-eslint'),
+        input_api.os_path.join(scripts_directory, 'eslint_rules'),
+    ]
+
+    lint_config_files = _getAffectedFiles(
+        input_api, lint_related_directories,
+        [], [".js", ".mjs", ".ts"]) + _getAffectedFiles(
+            input_api, lint_related_files, [], [])
 
     should_bail_out, files_to_lint = _getFilesToLint(
         input_api, output_api, lint_config_files, default_linted_directories,

scripts/eslint_rules/lib/jslog-context-list.js

@@ -16,6 +16,10 @@ const LICENSE_HEADER = `// Copyright 2024 The Chromium Authors. All rights reser
 
 `;
 
+const formattedValues = new Set(
+    fs.readFileSync(ABSOLUTE_FILE_PATH, 'utf-8').split('\n').filter(l => l.startsWith('  \'')),
+);
+
 /**
  * @type {import('eslint').Rule.RuleModule}
  */
@@ -30,13 +34,8 @@ module.exports = {
     fixable: 'code',
     schema: [], // no options
   },
+  defaultOptions: [],
   create: function (context) {
-    const formattedValues = new Set(
-      fs
-        .readFileSync(ABSOLUTE_FILE_PATH, 'utf-8')
-        .split('\n')
-        .filter(l => l.startsWith('  \'')),
-    );
     const checkValue = (value, node) => {
       if (typeof value !== 'string') {
         return;

scripts/eslint_rules/tests/jslog-context-list.test.js

@@ -24,7 +24,7 @@ new RuleTester().run('jslog-context-list', rule, {
       code: `
         Lit.render(Lit.html\`
           <dialog @click=\${this.#handlePointerEvent} @pointermove=\${this.#handlePointerEvent} @cancel=\${this.#onCancel}
-                  jslog=\${VisualLogging.dialog('uNkNown').track({resize: true, keydown: 'Escape'}).parent('mapped')}>
+                  jslog=\${VisualLogging.dialog('uNkNown2').track({resize: true, keydown: 'Escape'}).parent('mapped')}>
             <div id="content-wrap">
               <div id="content">
                 <slot></slot>
@@ -36,7 +36,7 @@ new RuleTester().run('jslog-context-list', rule, {
       errors: [
         {
           message:
-              'Found jslog context value \'uNkNown\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
+              'Found jslog context value \'uNkNown2\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
         },
       ],
       filename: 'front_end/components/test.ts',
@@ -45,7 +45,7 @@ new RuleTester().run('jslog-context-list', rule, {
       code: `
         UI.ActionRegistration.registerActionExtension({
           category: UI.ActionRegistration.ActionCategory.RECORDER,
-          actionId: 'uNkNown',
+          actionId: 'uNkNown3',
           title: i18nLazyString(UIStrings.createRecording),
           async loadActionDelegate() {
             const Recorder = await loadRecorderModule();
@@ -56,7 +56,7 @@ new RuleTester().run('jslog-context-list', rule, {
       errors: [
         {
           message:
-              'Found jslog context value \'uNkNown\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
+              'Found jslog context value \'uNkNown3\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
         },
       ],
       filename: 'front_end/components/test.ts',
@@ -65,7 +65,7 @@ new RuleTester().run('jslog-context-list', rule, {
       code: `
         UI.ViewManager.registerViewExtension({
           location: UI.ViewManager.ViewLocationValues.PANEL,
-          id: 'uNkNown',
+          id: 'uNkNown4',
           commandPrompt: i18nLazyString(UIStrings.showSources),
           title: i18nLazyString(UIStrings.sources),
           order: 30,
@@ -78,7 +78,7 @@ new RuleTester().run('jslog-context-list', rule, {
       errors: [
         {
           message:
-              'Found jslog context value \'uNkNown\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
+              'Found jslog context value \'uNkNown4\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
         },
       ],
       filename: 'front_end/components/test.ts',
@@ -87,41 +87,41 @@ new RuleTester().run('jslog-context-list', rule, {
       code: `
         Common.Settings.registerSettingExtension({
           storageType: Common.Settings.SettingStorageType.Synced,
-          settingName: 'uNkNown',
+          settingName: 'uNkNown5',
           settingType: Common.Settings.SettingType.REGEX,
           defaultValue: '/node_modules/|/bower_components/',
         });
             `,
       errors: [
         {
           message:
-              'Found jslog context value \'uNkNown\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
+              'Found jslog context value \'uNkNown5\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
         },
       ],
       filename: 'front_end/components/test.ts',
     },
     {
       code: `
     this.disableCaptureJSProfileSetting =
-        Common.Settings.Settings.instance().createSetting('uNkNown', false);
+        Common.Settings.Settings.instance().createSetting('uNkNown6', false);
             `,
       errors: [
         {
           message:
-              'Found jslog context value \'uNkNown\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
+              'Found jslog context value \'uNkNown6\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
         },
       ],
       filename: 'front_end/components/test.ts',
     },
     {
       code: `
         contextMenu.defaultSection().appendItem(
-            i18nString(UIStrings.refresh), this.refreshCallback.bind(this), {jslogContext: 'uNkNown'});
+            i18nString(UIStrings.refresh), this.refreshCallback.bind(this), {jslogContext: 'uNkNown7'});
             `,
       errors: [
         {
           message:
-              'Found jslog context value \'uNkNown\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
+              'Found jslog context value \'uNkNown7\' that is not listed in front_end/ui/visual_logging/KnownContextValues.ts',
         },
       ],
       filename: 'front_end/components/test.ts',