[cleanup] Pass StreamingContentData directly to private helper

... and make the helper truly private. This alleviates the need for
the helper to be async and also removes one unnecessary check.

[email protected]

Bug: 375546679
Change-Id: I53241f1488620e05e99ab21465f07bc641b916ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5979750
Reviewed-by: Philip Pfaffe <[email protected]>
Auto-Submit: Simon Zünd <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>

Author: szuend

front_end/panels/network/RequestResponseView.ts

@@ -63,18 +63,14 @@ export class RequestResponseView extends UI.Widget.VBox {
     this.contentViewPromise = null;
   }
 
-  static async sourceViewForRequest(request: SDK.NetworkRequest.NetworkRequest): Promise<UI.Widget.Widget|null> {
+  static #sourceViewForRequest(
+      request: SDK.NetworkRequest.NetworkRequest,
+      contentData: TextUtils.StreamingContentData.StreamingContentData): UI.Widget.Widget|null {
     let sourceView = requestToSourceView.get(request);
     if (sourceView !== undefined) {
       return sourceView;
     }
 
-    const contentData = await request.requestStreamingContent();
-    if (TextUtils.StreamingContentData.isError(contentData)) {
-      requestToSourceView.delete(request);
-      return null;
-    }
-
     let mimeType;
     // If the main document is of type JSON (or any JSON subtype), do not use the more generic canonical MIME type,
     // which would prevent the JSON from being pretty-printed. See https://crbug.com/406900
@@ -126,7 +122,7 @@ export class RequestResponseView extends UI.Widget.VBox {
       return new UI.EmptyWidget.EmptyWidget(i18nString(UIStrings.failedToLoadResponseData) + ': ' + contentData.error);
     }
 
-    const sourceView = await RequestResponseView.sourceViewForRequest(this.request);
+    const sourceView = RequestResponseView.#sourceViewForRequest(this.request, contentData);
     if (!sourceView || this.request.statusCode === 204) {
       return new UI.EmptyWidget.EmptyWidget(i18nString(UIStrings.thisRequestHasNoResponseData));
     }