[DevTools] Support base::feature for port and scheme OBC in DevTools UI

This feature will only be shown when kEnableSchemeBoundCookies
or kEnablePortBoundCookies are enabled
Corresponding Chromium CL: https://crrev.com/c/5980600

Bug: 375571828
Change-Id: I3ce60a22bfcb88ccc2c4b6b2b79df86ab5fb5bf0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5979651
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Amarjot Gill <[email protected]>
Reviewed-by: Wolfgang Beyer <[email protected]>

Author: amarjotgill

front_end/core/host/InspectorFrontendHost.ts

@@ -429,6 +429,10 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
       devToolsPrivacyUI: {
         enabled: false,
       },
+      devToolsEnableOriginBoundCookies: {
+        portBindingEnabled: false,
+        schemeBindingEnabled: false,
+      },
       isOffTheRecord: false,
     };
     if ('hostConfigForTesting' in globalThis) {

front_end/core/root/Runtime.ts

@@ -365,6 +365,11 @@ export interface HostConfigPrivacyUI {
   enabled: boolean;
 }
 
+export interface HostConfigEnableOriginBoundCookies {
+  portBindingEnabled: boolean;
+  schemeBindingEnabled: boolean;
+}
+
 // We use `RecursivePartial` here to enforce that DevTools code is able to
 // handle `HostConfig` objects of an unexpected shape. This can happen if
 // the implementation in the Chromium backend is changed without correctly
@@ -386,6 +391,7 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
    * or guest mode, rather than a "normal" profile.
    */
   isOffTheRecord: boolean,
+  devToolsEnableOriginBoundCookies: HostConfigEnableOriginBoundCookies,
 }>;
 
 /**

front_end/testing/EnvironmentHelpers.ts

@@ -546,6 +546,11 @@ export function getGetHostConfigStub(config: Root.Runtime.HostConfig): sinon.Sin
       enabled: false,
       ...config.devToolsPrivacyUI,
     } as Root.Runtime.HostConfigPrivacyUI,
+    devToolsEnableOriginBoundCookies: {
+      portBindingEnabled: false,
+      schemeBindingEnabled: false,
+      ...config.devToolsEnableOriginBoundCookies,
+    } as Root.Runtime.HostConfigEnableOriginBoundCookies,
     isOffTheRecord: false,
   });
 }

front_end/ui/legacy/components/cookie_table/CookiesTable.ts

@@ -35,7 +35,6 @@
 import * as Common from '../../../../core/common/common.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
 import * as Platform from '../../../../core/platform/platform.js';
-import * as Root from '../../../../core/root/root.js';
 import * as SDK from '../../../../core/sdk/sdk.js';
 import * as Protocol from '../../../../generated/protocol.js';
 import * as IssuesManager from '../../../../models/issues_manager/issues_manager.js';
@@ -237,7 +236,8 @@ export class CookiesTable extends UI.Widget.VBox {
       },
     ] as DataGrid.DataGrid.ColumnDescriptor[];
 
-    if (Root.Runtime.experiments.isEnabled('experimental-cookie-features')) {
+    const config = Common.Settings.Settings.instance().getHostConfig();
+    if (config.devToolsEnableOriginBoundCookies?.schemeBindingEnabled) {
       const additionalColumns = [
         {
           id: SDK.Cookie.Attribute.SOURCE_SCHEME,
@@ -247,6 +247,11 @@ export class CookiesTable extends UI.Widget.VBox {
           weight: 7,
           editable,
         },
+      ] as DataGrid.DataGrid.ColumnDescriptor[];
+      columns.push(...additionalColumns);
+    }
+    if (config.devToolsEnableOriginBoundCookies?.portBindingEnabled) {
+      const additionalColumns = [
         {
           id: SDK.Cookie.Attribute.SOURCE_PORT,
           title: 'SourcePort',