Skip to content

Commit e4848cf

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
devtools-ci-autoroll-builder
authored and
Devtools-frontend LUCI CQ
committed
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8721362916211544545 [email protected] Bug: none Change-Id: Ie07941a556f632a132e54a3483bf0083dcf21db2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6321007 Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Simon Zünd <[email protected]>
1 parent 79830ea commit e4848cf

File tree

9 files changed

+28
-40
lines changed

9 files changed

+28
-40
lines changed

‎DEPS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '940abfc668be2591483f7132145593c6a047f3cf',
2525

2626
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : '42b800fc7b9cf7970eae4a11f645e54f92645250',
27+
'chromium_browser_protocol_revision' : '0fb1943c7cf7231728f4d5b3d5f6c6b5c3f22156',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

‎front_end/generated/InspectorBackendCommands.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎front_end/generated/SupportedCSSProperties.js‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,6 @@ export const generatedProperties = [
752752
"view-timeline-axis",
753753
"view-timeline-inset",
754754
"view-timeline-name",
755-
"view-transition-capture-mode",
756755
"view-transition-class",
757756
"view-transition-group",
758757
"view-transition-name",
@@ -4386,13 +4385,6 @@ export const generatedProperties = [
43864385
{
43874386
"name": "view-timeline-name"
43884387
},
4389-
{
4390-
"keywords": [
4391-
"flat",
4392-
"layered"
4393-
],
4394-
"name": "view-transition-capture-mode"
4395-
},
43964388
{
43974389
"keywords": [
43984390
"none"
@@ -6613,12 +6605,6 @@ export const generatedPropertyValues = {
66136605
"middle"
66146606
]
66156607
},
6616-
"view-transition-capture-mode": {
6617-
"values": [
6618-
"flat",
6619-
"layered"
6620-
]
6621-
},
66226608
"view-transition-class": {
66236609
"values": [
66246610
"none"

‎front_end/generated/protocol.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8833,6 +8833,7 @@ export namespace Network {
88338833
PreflightMissingPrivateNetworkAccessName = 'PreflightMissingPrivateNetworkAccessName',
88348834
PrivateNetworkAccessPermissionUnavailable = 'PrivateNetworkAccessPermissionUnavailable',
88358835
PrivateNetworkAccessPermissionDenied = 'PrivateNetworkAccessPermissionDenied',
8836+
LocalNetworkAccessPermissionDenied = 'LocalNetworkAccessPermissionDenied',
88368837
}
88378838

88388839
export interface CorsErrorStatus {
@@ -9665,6 +9666,7 @@ export namespace Network {
96659666
WarnFromInsecureToMorePrivate = 'WarnFromInsecureToMorePrivate',
96669667
PreflightBlock = 'PreflightBlock',
96679668
PreflightWarn = 'PreflightWarn',
9669+
PermissionBlock = 'PermissionBlock',
96689670
}
96699671

96709672
export const enum IPAddressSpace {

‎front_end/models/issues_manager/CorsIssue.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ export const enum IssueCode {
4646
PREFLIGHT_MISSING_PRIVATE_NETWORK_ACCESS_NAME = 'CorsIssue::PreflightMissingPrivateNetworkAccessName',
4747
PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE = 'CorsIssue::PrivateNetworkAccessPermissionUnavailable',
4848
PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED = 'CorsIssue::PrivateNetworkAccessPermissionDenied',
49+
LOCAL_NETWORK_ACCESS_PERMISSION_DENIED = 'CorsIssue::LocalNetworkAccessPermissionDenied',
4950
}
5051

5152
function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
@@ -105,6 +106,8 @@ function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
105106
return IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE;
106107
case Protocol.Network.CorsError.PrivateNetworkAccessPermissionDenied:
107108
return IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED;
109+
case Protocol.Network.CorsError.LocalNetworkAccessPermissionDenied:
110+
return IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED;
108111
}
109112
}
110113

@@ -249,6 +252,7 @@ export class CorsIssue extends Issue<IssueCode> {
249252
case IssueCode.UNEXPECTED_PRIVATE_NETWORK_ACCESS:
250253
case IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE:
251254
case IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED:
255+
case IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED:
252256
return null;
253257
}
254258
}

‎front_end/panels/issues/CorsIssueDetailsView.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,9 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
223223
IssuesManager.CorsIssue.IssueCode.PREFLIGHT_INVALID_ALLOW_EXTERNAL|
224224
IssuesManager.CorsIssue.IssueCode.INVALID_PRIVATE_NETWORK_ACCESS|
225225
IssuesManager.CorsIssue.IssueCode.UNEXPECTED_PRIVATE_NETWORK_ACCESS|IssuesManager
226-
.CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE|
227-
IssuesManager.CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED>(issueCode);
226+
.CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE|IssuesManager
227+
.CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED|
228+
IssuesManager.CorsIssue.IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED>(issueCode);
228229
}
229230

230231
this.affectedResources.appendChild(header);
@@ -477,8 +478,9 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
477478
IssuesManager.CorsIssue.IssueCode.PREFLIGHT_INVALID_ALLOW_EXTERNAL|
478479
IssuesManager.CorsIssue.IssueCode.INVALID_PRIVATE_NETWORK_ACCESS|
479480
IssuesManager.CorsIssue.IssueCode.UNEXPECTED_PRIVATE_NETWORK_ACCESS|IssuesManager
480-
.CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE|
481-
IssuesManager.CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED>(issueCode);
481+
.CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE|IssuesManager
482+
.CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED|
483+
IssuesManager.CorsIssue.IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED>(issueCode);
482484
break;
483485
}
484486

‎third_party/blink/public/devtools_protocol/browser_protocol.json‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13294,7 +13294,8 @@
1329413294
"PreflightMissingPrivateNetworkAccessId",
1329513295
"PreflightMissingPrivateNetworkAccessName",
1329613296
"PrivateNetworkAccessPermissionUnavailable",
13297-
"PrivateNetworkAccessPermissionDenied"
13297+
"PrivateNetworkAccessPermissionDenied",
13298+
"LocalNetworkAccessPermissionDenied"
1329813299
]
1329913300
},
1330013301
{
@@ -14378,7 +14379,8 @@
1437814379
"BlockFromInsecureToMorePrivate",
1437914380
"WarnFromInsecureToMorePrivate",
1438014381
"PreflightBlock",
14381-
"PreflightWarn"
14382+
"PreflightWarn",
14383+
"PermissionBlock"
1438214384
]
1438314385
},
1438414386
{

‎third_party/blink/public/devtools_protocol/browser_protocol.pdl‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6192,6 +6192,9 @@ domain Network
61926192
# Request was a private network request and is denied by user permission.
61936193
# https://github.com/WICG/private-network-access/blob/main/permission_prompt/explainer.md
61946194
PrivateNetworkAccessPermissionDenied
6195+
# Request was a local network request and is denied by user permission.
6196+
# https://github.com/explainers-by-googlers/local-network-access
6197+
LocalNetworkAccessPermissionDenied
61956198

61966199
type CorsErrorStatus extends object
61976200
properties
@@ -7383,6 +7386,7 @@ domain Network
73837386
WarnFromInsecureToMorePrivate
73847387
PreflightBlock
73857388
PreflightWarn
7389+
PermissionBlock
73867390

73877391
experimental type IPAddressSpace extends string
73887392
enum

‎third_party/blink/renderer/core/css/css_properties.json5‎

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1810,7 +1810,7 @@
18101810
{
18111811
name: "align-items",
18121812
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
1813-
field_group: "*",
1813+
field_group: "box",
18141814
field_template: "external",
18151815
include_paths: ["third_party/blink/renderer/core/style/style_self_alignment_data.h"],
18161816
default_value: "StyleSelfAlignmentData(ItemPosition::kNormal, OverflowAlignment::kDefault)",
@@ -3152,6 +3152,7 @@
31523152
property_methods: ["CSSValueFromComputedStyleInternal"],
31533153
independent: true,
31543154
inherited: true,
3155+
field_group: "*",
31553156
field_template: "keyword",
31563157
keywords: ["show", "hide"],
31573158
typedom_types: ["Keyword"],
@@ -3656,7 +3657,7 @@
36563657
{
36573658
name: "justify-content",
36583659
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
3659-
field_group: "*",
3660+
field_group: "box",
36603661
field_template: "external",
36613662
include_paths: ["third_party/blink/renderer/core/style/style_content_alignment_data.h"],
36623663
default_value: "StyleContentAlignmentData(ContentPosition::kNormal, ContentDistributionType::kDefault, OverflowAlignment::kDefault)",
@@ -4170,7 +4171,7 @@
41704171
property_methods: ["CSSValueFromComputedStyleInternal"],
41714172
field_group: "*",
41724173
field_template: "keyword",
4173-
include_paths: ["third_party/blink/renderer/platform/graphics/graphics_types.h"],
4174+
include_paths: ["third_party/blink/renderer/platform/graphics/blend_mode.h"],
41744175
keywords: [
41754176
"normal", "multiply", "screen", "overlay", "darken", "lighten",
41764177
"color-dodge", "color-burn", "hard-light", "soft-light", "difference",
@@ -4477,7 +4478,7 @@
44774478
name: "overflow-clip-margin",
44784479
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
44794480
field_template: "external",
4480-
field_group: "*",
4481+
field_group: "box",
44814482
include_paths: ["third_party/blink/renderer/core/style/style_overflow_clip_margin.h"],
44824483
keywords: ["border-box", "content-box", "padding-box"],
44834484
separator: " ",
@@ -6169,19 +6170,6 @@
61696170
converter: "ConvertViewTimelineName",
61706171
separator: ",",
61716172
},
6172-
{
6173-
name: "view-transition-capture-mode",
6174-
field_group: "*",
6175-
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
6176-
converter: "ConvertViewTransitionCaptureMode",
6177-
type_name: "StyleViewTransitionCaptureMode",
6178-
default_value: "StyleViewTransitionCaptureMode::kLayered",
6179-
field_size: 2,
6180-
field_template: "primitive",
6181-
keywords: ["flat", "layered"],
6182-
typedom_types: ["Keyword"],
6183-
runtime_flag: "ViewTransitionLayeredCapture",
6184-
},
61856173
{
61866174
name: "view-transition-class",
61876175
field_group: "*",

0 commit comments

Comments
 (0)