[RPP] Fix CPU throttling rate not saving in trace metadata

Connor Clark · Devtools-frontend LUCI CQ · commit e635a3a80fb7 · 2024-11-19T01:27:25.000Z
Fixed: 379757363 Bug: 376836355 Change-Id: I931745c993c333381dfa059bcc8d8b0e2b8a0701 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6032902 Commit-Queue: Connor Clark <cjamcl@chromium.org> Reviewed-by: Adam Raine <asraine@chromium.org>
diff --git a/front_end/panels/timeline/TimelineController.ts b/front_end/panels/timeline/TimelineController.ts
@@ -155,10 +155,10 @@ export class TimelineController implements Trace.TracingManager.TracingManagerCl
 
     this.client.loadingStarted();
     await this.waitForTracingToStop();
-    await this.allSourcesFinished();
 
     // Now we re-enable throttling again to maintain the setting being persistent.
     throttlingManager.setCPUThrottlingRate(rateDuringRecording);
+    await this.allSourcesFinished();
 
     await LiveMetrics.LiveMetrics.instance().enable();
   }

Original file line number	Diff line number	Diff line change
`@@ -155,10 +155,10 @@ export class TimelineController implements Trace.TracingManager.TracingManagerCl`
`155`	`155`
`156`	`156`	`this.client.loadingStarted();`
`157`	`157`	`await this.waitForTracingToStop();`
`158`		`- await this.allSourcesFinished();`
`159`	`158`
`160`	`159`	`// Now we re-enable throttling again to maintain the setting being persistent.`
`161`	`160`	`throttlingManager.setCPUThrottlingRate(rateDuringRecording);`
	`161`	`+ await this.allSourcesFinished();`
`162`	`162`
`163`	`163`	`await LiveMetrics.LiveMetrics.instance().enable();`
`164`	`164`	`}`