Skip to content

Commit e690e95

Browse files
Liviu RauDevtools-frontend LUCI CQ
authored andcommitted
Migrate test/e2e/issues/sab-issues_test.ts
Fixed: 416405212 Change-Id: I51ba6eee2cba1604dd90e5ff1d8f182d9b9782ea Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6725117 Auto-Submit: Liviu Rau <[email protected]> Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
1 parent 6f6c71d commit e690e95

File tree

5 files changed

+38
-41
lines changed

5 files changed

+38
-41
lines changed

test/e2e/helpers/issues-helpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export async function getAndExpandSpecificIssueByTitle(
124124
}
125125
return undefined;
126126
});
127-
await devToolsPage.clickElement(issueMessageElement);
127+
await issueMessageElement.click();
128128
await devToolsPage.waitFor('.message');
129129
return await getIssueByTitleElement(issueMessageElement);
130130
}

test/e2e/issues/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ node_ts_library("issues") {
1111
"low-text-contrast-issues_test.ts",
1212
"partitioning-blob-url-issues_test.ts",
1313
"quota-issues_test.ts",
14-
"sab-issues_test.ts",
1514
"user-reidentification-issues_test.ts",
1615
]
1716

test/e2e/issues/sab-issues_test.ts

Lines changed: 0 additions & 39 deletions
This file was deleted.

test/e2e_non_hosted/issues/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ ts_e2e_library("issues") {
2424
"privacy-sandbox-extensions-api_test.ts",
2525
"quirks-mode-issues_test.ts",
2626
"report-only_test.ts",
27+
"sab-issues_test.ts",
2728
"select-element-accessibility-issues_test.ts",
2829
]
2930
deps = [
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
// Copyright 2020 The Chromium Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import {assert} from 'chai';
6+
7+
import {
8+
ensureResourceSectionIsExpanded,
9+
getAndExpandSpecificIssueByTitle,
10+
getResourcesElement,
11+
navigateToIssuesTab,
12+
waitForTableFromResourceSectionContents,
13+
} from '../../e2e/helpers/issues-helpers.js';
14+
15+
describe('SAB issues test', () => {
16+
it('should display SharedArrayBuffer violations with the correct affected resources',
17+
async ({devToolsPage, inspectedPage}) => {
18+
await inspectedPage.goToResource('issues/sab-issue.rawresponse');
19+
await navigateToIssuesTab(devToolsPage);
20+
const issueElement = await getAndExpandSpecificIssueByTitle(
21+
'SharedArrayBuffer usage is restricted to cross-origin isolated sites', devToolsPage);
22+
assert.isNotNull(issueElement);
23+
if (issueElement) {
24+
const section = await getResourcesElement('violation', issueElement, undefined, devToolsPage);
25+
const text = await section.label.evaluate(el => el.textContent);
26+
assert.strictEqual(text, '2 violations');
27+
await ensureResourceSectionIsExpanded(section, devToolsPage);
28+
const expectedTableRows = [
29+
['Source Location', 'Trigger', 'Status'],
30+
['corp-frame.rawresponse:1', 'Instantiation', /warning|blocked/],
31+
['corp-frame.rawresponse:1', 'Transfer', /warning|blocked/],
32+
];
33+
await waitForTableFromResourceSectionContents(section.content, expectedTableRows, devToolsPage);
34+
}
35+
});
36+
});

0 commit comments

Comments
 (0)