Skip to content

Commit e6dd835

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
authored andcommitted
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8731872165123857761 [email protected] Bug: none Change-Id: Id9aa71723b61862726529b23003eca5de0e86690 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999515 Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Kim-Anh Tran <[email protected]>
1 parent 96f3a70 commit e6dd835

File tree

7 files changed

+28
-9
lines changed

7 files changed

+28
-9
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': 'a9a8758436c92515e0789e1c0ca5406b3fb87038',
2525

2626
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : 'ad53f6f3af68283efcfe6149dc9ea58aba93bbab',
27+
'chromium_browser_protocol_revision' : 'affc133e5a5412e462e08273b449ea838952e216',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '3c0acd2d4e73dd911309d9e970ba09d58bf23a62',

front_end/generated/InspectorBackendCommands.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

front_end/generated/protocol-mapping.d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1309,6 +1309,9 @@ export namespace ProtocolMapping {
13091309
* Starts tracking the given node for the computed style updates
13101310
* and whenever the computed style is updated for node, it queues
13111311
* a `computedStyleUpdated` event with throttling.
1312+
* There can only be 1 node tracked for computed style updates
1313+
* so passing a new node id removes tracking from the previous node.
1314+
* Pass `undefined` to disable tracking.
13121315
*/
13131316
'CSS.trackComputedStyleUpdatesForNode': {
13141317
paramsType: [Protocol.CSS.TrackComputedStyleUpdatesForNodeRequest?];

front_end/generated/protocol-proxy-api.d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -707,6 +707,9 @@ declare namespace ProtocolProxyApi {
707707
* Starts tracking the given node for the computed style updates
708708
* and whenever the computed style is updated for node, it queues
709709
* a `computedStyleUpdated` event with throttling.
710+
* There can only be 1 node tracked for computed style updates
711+
* so passing a new node id removes tracking from the previous node.
712+
* Pass `undefined` to disable tracking.
710713
*/
711714
invoke_trackComputedStyleUpdatesForNode(params: Protocol.CSS.TrackComputedStyleUpdatesForNodeRequest): Promise<Protocol.ProtocolResponseWithError>;
712715

front_end/generated/protocol.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8153,7 +8153,9 @@ export namespace Network {
81538153
export type LoaderId = OpaqueIdentifier<string, 'Protocol.Network.LoaderId'>;
81548154

81558155
/**
8156-
* Unique request identifier.
8156+
* Unique network request identifier.
8157+
* Note that this does not identify individual HTTP requests that are part of
8158+
* a network request.
81578159
*/
81588160
export type RequestId = OpaqueIdentifier<string, 'Protocol.Network.RequestId'>;
81598161

@@ -8906,6 +8908,7 @@ export namespace Network {
89068908
type: InitiatorType;
89078909
/**
89088910
* Initiator JavaScript stack trace, set for Script only.
8911+
* Requires the Debugger domain to be enabled.
89098912
*/
89108913
stack?: Runtime.StackTrace;
89118914
/**
@@ -16178,6 +16181,8 @@ export namespace Fetch {
1617816181

1617916182
/**
1618016183
* Unique request identifier.
16184+
* Note that this does not identify individual HTTP requests that are part of
16185+
* a network request.
1618116186
*/
1618216187
export type RequestId = OpaqueIdentifier<string, 'Protocol.Fetch.RequestId'>;
1618316188

third_party/blink/public/devtools_protocol/browser_protocol.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4889,7 +4889,7 @@
48894889
},
48904890
{
48914891
"name": "trackComputedStyleUpdatesForNode",
4892-
"description": "Starts tracking the given node for the computed style updates\nand whenever the computed style is updated for node, it queues\na `computedStyleUpdated` event with throttling.",
4892+
"description": "Starts tracking the given node for the computed style updates\nand whenever the computed style is updated for node, it queues\na `computedStyleUpdated` event with throttling.\nThere can only be 1 node tracked for computed style updates\nso passing a new node id removes tracking from the previous node.\nPass `undefined` to disable tracking.",
48934893
"experimental": true,
48944894
"parameters": [
48954895
{
@@ -12421,7 +12421,7 @@
1242112421
},
1242212422
{
1242312423
"id": "RequestId",
12424-
"description": "Unique request identifier.",
12424+
"description": "Unique network request identifier.\nNote that this does not identify individual HTTP requests that are part of\na network request.",
1242512425
"type": "string"
1242612426
},
1242712427
{
@@ -13369,7 +13369,7 @@
1336913369
},
1337013370
{
1337113371
"name": "stack",
13372-
"description": "Initiator JavaScript stack trace, set for Script only.",
13372+
"description": "Initiator JavaScript stack trace, set for Script only.\nRequires the Debugger domain to be enabled.",
1337313373
"optional": true,
1337413374
"$ref": "Runtime.StackTrace"
1337513375
},
@@ -24535,7 +24535,7 @@
2453524535
"types": [
2453624536
{
2453724537
"id": "RequestId",
24538-
"description": "Unique request identifier.",
24538+
"description": "Unique request identifier.\nNote that this does not identify individual HTTP requests that are part of\na network request.",
2453924539
"type": "string"
2454024540
},
2454124541
{

third_party/blink/public/devtools_protocol/browser_protocol.pdl

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2322,6 +2322,9 @@ experimental domain CSS
23222322
# Starts tracking the given node for the computed style updates
23232323
# and whenever the computed style is updated for node, it queues
23242324
# a `computedStyleUpdated` event with throttling.
2325+
# There can only be 1 node tracked for computed style updates
2326+
# so passing a new node id removes tracking from the previous node.
2327+
# Pass `undefined` to disable tracking.
23252328
experimental command trackComputedStyleUpdatesForNode
23262329
parameters
23272330
optional DOM.NodeId nodeId
@@ -5704,7 +5707,9 @@ domain Network
57045707
# Unique loader identifier.
57055708
type LoaderId extends string
57065709

5707-
# Unique request identifier.
5710+
# Unique network request identifier.
5711+
# Note that this does not identify individual HTTP requests that are part of
5712+
# a network request.
57085713
type RequestId extends string
57095714

57105715
# Unique intercepted request identifier.
@@ -6218,6 +6223,7 @@ domain Network
62186223
preflight
62196224
other
62206225
# Initiator JavaScript stack trace, set for Script only.
6226+
# Requires the Debugger domain to be enabled.
62216227
optional Runtime.StackTrace stack
62226228
# Initiator URL, set for Parser type or for Script type (when script is importing module) or for SignedExchange type.
62236229
optional string url
@@ -11503,6 +11509,8 @@ domain Fetch
1150311509
depends on Page
1150411510

1150511511
# Unique request identifier.
11512+
# Note that this does not identify individual HTTP requests that are part of
11513+
# a network request.
1150611514
type RequestId extends string
1150711515

1150811516
# Stages of the request to handle. Request will intercept before the request is

0 commit comments

Comments
 (0)