Skip to content

Commit e6e5b2d

Browse files
Eric LeeseDevtools-frontend LUCI CQ
authored andcommitted
Disable recorder selector picker test on mac
Bug: 383478771 Change-Id: Iabd120b329601ec7338d0a71232e49d01126b1f4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6088570 Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Eric Leese <[email protected]> Auto-Submit: Eric Leese <[email protected]> Reviewed-by: Nancy Li <[email protected]> Commit-Queue: Alex Rudenko <[email protected]>
1 parent 5aadcf5 commit e6e5b2d

File tree

1 file changed

+30
-28
lines changed

1 file changed

+30
-28
lines changed

test/e2e/recorder/ui_test.ts

Lines changed: 30 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -195,34 +195,36 @@ describe('Recorder', function() {
195195
assertRecordingMatchesSnapshot(recording);
196196
});
197197

198-
it('should select through the selector picker twice', async () => {
199-
const {target, frontend} = getBrowserAndPages();
200-
await frontend.bringToFront();
201-
await frontend.waitForSelector('pierce/.settings');
202-
203-
await target.bringToFront();
204-
const element = await target.waitForSelector(
205-
'a[href="recorder2.html"]',
206-
);
207-
await element?.click();
208-
209-
await stopRecording();
210-
211-
await expandStep(frontend, 2);
212-
await pickSelectorsForQuery('#test-button', frontend, target);
213-
214-
let recording = await getCurrentRecording();
215-
assertRecordingMatchesSnapshot(recording);
216-
217-
await pickSelectorsForQuery(
218-
'a[href="recorder.html"]',
219-
frontend,
220-
target,
221-
);
222-
223-
recording = await getCurrentRecording();
224-
assertRecordingMatchesSnapshot(recording);
225-
});
198+
// Flaky test
199+
it.skipOnPlatforms(
200+
['mac'], '[crbug.com/383478771] should select through the selector picker twice', async () => {
201+
const {target, frontend} = getBrowserAndPages();
202+
await frontend.bringToFront();
203+
await frontend.waitForSelector('pierce/.settings');
204+
205+
await target.bringToFront();
206+
const element = await target.waitForSelector(
207+
'a[href="recorder2.html"]',
208+
);
209+
await element?.click();
210+
211+
await stopRecording();
212+
213+
await expandStep(frontend, 2);
214+
await pickSelectorsForQuery('#test-button', frontend, target);
215+
216+
let recording = await getCurrentRecording();
217+
assertRecordingMatchesSnapshot(recording);
218+
219+
await pickSelectorsForQuery(
220+
'a[href="recorder.html"]',
221+
frontend,
222+
target,
223+
);
224+
225+
recording = await getCurrentRecording();
226+
assertRecordingMatchesSnapshot(recording);
227+
});
226228

227229
it('should select through the selector picker during recording', async () => {
228230
const {target, frontend} = getBrowserAndPages();

0 commit comments

Comments
 (0)