Skip to content

Commit e701790

Browse files
danilsomsikovDevtools-frontend LUCI CQ
authored andcommitted
Fix no-imperative-dom-api and no-lit-render-outside-of-view rule violations in protocol monitor
Bug: 407736287 Change-Id: I679d33b0cea605c63933becd42cd2fdbe413a87f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6421677 Reviewed-by: Benedikt Meurer <[email protected]> Auto-Submit: Danil Somsikov <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]>
1 parent b3224ac commit e701790

File tree

6 files changed

+364
-306
lines changed

6 files changed

+364
-306
lines changed

front_end/panels/protocol_monitor/JSONEditor.test.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -997,10 +997,12 @@ describeWithEnvironment('JSONEditor', () => {
997997
};
998998

999999
jsonEditor.parameters = inputParameters as ProtocolMonitor.JSONEditor.Parameter[];
1000+
await jsonEditor.updateComplete;
10001001

10011002
const promise = jsonEditor.once(ProtocolMonitor.JSONEditor.Events.SUBMIT_EDITOR);
10021003

1003-
dispatchKeyDownEvent(jsonEditor.contentElement, {key: 'Enter', ctrlKey: true, metaKey: true});
1004+
dispatchKeyDownEvent(
1005+
jsonEditor.contentElement.querySelector('.wrapper')!, {key: 'Enter', ctrlKey: true, metaKey: true});
10041006

10051007
const response = await promise;
10061008

@@ -1259,7 +1261,8 @@ describeWithEnvironment('JSONEditor', () => {
12591261
const promise = jsonEditor.once(ProtocolMonitor.JSONEditor.Events.SUBMIT_EDITOR);
12601262

12611263
// We send the command
1262-
dispatchKeyDownEvent(jsonEditor.contentElement, {key: 'Enter', ctrlKey: true, metaKey: true});
1264+
dispatchKeyDownEvent(
1265+
jsonEditor.contentElement.querySelector('.wrapper')!, {key: 'Enter', ctrlKey: true, metaKey: true});
12631266

12641267
const response = await promise;
12651268

0 commit comments

Comments
 (0)