Enable projectService for TypeScript files in eslint config

Enabling this is required for rules that need to use the types as
resolved by the TypeScript compiler.

The no-floating-promises rule was missing some stuff due to missing
types, so this CL resolves that too. Also, return-await kicked up more
stuff.

A warm run of `npm run lint` went from ~23s to ~35s on my M1 Mac.

Bug: 406518012
Change-Id: I0c413e2ca14ee903851fd8404e490335c7f8aae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397499
Reviewed-by: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Connor Clark

eslint.config.mjs

@@ -63,6 +63,8 @@ export default [
       'front_end/third_party/puppeteer-replay/**/*.ts',
       // Third party code we did not author for extensions
       'extensions/cxx_debugging/third_party/**/*',
+      // Not in tsconfig project.
+      'extension-api/ExtensionAPI.d.ts',
 
       '**/node_modules',
       'scripts/build/typescript/tests',
@@ -315,6 +317,7 @@ export default [
       parser: tsParser,
       parserOptions: {
         allowAutomaticSingleRunInference: true,
+        projectService: true,
         project: join(
           import.meta.dirname,
           'config',

extensions/cxx_debugging/e2e/TestDriver.ts

@@ -88,7 +88,7 @@ describe('CXX Debugging Extension Test Suite', function() {
               async () => ((await getPendingEvents(frontend, 'DevTools.DebuggerPaused')) || []).length > 0);
 
           const stopped = await waitFor(PAUSE_INDICATOR_SELECTOR);
-          const stoppedText = await waitForFunction(async () => stopped.evaluate(node => node.textContent));
+          const stoppedText = await waitForFunction(async () => await stopped.evaluate(node => node.textContent));
 
           assert.strictEqual(stoppedText, pausedReasonText(reason));
 
@@ -148,7 +148,8 @@ describe('CXX Debugging Extension Test Suite', function() {
 
           if (thread) {
             const threadElement = await waitFor(SELECTED_THREAD_SELECTOR);
-            const threadText = await waitForFunction(async () => threadElement.evaluate(node => node.textContent));
+            const threadText =
+                await waitForFunction(async () => await threadElement.evaluate(node => node.textContent));
             assert.include(threadText, thread, 'selected thread is not as expected');
           }
 

extensions/cxx_debugging/e2e/standalone/MemoryInspector_test.ts

@@ -39,7 +39,7 @@ describe('LinearMemoryInspector', () => {
     await waitForFunction(async () => ((await getPendingEvents(frontend, 'DevTools.DebuggerPaused')) || []).length > 0);
 
     const stopped = await waitFor(PAUSE_INDICATOR_SELECTOR);
-    const stoppedText = await waitForFunction(async () => stopped.evaluate(node => node.textContent));
+    const stoppedText = await waitForFunction(async () => await stopped.evaluate(node => node.textContent));
 
     assert.strictEqual(stoppedText, 'Paused on breakpoint');
 

test/e2e/ai_assistance/ai_assistance_test.ts

@@ -547,7 +547,7 @@ STOP`,
     await openConversationFromHistory('aria/Change the background color for this element to blue, unchecked');
     await openConversationFromHistory('aria/Change the background color for this element to green, unchecked');
 
-    frontend.waitForSelector('aria/Canceled');
+    await frontend.waitForSelector('aria/Canceled');
   });
 
   it('modifies styles to a selector with high specificity', async () => {

test/e2e/console/alert-toString-exception_test.ts

@@ -14,7 +14,7 @@ describe('The Console Tab', () => {
     await navigateToConsoleTab();
     const {target} = getBrowserAndPages();
 
-    target.reload();
+    await target.reload();
 
     const result = (await getConsoleMessages('alert-toString-exception'))[0];
     assert.strictEqual(result, 'Uncaught Exception in toString().');

test/e2e/elements/at-property-sections_test.ts

@@ -111,7 +111,7 @@ describe('The styles pane', () => {
       const section = await click('pierceShadowText/@property', {root: stylesPane});
       await waitForFunction(async () => 'true' === await section.evaluate(e => e.ariaExpanded));
       const rule = await getStyleRule('--custom-prop-4');
-      return rule.evaluate(e => !e.classList.contains('hidden'));
+      return await rule.evaluate(e => !e.classList.contains('hidden'));
     });
   });
 

test/e2e/elements/color-picker_test.ts

@@ -32,7 +32,7 @@ describe('ColorPicker', () => {
 
     await clickElement(palette);
     await waitForFunction(
-        async () => (await waitFor('.spectrum-overlay'))
+        async () => await (await waitFor('.spectrum-overlay'))
                         .evaluate(e => e.computedStyleMap().get('visibility')?.toString() === 'hidden'));
 
     await click('.spectrum-palette-switcher');

test/e2e/elements/sidebar-event-listeners-remove_test.ts

@@ -29,10 +29,11 @@ describe('Removing event listeners in the elements sidebar', () => {
     assert.include(firstListenerText, 'button#test-button');
     const removeButtonSelector = `${listenerSelector} devtools-button`;
     const removeButton = await waitFor(removeButtonSelector);
-    removeButton.evaluate(n => {
+    const buttonTitle = await removeButton.evaluate(n => {
       const button = n.shadowRoot?.querySelector('button');
-      assert.strictEqual(button?.title, 'Delete event listener');
+      return button?.title;
     });
+    assert.strictEqual(buttonTitle, 'Delete event listener');
 
     await click(removeButtonSelector);
 

test/e2e/elements/style-pane-properties_test.ts

@@ -501,7 +501,7 @@ describe('The Styles pane', () => {
     const nodeLabelName = await waitFor('.node-label-name', containerLink);
     const nodeLabelNameContent = await nodeLabelName.evaluate(node => node.textContent as string);
     assert.strictEqual(nodeLabelNameContent, 'body', 'container link name does not match');
-    containerLink.hover();
+    await containerLink.hover();
     const queriedSizeDetails = await waitFor('.queried-size-details');
     const queriedSizeDetailsContent = await queriedSizeDetails.evaluate(node => (node as HTMLElement).innerText);
     assert.strictEqual(

test/e2e/extensions/debugger-language-plugins_test.ts

@@ -1106,7 +1106,7 @@ describe('The Debugger Language Plugins', () => {
     await goToWasmResource('stepping.wasm', {autoLoadModule: true});
     await openSourcesPanel();
 
-    installEventListener(frontend, DEBUGGER_PAUSED_EVENT);
+    await installEventListener(frontend, DEBUGGER_PAUSED_EVENT);
     await locationLabels.setBreakpointInWasmAndRun('FIRST_PAUSE', 'window.Module.instance.exports.Main(16)');
     await waitFor('.paused-status');
     await locationLabels.checkLocationForLabel('FIRST_PAUSE');
@@ -1202,7 +1202,7 @@ describe('The Debugger Language Plugins', () => {
 
     await waitFor('.paused-status');
     await locationLabels.checkLocationForLabel('FIRST_PAUSE');
-    installEventListener(frontend, DEBUGGER_PAUSED_EVENT);
+    await installEventListener(frontend, DEBUGGER_PAUSED_EVENT);
     await stepOver();
     await locationLabels.checkLocationForLabel('SECOND_PAUSE');
     await stepOver();