Skip to content

Commit e817b1a

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
[cleanup] Correctly mark config as ESM
I noticed warning in the console related to this, that were causing noise to my actual error. Bug: none Change-Id: Ifd5bacb9029cea84640a074c924fb16af35f1ea4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7124062 Auto-Submit: Nikolay Vitkov <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
1 parent 54901ca commit e817b1a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

extensions/cxx_debugging/src/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ foreach(entrypoint IN LISTS EXTENSION_BUNDLE_ENTRYPOINTS)
3636
list(APPEND EXTENSION_BUNDLED_SOURCES ${CMAKE_CURRENT_BINARY_DIR}/${NAME_WE}.bundle.js)
3737
endforeach()
3838

39-
configure_file(rollup.config.in.js rollup.config.in.js @ONLY)
40-
file(GENERATE OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/rollup.config.js
41-
INPUT ${CMAKE_CURRENT_BINARY_DIR}/rollup.config.in.js)
39+
configure_file(rollup.config.in.mjs rollup.config.in.mjs @ONLY)
40+
file(GENERATE OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/rollup.config.mjs
41+
INPUT ${CMAKE_CURRENT_BINARY_DIR}/rollup.config.in.mjs)
4242

4343
add_custom_command(
4444
OUTPUT
@@ -53,7 +53,7 @@ add_custom_command(
5353
${DEVTOOLS_SOURCE_DIR}/node_modules/.bin/rollup
5454
-c --failAfterWarnings
5555
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
56-
MAIN_DEPENDENCY ${CMAKE_CURRENT_BINARY_DIR}/rollup.config.js
56+
MAIN_DEPENDENCY ${CMAKE_CURRENT_BINARY_DIR}/rollup.config.mjs
5757
DEPENDS ${TS_COMPILER_OUTPUTS}
5858
)
5959

front_end/models/live-metrics/web-vitals-injected/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22

33
[`web-vitals`](https://github.com/GoogleChrome/web-vitals-extension) is a Google-maintained library that measures CWV metrics using their canonical definition. We use it to ensure we are using consistent implementations for measuring CWV across Google. It can also measure performance metrics of the current page *after* the they happen (See [`PerformanceObserver` buffered setting](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver/observe#buffered)). See [go/cpq:rpp-metric-observations](http://go/cpq:rpp-metric-observations) for more information.
44

5-
The web-vitals library needs to be run in the target page (although it can be used in an isolated execution context). We therefore need to create a JS binary that can be injected via `Page.evaluate`/`Page.addScriptToEvaluateOnNewDocument`. See `BUILD.gn` and `rollup.config.js` for how we bundle the JS binary.
5+
The web-vitals library needs to be run in the target page (although it can be used in an isolated execution context). We therefore need to create a JS binary that can be injected via `Page.evaluate`/`Page.addScriptToEvaluateOnNewDocument`. See `BUILD.gn` and `rollup.config.mjs` for how we bundle the JS binary.

0 commit comments

Comments
 (0)