Skip to content

Commit e87f51c

Browse files
Adriana IxbaDevtools-frontend LUCI CQ
authored andcommitted
[RPP] Consolidate 3rd party naming
Third party -> 3rd party Bug:376327358 Change-Id: I01dbce5d868206c570fef120f071e34e1f298253 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6254637 Commit-Queue: Adriana Ixba <[email protected]> Reviewed-by: Jack Franklin <[email protected]>
1 parent 49d12de commit e87f51c

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

front_end/models/trace/insights/ThirdParties.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ import {
1919

2020
export const UIStrings = {
2121
/** Title of an insight that provides details about the code on a web page that the user doesn't control (referred to as "third-party code"). */
22-
title: 'Third parties',
22+
title: '3rd parties',
2323
/**
2424
* @description Description of a DevTools insight that identifies the code on the page that the user doesn't control.
2525
* This is displayed after a user expands the section to see more. No character length limits.
2626
*/
27-
description: 'Third party code can significantly impact load performance. ' +
28-
'[Reduce and defer loading of third party code](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/loading-third-party-javascript/) to prioritize your page\'s content.',
27+
description: '3rd party code can significantly impact load performance. ' +
28+
'[Reduce and defer loading of 3rd party code](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/loading-third-party-javascript/) to prioritize your page\'s content.',
2929
/** Label for a table column that displays the name of a third-party provider. */
30-
columnThirdParty: 'Third party',
30+
columnThirdParty: '3rd party',
3131
/** Label for a column in a data table; entries will be the download size of a web resource in kilobytes. */
3232
columnTransferSize: 'Transfer size',
3333
/** Label for a table column that displays how much time each row spent running on the main thread, entries will be the number of milliseconds spent. */

front_end/panels/timeline/TimelineUIUtils.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1261,9 +1261,9 @@ describeWithMockConnection('TimelineUIUtils', function() {
12611261
entityMapper,
12621262
);
12631263

1264-
const rowData = getRowDataForDetailsElement(details).find(row => row.title?.startsWith('Third'));
1264+
const rowData = getRowDataForDetailsElement(details).find(row => row.title?.startsWith('3rd'));
12651265
assert.deepEqual(rowData, {
1266-
title: 'Third party',
1266+
title: '3rd party',
12671267
value: 'Google Analytics',
12681268
});
12691269
});

front_end/panels/timeline/TimelineUIUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ const UIStrings = {
506506
/**
507507
* @description Text to refer to a 3rd Party entity.
508508
*/
509-
entity: 'Third party',
509+
entity: '3rd party',
510510
/**
511511
* @description Label for third party table.
512512
*/

front_end/panels/timeline/components/NetworkRequestDetails.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describeWithMockConnection('NetworkRequestDetails', () => {
5454
value: 'Render blocking',
5555
},
5656
{title: 'From cache', value: 'Yes'},
57-
{title: 'Third party', value: 'GitHub'},
57+
{title: '3rd party', value: 'GitHub'},
5858
{title: undefined, value: durationInnerText},
5959
{
6060
title: 'Initiated by',

front_end/panels/timeline/components/NetworkRequestDetails.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ const UIStrings = {
103103
/**
104104
* @description Text to refer to a 3rd Party entity.
105105
*/
106-
entity: 'Third party',
106+
entity: '3rd party',
107107
};
108108
const str_ = i18n.i18n.registerUIStrings('panels/timeline/components/NetworkRequestDetails.ts', UIStrings);
109109
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

front_end/panels/timeline/components/SidebarSingleInsightSet.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ describeWithEnvironment('SidebarSingleInsightSet', () => {
5959
'LCP request discovery',
6060
'Render blocking requests',
6161
'Document request latency',
62-
'Third parties',
62+
'3rd parties',
6363
'INP by phase',
6464
'Layout shift culprits',
6565
'Improve image delivery',
@@ -106,7 +106,7 @@ describeWithEnvironment('SidebarSingleInsightSet', () => {
106106
'LCP by phase',
107107
'Layout shift culprits',
108108
'Improve image delivery',
109-
'Third parties',
109+
'3rd parties',
110110
'INP by phase',
111111
'LCP request discovery',
112112
'Render blocking requests',
@@ -160,7 +160,7 @@ describeWithEnvironment('SidebarSingleInsightSet', () => {
160160
'Layout shift culprits',
161161
'Improve image delivery',
162162
'Font display',
163-
'Third parties',
163+
'3rd parties',
164164
'INP by phase',
165165
'LCP request discovery',
166166
'Render blocking requests',

0 commit comments

Comments
 (0)