[RPP] Hide insight set if there is nothing to show

Bug: 371615739
Change-Id: I8a635201f36bb34870dfb3d3105f99dab4fca1d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6037380
Reviewed-by: Adam Raine <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
Commit-Queue: Adam Raine <[email protected]>

Author: Connor Clark

front_end/models/trace/insights/CLSCulprits.ts

@@ -422,12 +422,19 @@ function getFontRootCauses(
 
 function finalize(partialModel: Omit<CLSCulpritsInsightModel, 'title'|'description'|'category'|'shouldShow'>):
     CLSCulpritsInsightModel {
+  let maxScore = 0;
+  for (const cluster of partialModel.clusters) {
+    if (cluster.clusterCumulativeScore > maxScore) {
+      maxScore = cluster.clusterCumulativeScore;
+    }
+  }
+
   return {
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),
     category: InsightCategory.CLS,
-    // TODO: getTopCulprits in component needs to move to model so this can be set here.
-    shouldShow: true,
+    // TODO: getTopCulprits in component needs to move to model so this can be set properly here.
+    shouldShow: maxScore > 0,
     ...partialModel,
   };
 }

front_end/panels/timeline/TimelinePanel.ts

@@ -1949,7 +1949,19 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
     this.#setActiveInsight(null);
 
-    const traceInsightsSets = this.#traceEngineModel.traceInsights(traceIndex);
+    let traceInsightsSets = this.#traceEngineModel.traceInsights(traceIndex);
+    if (traceInsightsSets) {
+      // Omit insight sets that don't have anything of interest to show to the user.
+      const filteredTraceInsightsSets = new Map();
+      for (const [key, insightSet] of traceInsightsSets) {
+        if (Object.values(insightSet.model).some(model => model.shouldShow)) {
+          filteredTraceInsightsSets.set(key, insightSet);
+        }
+      }
+
+      traceInsightsSets = filteredTraceInsightsSets.size ? filteredTraceInsightsSets : null;
+    }
+
     this.flameChart.setInsights(traceInsightsSets, this.#eventToRelatedInsights);
     this.#sideBar.setInsights(traceInsightsSets);