[RPP] Handle empty overlays array from insight

If `overlays` was empty, `overlaysBounds` would have bounds of
`Infinity`. This causes several error messages in the console when
expanding certain insights.

Bug: None
Change-Id: Ia9c9bfff1760c95b7b120efdd5519ce74307528b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6082494
Reviewed-by: Connor Clark <[email protected]>
Commit-Queue: Adam Raine <[email protected]>

Author: Adam Raine

front_end/panels/timeline/TimelineFlameChartView.ts

@@ -529,17 +529,19 @@ export class TimelineFlameChartView extends
 
     if (options.updateTraceWindow) {
       const overlaysBounds = Overlays.Overlays.traceWindowContainingOverlays(this.#currentInsightOverlays);
-      // Trace window covering all overlays expanded by 100% so that the overlays cover 50% of the visible window.
-      const expandedBounds =
-          Trace.Helpers.Timing.expandWindowByPercentOrToOneMillisecond(overlaysBounds, traceBounds, 100);
-
-      // Set the timeline visible window and ignore the minimap bounds. This
-      // allows us to pick a visible window even if the overlays are outside of
-      // the current breadcrumb. If this happens, the event listener for
-      // BoundsManager changes in TimelineMiniMap will detect it and activate
-      // the correct breadcrumb for us.
-      TraceBounds.TraceBounds.BoundsManager.instance().setTimelineVisibleWindow(
-          expandedBounds, {ignoreMiniMapBounds: true, shouldAnimate: true});
+      if (overlaysBounds) {
+        // Trace window covering all overlays expanded by 100% so that the overlays cover 50% of the visible window.
+        const expandedBounds =
+            Trace.Helpers.Timing.expandWindowByPercentOrToOneMillisecond(overlaysBounds, traceBounds, 100);
+
+        // Set the timeline visible window and ignore the minimap bounds. This
+        // allows us to pick a visible window even if the overlays are outside of
+        // the current breadcrumb. If this happens, the event listener for
+        // BoundsManager changes in TimelineMiniMap will detect it and activate
+        // the correct breadcrumb for us.
+        TraceBounds.TraceBounds.BoundsManager.instance().setTimelineVisibleWindow(
+            expandedBounds, {ignoreMiniMapBounds: true, shouldAnimate: true});
+      }
     }
 
     // Reveal entry if we have one.

front_end/panels/timeline/TimelinePanel.ts

@@ -580,7 +580,10 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
     this.flameChart.overlays().addEventListener(Overlays.Overlays.TimeRangeMouseOverEvent.eventName, event => {
       const {overlay} = event as Overlays.Overlays.TimeRangeMouseOverEvent;
-      const overlayBounds = overlay && Overlays.Overlays.traceWindowContainingOverlays([overlay]);
+      const overlayBounds = Overlays.Overlays.traceWindowContainingOverlays([overlay]);
+      if (!overlayBounds) {
+        return;
+      }
       this.#minimapComponent.highlightBounds(overlayBounds, /* withBracket */ false);
     });
 
@@ -602,7 +605,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
       this.flameChart.setOverlays(overlays, options);
 
-      const overlaysBounds = overlays && Overlays.Overlays.traceWindowContainingOverlays(overlays);
+      const overlaysBounds = Overlays.Overlays.traceWindowContainingOverlays(overlays);
       if (overlaysBounds) {
         this.#minimapComponent.highlightBounds(overlaysBounds, /* withBracket */ true);
       } else {

front_end/panels/timeline/overlays/OverlaysImpl.test.ts

@@ -911,9 +911,18 @@ describeWithEnvironment('Overlays', () => {
         outlineReason: 'INFO',
       };
       const traceWindow = Overlays.Overlays.traceWindowContainingOverlays([overlay1, overlay2]);
+      if (!traceWindow) {
+        throw new Error('No trace window for overlays');
+      }
+
       assert.strictEqual(traceWindow.min, 0);
       assert.strictEqual(traceWindow.max, 105);
     });
+
+    it('returns null for no overlays', () => {
+      const traceWindow = Overlays.Overlays.traceWindowContainingOverlays([]);
+      assert.isNull(traceWindow);
+    });
   });
 
   describe('jslogcontext for overlays', () => {

front_end/panels/timeline/overlays/OverlaysImpl.ts

@@ -81,12 +81,17 @@ export interface TimeRangeLabel {
 /**
  * Given a list of overlays, this method will calculate the smallest possible
  * trace window that will contain all of the overlays.
- * `overlays` is expected to be non-empty.
+ * `overlays` is expected to be non-empty, and this will return `null` if it is empty.
  */
-export function traceWindowContainingOverlays(overlays: TimelineOverlay[]): Trace.Types.Timing.TraceWindowMicroSeconds {
+export function traceWindowContainingOverlays(overlays: TimelineOverlay[]): Trace.Types.Timing.TraceWindowMicroSeconds|
+    null {
   let minTime = Trace.Types.Timing.MicroSeconds(Number.POSITIVE_INFINITY);
   let maxTime = Trace.Types.Timing.MicroSeconds(Number.NEGATIVE_INFINITY);
 
+  if (overlays.length === 0) {
+    return null;
+  }
+
   for (const overlay of overlays) {
     const windowForOverlay = traceWindowForOverlay(overlay);
     if (windowForOverlay.min < minTime) {