[build] Add 'copy_to_gen_with_grd' GN template

This CL adds a new GN template that works similar to 'copy_to_gen'
but also marks the file as included in the release GRD bundle.

This makes it also similar to the 'devtools_pre_built' but not
restricted to JS files.

Drive-by: Split the CSS color tokens off the web test runner. We are
looking into excluding the integration_test_runner.html from the
release GRD and having the CSS color tokens woven together with the
web test runner in the BUILD.gn prevents that.

[email protected]

Bug: 382387670
Change-Id: Ie1399aa07e44b418fe295eb29b1d5f609934d48f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6450344
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>

Author: szuend

front_end/BUILD.gn

@@ -10,6 +10,7 @@ import("../scripts/build/typescript/typescript.gni")
 
 group("front_end") {
   public_deps = [
+    ":color_tokens",
     ":devtools_json",
     ":embedder-scripts",
     ":html_entrypoints",
@@ -34,20 +35,15 @@ group("front_end") {
   ]
 }
 
-copy_to_gen("integration_test_runner-gen") {
+copy_to_gen_with_grd("color_tokens") {
   sources = [
     "application_tokens.css",
     "design_system_tokens.css",
-    "integration_test_runner.html",
   ]
 }
 
-group("integration_test_runner") {
-  public_deps = [ ":integration_test_runner-gen" ]
-  data_deps = public_deps
-  metadata = {
-    grd_files = get_target_outputs(":integration_test_runner-gen")
-  }
+copy_to_gen_with_grd("integration_test_runner") {
+  sources = [ "integration_test_runner.html" ]
 }
 
 node_action("devtools_json") {
@@ -99,21 +95,13 @@ node_action("html_entrypoints") {
   }
 }
 
-copy_to_gen("embedder-scripts-gen") {
+copy_to_gen_with_grd("embedder-scripts") {
   sources = [
     "Tests.js",
     "devtools_compatibility.js",
   ]
 }
 
-group("embedder-scripts") {
-  public_deps = [ ":embedder-scripts-gen" ]
-  data_deps = public_deps
-  metadata = {
-    grd_files = get_target_outputs(":embedder-scripts-gen")
-  }
-}
-
 group("unittests") {
   deps = [
     "Images:optimize_images",

front_end/emulated_devices/optimized/BUILD.gn

@@ -4,14 +4,6 @@
 import("../../../scripts/build/ninja/copy.gni")
 import("./optimized_images.gni")
 
-copy_to_gen("optimized_emulated_devices-gen") {
+copy_to_gen_with_grd("optimized_emulated_devices") {
   sources = devtools_emulated_devices_images
 }
-
-group("optimized_emulated_devices") {
-  public_deps = [ ":optimized_emulated_devices-gen" ]
-  data_deps = public_deps
-  metadata = {
-    grd_files = get_target_outputs(":optimized_emulated_devices-gen")
-  }
-}

front_end/panels/whats_new/resources/BUILD.gn

@@ -4,14 +4,6 @@
 
 import("../../../../scripts/build/ninja/copy.gni")
 
-copy_to_gen("resources-gen") {
+copy_to_gen_with_grd("whats_new_resources") {
   sources = [ "WNDT.md" ]
 }
-
-group("whats_new_resources") {
-  public_deps = [ ":resources-gen" ]
-  data_deps = public_deps
-  metadata = {
-    grd_files = get_target_outputs(":resources-gen")
-  }
-}

scripts/build/ninja/copy.gni

@@ -31,3 +31,29 @@ template("copy_to_gen") {
     }
   }
 }
+
+#
+# Same as "copy_to_gen" but includes all output files in the release GRD
+#
+template("copy_to_gen_with_grd") {
+  assert(!defined(invoker.testonly),
+         "Test resources can't be included in the release bundle!")
+
+  _copy_target = "${target_name}_gen"
+  copy_to_gen(_copy_target) {
+    forward_variables_from(invoker,
+                           [
+                             "sources",
+                             "visibility",
+                             "deps",
+                           ])
+  }
+
+  group(target_name) {
+    public_deps = [ ":$_copy_target" ]
+    data_deps = public_deps
+    metadata = {
+      grd_files = get_target_outputs(":$_copy_target")
+    }
+  }
+}