Tracing: move debug logger to TimelinePanel

Makes more sense to do it here than make models/trace do it - especially
as we want the trace engine usable in NodeJS and this code looks on
`window`.

[email protected]

Bug: none
Change-Id: Id572c1ff021eec67db860afd79bdb3df40559572
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6917686
Commit-Queue: Alex Rudenko <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>

Author: jackfranklin

front_end/models/trace/ModelImpl.ts

@@ -118,19 +118,6 @@ export class Model extends EventTarget {
         metadata,
         resolveSourceMap: config?.resolveSourceMap,
       };
-      if (!parseConfig.logger &&
-          (window.location.href.includes('devtools/bundled') || window.location.search.includes('debugFrontend'))) {
-        // Someone is debugging DevTools, enable the logger.
-        const times: Record<string, number> = {};
-        parseConfig.logger = {
-          start(id) {
-            times[id] = performance.now();
-          },
-          end(id) {
-            performance.measure(id, {start: times[id]});
-          },
-        };
-      }
       await this.#processor.parse(traceEvents, parseConfig);
       this.#storeParsedFileData(file, this.#processor.parsedTrace, this.#processor.insights);
       // We only push the file onto this.#traces here once we know it's valid

front_end/panels/timeline/TimelinePanel.ts

@@ -2733,14 +2733,27 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
   async #executeNewTrace(
       collectedEvents: Trace.Types.Events.Event[], isFreshRecording: boolean,
       metadata: Trace.Types.File.MetaData|null): Promise<void> {
-    await this.#traceEngineModel.parse(
-        collectedEvents,
-        {
-          metadata: metadata ?? undefined,
-          isFreshRecording,
-          resolveSourceMap: this.#createSourceMapResolver(isFreshRecording, metadata),
+    const config: Trace.Types.Configuration.ParseOptions = {
+      metadata: metadata ?? undefined,
+      isFreshRecording,
+      resolveSourceMap: this.#createSourceMapResolver(isFreshRecording, metadata),
+    };
+
+    if (window.location.href.includes('devtools/bundled') || window.location.search.includes('debugFrontend')) {
+      // Someone is debugging DevTools, enable the logger to give timings
+      // when tracing the performance panel itself.
+      const times: Record<string, number> = {};
+      config.logger = {
+        start(id) {
+          times[id] = performance.now();
         },
-    );
+        end(id) {
+          performance.measure(id, {start: times[id]});
+        },
+      };
+    }
+
+    await this.#traceEngineModel.parse(collectedEvents, config);
 
     // Store all source maps on the trace metadata.
     // If not fresh, we can't validate the maps are still accurate.