[cleanup] Remove duplicate test names

We should try to avoid this, but the current EsLint rule that can
do this in not very flexible.

Bug: none
Change-Id: I2367ad6362d91d965008046de261b38f13562f6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7229102
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

front_end/core/sdk/CookieParser.test.ts

@@ -101,7 +101,7 @@ describe('CookieParser', () => {
       sinon.assert.calledOnceWithExactly(stub, 'Failed getting cookie attribute: Discard');
     });
 
-    it('handles multiple cookies with an invalid attribute', () => {
+    it('handles multiple cookies with an invalid attribute for max-age', () => {
       const stub = sinon.stub(console, 'error');
       parseAndExpectSetCookies(
           `cookie1 = value; max-age= 1440; Domain   =.example.com

front_end/models/source_map_scopes/NamesResolver.test.ts

@@ -110,18 +110,13 @@ describeWithMockConnection('NameResolver', () => {
       source: 'function f(x) { let outer = x; { var b = x; return b } }',
       scopes: '          {B        BBBBB   B        B   B         B   }',
     },
-    {
-      name: 'computes identifiers with nested scopes, var lifting',
-      source: 'function f(x) { let outer = x; { var b = x; return b } }',
-      scopes: '          {B        BBBBB   B        B   B         B   }',
-    },
     {
       name: 'computes identifiers in catch clause',
       source: 'function f(x) { try { } catch (e) { let a = e + x; } }',
       scopes: '          {                   <B            B   F  > }',
     },
     {
-      name: 'computes identifiers in catch clause',
+      name: 'computes identifiers in catch clause with return',
       source: 'function f(x) { try { } catch (e) { let a = e; return a; } }',
       scopes: '          {                       <     B   F         B  > }',
     },

front_end/models/workspace/WorkspaceImpl.test.ts

@@ -109,7 +109,7 @@ describe('WorkspaceImpl', () => {
     assert.deepEqual(result, [projectStub0]);
   });
 
-  it('can return the UI source code from project type', async () => {
+  it('can return the UI source code', async () => {
     const sut = Workspace.Workspace.WorkspaceImpl.instance({forceNew: true});
     const uiSourceCodeStub = sinon.createStubInstance(Workspace.UISourceCode.UISourceCode);
     const projectStub = sinon.createStubInstance(Bindings.ContentProviderBasedProject.ContentProviderBasedProject);

front_end/panels/changes/CombinedDiffView.test.ts

@@ -69,8 +69,12 @@ describeWithEnvironment('CombinedDiffView', () => {
   beforeEach(() => {
     const workspace = createWorkspace();
     workspaceDiff = createWorkspaceDiff({workspace});
-    ({uiSourceCode} = createFileSystemUISourceCode(
-         {url: URL, content: ORIGINAL_CONTENT, mimeType: 'text/javascript', fileSystemPath: 'file:///workspace'}));
+    ({uiSourceCode} = createFileSystemUISourceCode({
+       url: URL,
+       content: ORIGINAL_CONTENT,
+       mimeType: 'text/javascript',
+       fileSystemPath: 'file:///workspace',
+     }));
   });
 
   it('should render modified UISourceCode from a workspaceDiff on initial render', async () => {

front_end/panels/elements/StylePropertyTreeElement.test.ts

@@ -2051,7 +2051,7 @@ describeWithMockConnection('StylePropertyTreeElement', () => {
       assert.strictEqual(originalText, evaluationSpy.args[0][0].textContent);
     });
 
-    it('shows the original text during tracing when evaluation fails', async () => {
+    it('should try to resolve the values for the correct property name', async () => {
       const cssModel = stylesSidebarPane.cssModel();
       assert.exists(cssModel);
       const resolveValuesStub = sinon.stub(cssModel, 'resolveValues').resolves([]);

front_end/panels/linear_memory_inspector/components/LinearMemoryViewer.test.ts

@@ -285,7 +285,7 @@ describe('LinearMemoryViewer', () => {
     assertSelectedCellIsHighlighted(component, VIEWER_ADDRESS_SELECTOR, 0);
   });
 
-  it('triggers an event on arrow down', async () => {
+  it('triggers an event on arrow left', async () => {
     const {component, data} = await setUpComponent();
     const addressBefore = data.address;
     const expectedAddress = addressBefore - 1;
@@ -329,7 +329,7 @@ describe('LinearMemoryViewer', () => {
     await assertEventTriggeredOnArrowNavigation(component, 'PageDown', expectedAddress);
   });
 
-  it('triggers an event on page down', async () => {
+  it('triggers an event on page up', async () => {
     const {component, data} = await setUpComponent();
     const addressBefore = data.address;
 

front_end/panels/network/components/RequestHeaderSection.test.ts

@@ -89,29 +89,6 @@ describeWithEnvironment('RequestHeaderSection', () => {
     assert.isTrue(highlightedHeader?.highlight);
   });
 
-  it('highlights the requested header', async () => {
-    const request = {
-      cachedInMemory: () => true,
-      cached: () => false,
-      requestHeaders: () =>
-          [{name: 'Ab', value: 'second'},
-           {name: 'test', value: 'fifth'},
-           {name: 'name', value: 'fourth'},
-           {name: 'abc', value: 'third'},
-           {name: 'aa', value: 'first'},
-    ],
-      requestHeadersText: () => 'placeholderText',
-    } as unknown as SDK.NetworkRequest.NetworkRequest;
-
-    const {view, widget} = await renderRequestHeaderSection(request);
-    widget.toReveal = {section: NetworkForward.UIRequestLocation.UIHeaderSection.REQUEST, header: 'Ab'};
-    await view.nextInput;
-
-    const headers = view.input.headers;
-    const highlightedHeader = headers.find(header => header.name === 'ab');
-    assert.isTrue(highlightedHeader?.highlight);
-  });
-
   it('correctly sets cached state', async () => {
     const request = {
       cachedInMemory: () => true,

front_end/panels/sources/BreakpointsView.test.ts

@@ -570,21 +570,21 @@ describeWithEnvironment('BreakpointsSidebarController', () => {
       assert.lengthOf(actualViewData.groups[0].breakpointItems, 1);
     });
 
-    it('correctly extracts the enabled state', async () => {
+    it('correctly extracts the enabled state for true', async () => {
       const {groups} =
           await setUpTestWithOneBreakpointLocation({file: '', lineNumber: 0, columnNumber: 0, enabled: true});
       const breakpointItem = groups[0].breakpointItems[0];
       assert.strictEqual(breakpointItem.status, Sources.BreakpointsView.BreakpointStatus.ENABLED);
     });
 
-    it('correctly extracts the enabled state', async () => {
+    it('correctly extracts the enabled state for false', async () => {
       const {groups} =
           await setUpTestWithOneBreakpointLocation({file: '', lineNumber: 0, columnNumber: 0, enabled: false});
       const breakpointItem = groups[0].breakpointItems[0];
       assert.strictEqual(breakpointItem.status, Sources.BreakpointsView.BreakpointStatus.DISABLED);
     });
 
-    it('correctly extracts the enabled state', async () => {
+    it('correctly extracts the enabled state for multiple', async () => {
       const testData = [
         createLocationTestData(TEST_JS_FILE, 3, 15, true /* enabled */),
         createLocationTestData(TEST_JS_FILE, 3, 15, false /* enabled */),

front_end/ui/legacy/ListModel.test.ts

@@ -33,7 +33,7 @@ describe('ListModel', () => {
     assert.deepEqual([...model], [5, 6, 7, 1, 2, 10]);
   });
 
-  it('supports removing list elements', () => {
+  it('supports removing list elements last', () => {
     const model = new UI.ListModel.ListModel([5, 6, 7, 1, 2, 10]);
     model.remove(model.length - 1);
     assert.deepEqual([...model], [5, 6, 7, 1, 2]);
@@ -45,7 +45,7 @@ describe('ListModel', () => {
     assert.deepEqual([...model], [5, 6, 7, 1]);
   });
 
-  it('supports replacing list elements in place', () => {
+  it('supports inserting list elements in place', () => {
     const model = new UI.ListModel.ListModel([5, 6, 7, 1]);
     model.insert(1, 8);
     assert.deepEqual([...model], [5, 8, 6, 7, 1]);