[eslint] Prefer explicit assert.strictEqual / assert.notStrictEqual.

This yields much more actionable error messages than using generic
assertions with strict equality/inequality operators.

Also update the `prefer-assert-is-ok` rule to automatically fix negated
conditions, simplifying `assert.isOk(!e)` to `assert.isNotOk(e)` which
is easier on the eyes and more explicit.

Bug: 397260638
Change-Id: I24f7863c1c02923574776f55efdf42423d5cd6a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6450700
Auto-Submit: Benedikt Meurer <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>

Author: bmeurer

eslint.config.mjs

@@ -699,6 +699,7 @@ export default [
       'rulesdir/prefer-assert-instance-of': 'error',
       'rulesdir/prefer-assert-is-ok': 'error',
       'rulesdir/prefer-assert-length-of': 'error',
+      'rulesdir/prefer-assert-strict-equal': 'error',
       'rulesdir/prefer-sinon-assert': 'error',
       'rulesdir/prefer-url-string': 'error',
       'rulesdir/trace-engine-test-timeouts': 'error',

front_end/core/platform/StringUtilities.test.ts

@@ -269,9 +269,9 @@ describe('StringUtilities', () => {
       const stringA = ' '.repeat(10000);
       const stringB = stringA + ' ';
       const hashA = Platform.StringUtilities.hashCode(stringA);
-      assert.isTrue(hashA !== Platform.StringUtilities.hashCode(stringB));
+      assert.notStrictEqual(hashA, Platform.StringUtilities.hashCode(stringB));
       assert.isTrue(isFinite(hashA));
-      assert.isTrue(hashA + 1 !== hashA);
+      assert.notStrictEqual(hashA + 1, hashA);
     });
   });
 

front_end/core/sdk/NetworkManager.test.ts

@@ -432,14 +432,14 @@ describeWithMockConnection('MultitargetNetworkManager', () => {
         {requestId, loaderId: '', request: {url: 'example.com'}} as Protocol.Network.RequestWillBeSentEvent);
 
     const {request} = await requestPromise;
-    assert.isOk(SDK.NetworkManager.NetworkManager.forRequest(request) === initialNetworkManager);
+    assert.strictEqual(SDK.NetworkManager.NetworkManager.forRequest(request), initialNetworkManager);
     assert.isOk(multiTargetNetworkManager.inflightMainResourceRequests.has(requestId));
 
     const workerNetworkManager = workerTarget.model(SDK.NetworkManager.NetworkManager)!;
     workerNetworkManager.dispatcher.loadingFinished({requestId} as Protocol.Network.LoadingFinishedEvent);
 
-    assert.isOk(SDK.NetworkManager.NetworkManager.forRequest(request) === workerNetworkManager);
-    assert.isOk(!multiTargetNetworkManager.inflightMainResourceRequests.has(requestId));
+    assert.strictEqual(SDK.NetworkManager.NetworkManager.forRequest(request), workerNetworkManager);
+    assert.isNotOk(multiTargetNetworkManager.inflightMainResourceRequests.has(requestId));
   });
 
   it('uses main frame to get certificate', () => {

front_end/core/sdk/OverlayPersistentHighlighter.test.ts

@@ -113,7 +113,7 @@ describeWithEnvironment('OverlayPersistentHighlighter', () => {
     highlighter.hideFlexInOverlay(EXISTING_NODE_ID);
     assert.deepEqual(
         stubbedCallbacks.onFlexOverlayStateChanged.secondCall.args, [{nodeId: EXISTING_NODE_ID, enabled: false}]);
-    assert(!highlighter.isFlexHighlighted(EXISTING_NODE_ID));
+    assert.isNotOk(highlighter.isFlexHighlighted(EXISTING_NODE_ID));
     assertSavedSettingState([]);
   });
 
@@ -131,7 +131,7 @@ describeWithEnvironment('OverlayPersistentHighlighter', () => {
     highlighter.hideGridInOverlay(EXISTING_NODE_ID);
     assert.deepEqual(
         stubbedCallbacks.onGridOverlayStateChanged.secondCall.args, [{nodeId: EXISTING_NODE_ID, enabled: false}]);
-    assert(!highlighter.isGridHighlighted(EXISTING_NODE_ID));
+    assert.isNotOk(highlighter.isGridHighlighted(EXISTING_NODE_ID));
     assertSavedSettingState([]);
   });
 
@@ -147,7 +147,7 @@ describeWithEnvironment('OverlayPersistentHighlighter', () => {
     }]);
 
     highlighter.hideScrollSnapInOverlay(EXISTING_NODE_ID);
-    assert(!highlighter.isScrollSnapHighlighted(EXISTING_NODE_ID));
+    assert.isNotOk(highlighter.isScrollSnapHighlighted(EXISTING_NODE_ID));
     assert.deepEqual(
         stubbedCallbacks.onScrollSnapOverlayStateChanged.secondCall.args, [{nodeId: EXISTING_NODE_ID, enabled: false}]);
     assertSavedSettingState([]);
@@ -166,7 +166,7 @@ describeWithEnvironment('OverlayPersistentHighlighter', () => {
     }]);
 
     highlighter.hideContainerQueryInOverlay(EXISTING_NODE_ID);
-    assert(!highlighter.isContainerQueryHighlighted(EXISTING_NODE_ID));
+    assert.isNotOk(highlighter.isContainerQueryHighlighted(EXISTING_NODE_ID));
     assert.deepEqual(
         stubbedCallbacks.onContainerQueryOverlayStateChanged.secondCall.args,
         [{nodeId: EXISTING_NODE_ID, enabled: false}]);
@@ -183,7 +183,7 @@ describeWithEnvironment('OverlayPersistentHighlighter', () => {
     }]);
 
     highlighter.hideIsolatedElementInOverlay(EXISTING_NODE_ID);
-    assert(!highlighter.isIsolatedElementHighlighted(EXISTING_NODE_ID));
+    assert.isNotOk(highlighter.isIsolatedElementHighlighted(EXISTING_NODE_ID));
     assertSavedSettingState([]);
   });
 

front_end/core/sdk/StorageBucketsModel.test.ts

@@ -159,7 +159,7 @@ describeWithMockConnection('StorageBucketsModel', () => {
       storageBucketsModel.enable();
 
       await listener.waitForBucketEvents(BucketEvents.BUCKET_ADDED, bucketsForStorageKeyCount);
-      assert.isTrue(listener.eventCount(BucketEvents.BUCKET_ADDED) === bucketsForStorageKeyCount);
+      assert.strictEqual(listener.eventCount(BucketEvents.BUCKET_ADDED), bucketsForStorageKeyCount);
       assert.deepEqual(getBucketsForStorageKeys(...storageKeys), listener.bucketInfos(BucketEvents.BUCKET_ADDED));
     });
   });
@@ -178,7 +178,7 @@ describeWithMockConnection('StorageBucketsModel', () => {
 
       storageKeyManager.updateStorageKeys(new Set([storageKey]));
       storageKeyManager.updateStorageKeys(new Set([]));
-      assert.isTrue(setStorageBucketTrackingSpy.callCount === 2);
+      sinon.assert.callCount(setStorageBucketTrackingSpy, 2);
       assert.isTrue(setStorageBucketTrackingSpy.secondCall.calledWithExactly({storageKey, enable: false}));
     });
 
@@ -194,7 +194,7 @@ describeWithMockConnection('StorageBucketsModel', () => {
       const removedStorageKey = storageKeys.pop() as string;
       storageKeyManager.updateStorageKeys(new Set(storageKeys));
       await listener.waitForBucketEvents(BucketEvents.BUCKET_REMOVED, 2);
-      assert.isTrue(listener.eventCount(BucketEvents.BUCKET_REMOVED) === 2);
+      assert.strictEqual(listener.eventCount(BucketEvents.BUCKET_REMOVED), 2);
       assert.deepEqual(getBucketsForStorageKeys(removedStorageKey), listener.bucketInfos(BucketEvents.BUCKET_REMOVED));
     });
   });
@@ -220,13 +220,13 @@ describeWithMockConnection('StorageBucketsModel', () => {
       storageKeyManager.updateStorageKeys(new Set(storageKeys));
 
       await listener.waitForBucketEvents(BucketEvents.BUCKET_ADDED, 3);
-      assert.isTrue(listener.eventCount(BucketEvents.BUCKET_ADDED) === 3);
+      assert.strictEqual(listener.eventCount(BucketEvents.BUCKET_ADDED), 3);
       const expectedBuckets = getBucketsForStorageKeys(...storageKeys);
       assert.deepEqual(expectedBuckets, listener.bucketInfos(BucketEvents.BUCKET_ADDED));
 
       storageBucketsModel.storageBucketCreatedOrUpdated({bucketInfo: STORAGE_BUCKET_INFO_TO_CREATE});
       await listener.waitForBucketEvents(BucketEvents.BUCKET_ADDED, 4);
-      assert.isTrue(listener.eventCount(BucketEvents.BUCKET_ADDED) === 4);
+      assert.strictEqual(listener.eventCount(BucketEvents.BUCKET_ADDED), 4);
       expectedBuckets.push(STORAGE_BUCKET_INFO_TO_CREATE);
       assert.deepEqual(expectedBuckets, listener.bucketInfos(BucketEvents.BUCKET_ADDED));
     });
@@ -241,11 +241,11 @@ describeWithMockConnection('StorageBucketsModel', () => {
       storageKeyManager.updateStorageKeys(new Set(storageKeys));
 
       await listener.waitForBucketEvents(BucketEvents.BUCKET_ADDED, 3);
-      assert.isTrue(listener.eventCount(BucketEvents.BUCKET_CHANGED) === 0);
+      assert.strictEqual(listener.eventCount(BucketEvents.BUCKET_CHANGED), 0);
 
       storageBucketsModel.storageBucketCreatedOrUpdated({bucketInfo: STORAGE_BUCKET_INFO_UPDATED});
       await listener.waitForBucketEvents(BucketEvents.BUCKET_CHANGED, 1);
-      assert.isTrue(listener.eventCount(BucketEvents.BUCKET_CHANGED) === 1);
+      assert.strictEqual(listener.eventCount(BucketEvents.BUCKET_CHANGED), 1);
       assert.deepEqual(listener.bucketInfos(BucketEvents.BUCKET_CHANGED)[0], STORAGE_BUCKET_INFO_UPDATED);
     });
 
@@ -259,11 +259,11 @@ describeWithMockConnection('StorageBucketsModel', () => {
       storageKeyManager.updateStorageKeys(new Set(storageKeys));
 
       await listener.waitForBucketEvents(BucketEvents.BUCKET_ADDED, 3);
-      assert.isTrue(listener.eventCount(BucketEvents.BUCKET_REMOVED) === 0);
+      assert.strictEqual(listener.eventCount(BucketEvents.BUCKET_REMOVED), 0);
 
       storageBucketsModel.storageBucketDeleted({bucketId: STORAGE_BUCKET_INFO_REMOVED.id});
       await listener.waitForBucketEvents(BucketEvents.BUCKET_REMOVED, 1);
-      assert.isTrue(listener.eventCount(BucketEvents.BUCKET_REMOVED) === 1);
+      assert.strictEqual(listener.eventCount(BucketEvents.BUCKET_REMOVED), 1);
       assert.deepEqual(listener.bucketInfos(BucketEvents.BUCKET_REMOVED)[0], STORAGE_BUCKET_INFO_REMOVED);
     });
   });

front_end/models/ai_assistance/agents/StylingAgent.test.ts

@@ -758,7 +758,7 @@ STOP`,
         const actionSteps = result.filter(step => {
           return step.type === AiAssistance.ResponseType.ACTION;
         });
-        assert(actionSteps.length === 1, 'Found non or multiple action steps');
+        assert.lengthOf(actionSteps, 1, 'Found non or multiple action steps');
         const actionStep = actionSteps.at(0)!;
         assert(actionStep.output!.includes('Error: Output exceeded the maximum allowed length.'));
       });

front_end/models/breakpoints/BreakpointManager.test.ts

@@ -465,7 +465,7 @@ describeWithMockConnection('BreakpointManager', () => {
     assert.isNull(breakpoint.getLastResolvedState());
     const result = await update;
     // Make sure that no error occurred.
-    assert.isTrue(result === Breakpoints.BreakpointManager.DebuggerUpdateResult.OK);
+    assert.strictEqual(result, Breakpoints.BreakpointManager.DebuggerUpdateResult.OK);
     assert.strictEqual(breakpoint.getLastResolvedState()?.[0].lineNumber, 13);
     await breakpoint.remove(false);
     Workspace.Workspace.WorkspaceImpl.instance().removeProject(project);

front_end/models/text_utils/TextRange.test.ts

@@ -402,7 +402,7 @@ describe('TextRange', () => {
   it('can be stringified', () => {
     const textRange =
         TextUtils.TextRange.TextRange.fromObject({startLine: 1, startColumn: 2, endLine: 3, endColumn: 4});
-    assert.isTrue(typeof textRange.toString() === 'string', 'toString should return a string');
+    assert.strictEqual(typeof textRange.toString(), 'string', 'toString should return a string');
   });
 
   describe('intersection', () => {

front_end/models/trace/insights/DocumentLatency.test.ts

@@ -27,7 +27,7 @@ describeWithEnvironment('DocumentLatency', function() {
     const insight =
         getInsightOrError('DocumentLatency', insights, getFirstOrError(data.Meta.navigationsByNavigationId.values()));
     assert.strictEqual(insight.data?.serverResponseTime, 43);
-    assert(insight.data?.checklist.serverResponseIsFast.value === true);
+    assert.isTrue(insight.data?.checklist.serverResponseIsFast.value);
     assert.deepEqual(insight.metricSavings, {FCP: 0, LCP: 0} as Trace.Insights.Types.MetricSavings);
   });
 
@@ -56,7 +56,7 @@ describeWithEnvironment('DocumentLatency', function() {
     const context = createContextForNavigation(data, navigation, data.Meta.mainFrameId);
     const insight = Trace.Insights.Models.DocumentLatency.generateInsight(data, context);
     assert.strictEqual(insight.data?.serverResponseTime, 1043);
-    assert(insight.data?.checklist.serverResponseIsFast.value === false);
+    assert.isFalse(insight.data?.checklist.serverResponseIsFast.value);
     assert.deepEqual(insight.metricSavings, {FCP: 943, LCP: 943} as Trace.Insights.Types.MetricSavings);
   });
 
@@ -101,7 +101,7 @@ describeWithEnvironment('DocumentLatency', function() {
     assert.strictEqual(insight.data?.redirectDuration, 6059);
     assert.strictEqual(insight.data?.uncompressedResponseBytes, 111506);
     assert.strictEqual(insight.data?.serverResponseTime, 2008);
-    assert(insight.data?.checklist.serverResponseIsFast.value === false);
+    assert.isFalse(insight.data?.checklist.serverResponseIsFast.value);
     assert.deepEqual(insight.metricSavings, {FCP: 7967, LCP: 7967} as Trace.Insights.Types.MetricSavings);
   });
 });

front_end/models/trace/lantern/metrics/FirstContentfulPaint.test.ts

@@ -41,6 +41,7 @@ describe('Metrics: Lantern FCP', function() {
 
   it('should handle negative request networkEndTime', async () => {
     const data = await getComputationDataFromFixture({trace});
+    // eslint-disable-next-line rulesdir/prefer-assert-strict-equal
     assert(data.graph.type === 'network');
     data.graph.request.networkEndTime = -1;
     const result = FirstContentfulPaint.compute(data);