Skip to content

Commit ec072de

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
authored andcommitted
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8719788792218476385 [email protected] Bug: none Change-Id: Ic9b4442aecfc18ffaf55966d2737fe4ff870395b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381836 Reviewed-by: Jack Franklin <[email protected]> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Jack Franklin <[email protected]>
1 parent ab91490 commit ec072de

File tree

4 files changed

+91
-27
lines changed

4 files changed

+91
-27
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '940abfc668be2591483f7132145593c6a047f3cf',
2525

2626
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : 'c855ab36dac455eed8e4330b747b137802146ad0',
27+
'chromium_browser_protocol_revision' : 'cd30077dafb4b107c205b960c0d1226ae82c27bf',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

front_end/generated/SupportedCSSProperties.js

Lines changed: 45 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -145,14 +145,6 @@ export const generatedProperties = [
145145
{
146146
"name": "-webkit-perspective-origin-y"
147147
},
148-
{
149-
"inherited": true,
150-
"keywords": [
151-
"economy",
152-
"exact"
153-
],
154-
"name": "-webkit-print-color-adjust"
155-
},
156148
{
157149
"inherited": true,
158150
"keywords": [
@@ -301,7 +293,6 @@ export const generatedProperties = [
301293
"-webkit-mask-box-image-width",
302294
"-webkit-mask-position-x",
303295
"-webkit-mask-position-y",
304-
"-webkit-print-color-adjust",
305296
"-webkit-rtl-ordering",
306297
"-webkit-ruby-position",
307298
"-webkit-tap-highlight-color",
@@ -421,13 +412,15 @@ export const generatedProperties = [
421412
"column-count",
422413
"column-fill",
423414
"column-gap",
415+
"column-height",
424416
"column-rule-break",
425417
"column-rule-color",
426418
"column-rule-outset",
427419
"column-rule-style",
428420
"column-rule-width",
429421
"column-span",
430422
"column-width",
423+
"column-wrap",
431424
"contain",
432425
"contain-intrinsic-block-size",
433426
"contain-intrinsic-height",
@@ -628,6 +621,7 @@ export const generatedProperties = [
628621
"position-try-order",
629622
"position-visibility",
630623
"prefix",
624+
"print-color-adjust",
631625
"quotes",
632626
"r",
633627
"range",
@@ -1705,6 +1699,12 @@ export const generatedProperties = [
17051699
],
17061700
"name": "column-gap"
17071701
},
1702+
{
1703+
"keywords": [
1704+
"auto"
1705+
],
1706+
"name": "column-height"
1707+
},
17081708
{
17091709
"longhands": [
17101710
"column-rule-width",
@@ -1768,6 +1768,13 @@ export const generatedProperties = [
17681768
],
17691769
"name": "column-width"
17701770
},
1771+
{
1772+
"keywords": [
1773+
"nowrap",
1774+
"wrap"
1775+
],
1776+
"name": "column-wrap"
1777+
},
17711778
{
17721779
"longhands": [
17731780
"column-width",
@@ -3473,6 +3480,14 @@ export const generatedProperties = [
34733480
{
34743481
"name": "prefix"
34753482
},
3483+
{
3484+
"inherited": true,
3485+
"keywords": [
3486+
"economy",
3487+
"exact"
3488+
],
3489+
"name": "print-color-adjust"
3490+
},
34763491
{
34773492
"inherited": true,
34783493
"keywords": [
@@ -4556,12 +4571,6 @@ export const generatedPropertyValues = {
45564571
"none"
45574572
]
45584573
},
4559-
"-webkit-print-color-adjust": {
4560-
"values": [
4561-
"economy",
4562-
"exact"
4563-
]
4564-
},
45654574
"-webkit-rtl-ordering": {
45664575
"values": [
45674576
"logical",
@@ -5090,6 +5099,11 @@ export const generatedPropertyValues = {
50905099
"normal"
50915100
]
50925101
},
5102+
"column-height": {
5103+
"values": [
5104+
"auto"
5105+
]
5106+
},
50935107
"column-rule-break": {
50945108
"values": [
50955109
"none",
@@ -5134,6 +5148,12 @@ export const generatedPropertyValues = {
51345148
"auto"
51355149
]
51365150
},
5151+
"column-wrap": {
5152+
"values": [
5153+
"nowrap",
5154+
"wrap"
5155+
]
5156+
},
51375157
"contain": {
51385158
"values": [
51395159
"none",
@@ -6087,6 +6107,12 @@ export const generatedPropertyValues = {
60876107
"no-overflow"
60886108
]
60896109
},
6110+
"print-color-adjust": {
6111+
"values": [
6112+
"economy",
6113+
"exact"
6114+
]
6115+
},
60906116
"quotes": {
60916117
"values": [
60926118
"auto",
@@ -7083,6 +7109,10 @@ export const generatedAliasesFor = new Map([
70837109
"-webkit-perspective-origin",
70847110
"perspective-origin"
70857111
],
7112+
[
7113+
"-webkit-print-color-adjust",
7114+
"print-color-adjust"
7115+
],
70867116
[
70877117
"-webkit-shape-image-threshold",
70887118
"shape-image-threshold"

front_end/ui/visual_logging/KnownContextValues.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -768,6 +768,7 @@ export const knownContextValues = new Set([
768768
'column-count',
769769
'column-fill',
770770
'column-gap',
771+
'column-height',
771772
'column-rule',
772773
'column-rule-break',
773774
'column-rule-color',
@@ -776,6 +777,7 @@ export const knownContextValues = new Set([
776777
'column-rule-width',
777778
'column-span',
778779
'column-width',
780+
'column-wrap',
779781
'columns',
780782
'combined-diff-view.copy',
781783
'comic-sans-ms',
@@ -2721,6 +2723,7 @@ export const knownContextValues = new Set([
27212723
'primary-key',
27222724
'prime-numbers',
27232725
'print',
2726+
'print-color-adjust',
27242727
'priority',
27252728
'privacy',
27262729
'privacy-notice',

third_party/blink/renderer/core/css/css_properties.json5

Lines changed: 42 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4840,6 +4840,17 @@
48404840
typedom_types: ["Keyword"],
48414841
invalidate: ["layout", "paint"],
48424842
},
4843+
{
4844+
name: "print-color-adjust",
4845+
property_methods: ["CSSValueFromComputedStyleInternal"],
4846+
independent: false, // Actually true, but setting it to false saves a precious bit in ComputedStyleBase.
4847+
inherited: true,
4848+
field_template: "keyword",
4849+
keywords: ["economy", "exact"],
4850+
default_value: "economy",
4851+
valid_for_permission_element: true,
4852+
invalidate: ["paint"],
4853+
},
48434854
{
48444855
name: "quotes",
48454856
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
@@ -6646,6 +6657,33 @@
66466657
typedom_types: ["Keyword", "Length"],
66476658
invalidate: ["layout", "paint"],
66486659
},
6660+
{
6661+
name: "column-height",
6662+
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
6663+
interpolable: true,
6664+
field_group: "*",
6665+
field_template: "primitive",
6666+
default_value: "0.0f",
6667+
type_name: "float",
6668+
computed_style_custom_functions: ["setter"],
6669+
style_builder_template: "auto",
6670+
converter: "ConvertComputedLength<float>",
6671+
keywords: ["auto"],
6672+
typedom_types: ["Keyword", "Length"],
6673+
invalidate: ["layout", "paint"],
6674+
runtime_flag: "MulticolColumnWrapping",
6675+
},
6676+
{
6677+
name: "column-wrap",
6678+
property_methods: ["CSSValueFromComputedStyleInternal"],
6679+
field_group: "*",
6680+
field_template: "keyword",
6681+
keywords: ["nowrap", "wrap"],
6682+
default_value: "nowrap",
6683+
typedom_types: ["Keyword"],
6684+
invalidate: ["layout", "paint"],
6685+
runtime_flag: "MulticolColumnWrapping",
6686+
},
66496687
{
66506688
name: "hyphenate-character",
66516689
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
@@ -6878,17 +6916,6 @@
68786916
// Overlaps with perspective-origin.
68796917
legacy_overlapping: true,
68806918
},
6881-
{
6882-
name: "-webkit-print-color-adjust",
6883-
property_methods: ["CSSValueFromComputedStyleInternal"],
6884-
independent: false, // Actually true, but setting it to false saves a precious bit in ComputedStyleBase.
6885-
inherited: true,
6886-
field_template: "keyword",
6887-
keywords: ["economy", "exact"],
6888-
default_value: "economy",
6889-
valid_for_permission_element: true,
6890-
invalidate: ["paint"],
6891-
},
68926919
{
68936920
name: "-webkit-rtl-ordering",
68946921
property_methods: ["CSSValueFromComputedStyleInternal"],
@@ -7853,6 +7880,10 @@
78537880
name: "-webkit-max-logical-height",
78547881
alias_for: "max-block-size",
78557882
},
7883+
{
7884+
name: "-webkit-print-color-adjust",
7885+
alias_for: "print-color-adjust",
7886+
},
78567887

78577888
// Properties that we ignore in the StyleBuilder.
78587889
// TODO(timloh): This seems wrong, most of these shouldn't reach the

0 commit comments

Comments
 (0)